Skip to content

Refactored the comments for UnlinkedFilesCrawler#15709

Merged
Siedlerchr merged 1 commit into
JabRef:mainfrom
ZiadAbdElFatah:Refactoring-comments-for-UnlinkedFilesCrawler
May 10, 2026
Merged

Refactored the comments for UnlinkedFilesCrawler#15709
Siedlerchr merged 1 commit into
JabRef:mainfrom
ZiadAbdElFatah:Refactoring-comments-for-UnlinkedFilesCrawler

Conversation

@ZiadAbdElFatah

Copy link
Copy Markdown
Collaborator

Related issues and pull requests

Related to #15110

PR Description

Refactored the comments for `UnlinkedFilesCrawler' to match the current behavior of the class.

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [/] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update UnlinkedFilesCrawler class documentation

📝 Documentation

Grey Divider

Walkthroughs

Description
• Updated class documentation to reflect current behavior
• Clarified that results determine linking strategy based on user choice
Diagram
flowchart LR
  A["UnlinkedFilesCrawler"] -- "documentation updated" --> B["Reflects current linking behavior"]
  B -- "clarifies" --> C["Link to existing or create new entry"]
Loading

Grey Divider

File Changes

1. jabgui/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesCrawler.java 📝 Documentation +1/-1

Refactored class documentation for accuracy

• Updated class-level documentation comment to accurately describe current behavior
• Changed description from "create new entries" to "determine whether to link files to existing
 entry or create new entry"
• Clarified that the linking strategy is determined according to user's choice

jabgui/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesCrawler.java


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented May 10, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@subhramit subhramit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as per internal discussion

@Siedlerchr Siedlerchr added this pull request to the merge queue May 10, 2026
@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label May 10, 2026
Merged via the queue into JabRef:main with commit 6e4a6e2 May 10, 2026
64 of 65 checks passed
@ZiadAbdElFatah ZiadAbdElFatah deleted the Refactoring-comments-for-UnlinkedFilesCrawler branch May 10, 2026 11:42
Siedlerchr added a commit to pluto-han/jabref that referenced this pull request May 11, 2026
* upstream/main: (21 commits)
  chore(deps): update dependency com.konghq:unirest-modules-gson to v4.10.0 (JabRef#15715)
  Add manual tests (JabRef#15351)
  Refactored the comments for UnlinkedFilesCrawler (JabRef#15709)
  Replace inline styles with CSS classes (JabRef#15694)
  add test case for multiple authors in csl citaiton (JabRef#15707)
  fix invalid desktop file for linux (JabRef#15702)
  Change FileKeystore and Folder fields to disable/enable (JabRef#15685)
  Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.30.0 to 3.30.1 (JabRef#15696)
  New Crowdin updates (JabRef#15693)
  Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15698)
  Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (JabRef#15700)
  chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.26.0 (JabRef#15699)
  Chore(deps): Bump org.openrewrite.rewrite from 7.32.1 to 7.32.2 (JabRef#15697)
  Chore(deps): Bump jablib/src/main/resources/csl-locales (JabRef#15689)
  Fix month checker regex (JabRef#15678)
  Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (JabRef#15692)
  Chore(deps): Bump org.hisp.dhis:json-tree in /versions (JabRef#15691)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15690)
  New Crowdin updates (JabRef#15687)
  Chore(deps): Bump com.konghq:unirest-java-core in /versions (JabRef#15683)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: no-bot-comments status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants