Skip to content

New Crowdin updates#15693

Merged
Siedlerchr merged 2 commits into
mainfrom
l10n_main
May 7, 2026
Merged

New Crowdin updates#15693
Siedlerchr merged 2 commits into
mainfrom
l10n_main

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

No description provided.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Crowdin localization updates for French and Chinese Simplified

📝 Documentation

Grey Divider

Walkthroughs

Description
• Updated French translation for unbalanced brace error message
• Added 60+ new Chinese Simplified translations for various features
• Translations cover citation handling, file operations, and UI elements
• Includes error messages, preferences, and notification strings
Diagram
flowchart LR
  A["Source Strings"] -->|French Translation| B["JabRef_fr.properties"]
  A -->|Chinese Simplified Translation| C["JabRef_zh_CN.properties"]
  B -->|1 fix| D["Error Message Correction"]
  C -->|60+ additions| E["New Feature Translations"]
Loading

Grey Divider

File Changes

1. jablib/src/main/resources/l10n/JabRef_fr.properties 🐞 Bug fix +1/-1

Fix French brace error message translation

• Fixed unbalanced closing brace character in error message translation
• Changed incorrect '{' to correct '}' in French translation
• Maintains consistency with English source string

jablib/src/main/resources/l10n/JabRef_fr.properties


2. jablib/src/main/resources/l10n/JabRef_zh_CN.properties 📝 Documentation +75/-0

Add comprehensive Chinese Simplified translations

• Added 60+ new Chinese Simplified translations for application features
• Covers citation handling, file operations, merge functionality, and UI preferences
• Includes error messages, notification strings, and theme settings
• Translations for advanced search, PDF handling, and external application integration

jablib/src/main/resources/l10n/JabRef_zh_CN.properties


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (3)

Grey Divider


Action required

1. Citation count fetcher: ends colon 📘 Rule violation ⚙ Maintainability
Description
A newly added UI label string ends with a colon (:), which violates the project’s UI text style
rule. This can lead to inconsistent UI labeling across the application.
Code

jablib/src/main/resources/l10n/JabRef_zh_CN.properties[3]

+Citation\ count\ fetcher\:=引文计数获取:
Evidence
PR Compliance ID 23 forbids UI label text values ending with :. The PR adds the localized label
Citation\ count\ fetcher\: which ends with a colon.

AGENTS.md
jablib/src/main/resources/l10n/JabRef_zh_CN.properties[3-3]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A newly added localization string used as a UI label ends with a colon (`:`), which is disallowed by JabRef UI text style.

## Issue Context
This is in the Chinese localization properties file, but the label key itself includes a trailing colon.

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[3-3]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. Dark Theme not sentence case 📘 Rule violation ⚙ Maintainability
Description
New UI strings use Title Case (e.g., Dark Theme) instead of sentence case, which violates
localization style requirements. This reduces UI text consistency and increases translator/editor
churn.
Code

jablib/src/main/resources/l10n/JabRef_zh_CN.properties[R2221-2223]

+Dark\ Theme=深色主题
+Light\ Theme=浅色主题
+Custom\ Theme=自定义主题
Evidence
PR Compliance ID 25 requires sentence case UI text. The PR adds Dark Theme, Light Theme, and
Custom Theme, which are Title Case.

AGENTS.md
jablib/src/main/resources/l10n/JabRef_zh_CN.properties[2221-2223]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Newly added UI strings use Title Case (`Dark Theme`, `Light Theme`, `Custom Theme`) instead of sentence case.

## Issue Context
Per project localization style rules, UI text should be sentence case unless there is a specific established exception.

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[2221-2223]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


3. BibTeX translated as BibTex 📘 Rule violation ≡ Correctness
Description
A newly added localization value uses incorrect BibTeX capitalization (BibTex) instead of
BibTeX. This violates the project’s BibTeX/Bibtex spelling rule and creates inconsistent UI
terminology.
Code

jablib/src/main/resources/l10n/JabRef_zh_CN.properties[752]

+BibTeX=BibTex
Evidence
PR Compliance ID 25 requires correct BibTeX spelling in user-facing strings. The PR adds
BibTeX=BibTex, which is incorrect capitalization for the displayed text.

AGENTS.md
jablib/src/main/resources/l10n/JabRef_zh_CN.properties[752-752]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The newly added localization entry displays `BibTex` instead of the required `BibTeX` capitalization.

## Issue Context
This is a user-facing term that should be consistent across the UI.

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[752-752]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

4. Empty push-to-app strings 🐞 Bug ◔ Observability
Description
Three new zh_CN strings for external application errors are added with empty values, causing warning
logs and English fallback whenever these messages are used.
Code

jablib/src/main/resources/l10n/JabRef_zh_CN.properties[R2921-2923]

+Could\ not\ call\ executable\ '%0'\ Please\ check\ the\ path\ in\ the\ preferences.=
+Could\ not\ connect\ to\ Emacs.\ Make\ sure\ the\ server\ is\ running.\ In\ Emacs,\ type\ %0\ to\ start\ it.=
+On\ macOS,\ you\ can\ use\ the\ command-line\ binary.=
Evidence
These keys exist in zh_CN but their values are empty. Localization.lookup() explicitly warns and
falls back when the translation is empty. The same keys are defined with non-empty values in the
English properties file, confirming they should not be blank.

jablib/src/main/resources/l10n/JabRef_zh_CN.properties[2920-2925]
jablib/src/main/java/org/jabref/logic/l10n/Localization.java[130-136]
jablib/src/main/resources/l10n/JabRef_en.properties[2920-2925]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
In `JabRef_zh_CN.properties`, several newly introduced error-message keys have empty values. This results in (1) warning logs from `Localization.lookup()` and (2) English fallback text.

### Issue Context
Empty values are worse than missing keys in JabRef’s localization layer because they trigger the explicit empty-translation warning path.

### Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[2921-2923]

### Suggested fix
Provide Chinese translations for these three keys, or remove the entries so the UI falls back without producing empty-translation warnings.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@koppor koppor enabled auto-merge May 6, 2026 20:54
@@ -1,5 +1,6 @@
Unable\ to\ monitor\ file\ changes.\ Please\ close\ files\ and\ processes\ and\ restart.\ You\ may\ encounter\ errors\ if\ you\ continue\ with\ this\ session.=无法监视文件更改。请关闭文件和处理并重新启动。如果您继续本次会话,您可能会遇到错误。

Citation\ count\ fetcher\:=引文计数获取:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. citation count fetcher: ends colon 📘 Rule violation ⚙ Maintainability

A newly added UI label string ends with a colon (:), which violates the project’s UI text style
rule. This can lead to inconsistent UI labeling across the application.
Agent Prompt
## Issue description
A newly added localization string used as a UI label ends with a colon (`:`), which is disallowed by JabRef UI text style.

## Issue Context
This is in the Chinese localization properties file, but the label key itself includes a trailing colon.

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[3-3]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Comment on lines +2221 to +2223
Dark\ Theme=深色主题
Light\ Theme=浅色主题
Custom\ Theme=自定义主题

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. dark theme not sentence case 📘 Rule violation ⚙ Maintainability

New UI strings use Title Case (e.g., Dark Theme) instead of sentence case, which violates
localization style requirements. This reduces UI text consistency and increases translator/editor
churn.
Agent Prompt
## Issue description
Newly added UI strings use Title Case (`Dark Theme`, `Light Theme`, `Custom Theme`) instead of sentence case.

## Issue Context
Per project localization style rules, UI text should be sentence case unless there is a specific established exception.

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[2221-2223]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Merge...=合并...
Merge=合并
Could\ not\ read\ merge\ file.=无法读取合并文件
BibTeX=BibTex

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

3. bibtex translated as bibtex 📘 Rule violation ≡ Correctness

A newly added localization value uses incorrect BibTeX capitalization (BibTex) instead of
BibTeX. This violates the project’s BibTeX/Bibtex spelling rule and creates inconsistent UI
terminology.
Agent Prompt
## Issue description
The newly added localization entry displays `BibTex` instead of the required `BibTeX` capitalization.

## Issue Context
This is a user-facing term that should be consistent across the UI.

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[752-752]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@Siedlerchr Siedlerchr disabled auto-merge May 7, 2026 18:55
@Siedlerchr Siedlerchr merged commit 922c08f into main May 7, 2026
27 checks passed
@Siedlerchr Siedlerchr deleted the l10n_main branch May 7, 2026 18:55
Siedlerchr added a commit to pluto-han/jabref that referenced this pull request May 11, 2026
* upstream/main: (21 commits)
  chore(deps): update dependency com.konghq:unirest-modules-gson to v4.10.0 (JabRef#15715)
  Add manual tests (JabRef#15351)
  Refactored the comments for UnlinkedFilesCrawler (JabRef#15709)
  Replace inline styles with CSS classes (JabRef#15694)
  add test case for multiple authors in csl citaiton (JabRef#15707)
  fix invalid desktop file for linux (JabRef#15702)
  Change FileKeystore and Folder fields to disable/enable (JabRef#15685)
  Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.30.0 to 3.30.1 (JabRef#15696)
  New Crowdin updates (JabRef#15693)
  Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15698)
  Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (JabRef#15700)
  chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.26.0 (JabRef#15699)
  Chore(deps): Bump org.openrewrite.rewrite from 7.32.1 to 7.32.2 (JabRef#15697)
  Chore(deps): Bump jablib/src/main/resources/csl-locales (JabRef#15689)
  Fix month checker regex (JabRef#15678)
  Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (JabRef#15692)
  Chore(deps): Bump org.hisp.dhis:json-tree in /versions (JabRef#15691)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15690)
  New Crowdin updates (JabRef#15687)
  Chore(deps): Bump com.konghq:unirest-java-core in /versions (JabRef#15683)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants