fix invalid desktop file for linux#15702
Merged
Merged
Conversation
Contributor
Review Summary by QodoRemove invalid STARTUP_DIRECTORY from Linux desktop file
WalkthroughsDescription• Remove invalid STARTUP_DIRECTORY line from desktop file • Fixes desktop file compatibility with JDK versions before 26 • Resolves issue with Linux application launcher configuration Diagramflowchart LR
A["JabRef.desktop<br/>with invalid line"] -- "Remove STARTUP_DIRECTORY" --> B["Valid desktop file<br/>for all JDK versions"]
File Changes1. jabgui/buildres/linux/JabRef.desktop
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
Contributor
|
The build of this PR is available at https://builds.jabref.org/pull-15702/. |
Member
Author
Works again
|
2 tasks
Siedlerchr
added a commit
to pluto-han/jabref
that referenced
this pull request
May 11, 2026
* upstream/main: (21 commits) chore(deps): update dependency com.konghq:unirest-modules-gson to v4.10.0 (JabRef#15715) Add manual tests (JabRef#15351) Refactored the comments for UnlinkedFilesCrawler (JabRef#15709) Replace inline styles with CSS classes (JabRef#15694) add test case for multiple authors in csl citaiton (JabRef#15707) fix invalid desktop file for linux (JabRef#15702) Change FileKeystore and Folder fields to disable/enable (JabRef#15685) Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.30.0 to 3.30.1 (JabRef#15696) New Crowdin updates (JabRef#15693) Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15698) Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (JabRef#15700) chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.26.0 (JabRef#15699) Chore(deps): Bump org.openrewrite.rewrite from 7.32.1 to 7.32.2 (JabRef#15697) Chore(deps): Bump jablib/src/main/resources/csl-locales (JabRef#15689) Fix month checker regex (JabRef#15678) Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (JabRef#15692) Chore(deps): Bump org.hisp.dhis:json-tree in /versions (JabRef#15691) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15690) New Crowdin updates (JabRef#15687) Chore(deps): Bump com.konghq:unirest-java-core in /versions (JabRef#15683) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues and pull requests
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/1297
Follow up from #15188
on ubuntu run: to see if it works
PR Description
Fix the desktop file which is mostlikely the culprit here
It contained an invalid path that is only fixed in jdk26 or later openjdk/jdk@72d3a2a
Steps to test
Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)