Fixed nullable eventhandlers#15288
Merged
Merged
Conversation
Contributor
Review Summary by QodoFix nullable event handlers in task notifications
WalkthroughsDescription• Fixed NullPointerException when task event handlers are null • Changed Optional.of() to Optional.ofNullable() for three event handlers • Prevents crashes during PDF drag-and-drop import operations Diagramflowchart LR
A["Task Event Handlers<br/>onSucceeded, onFailed, onCancelled"] -->|"Optional.of()<br/>throws NPE if null"| B["NullPointerException"]
A -->|"Optional.ofNullable()<br/>handles null safely"| C["Proper Handler Execution"]
File Changes1. jabgui/src/main/java/org/jabref/gui/Notifications.java
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
Siedlerchr
approved these changes
Mar 7, 2026
✅ All tests passed ✅🏷️ Commit: c3007a9 Learn more about TestLens at testlens.app. |
5 tasks
2 tasks
3 tasks
Siedlerchr
added a commit
to statxc/jabref
that referenced
this pull request
Mar 10, 2026
* upstream/main: (59 commits) Fix 15000 identifier (JabRef#15286) Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15305) Supress JavaFX VirtualFlow Info log noise for large libraries (10k+). (JabRef#15298) Chore(deps): Bump commons-logging:commons-logging in /versions (JabRef#15304) Fix merge dialog closing immediately when only one PDF importer returns metadata (JabRef#15127) (JabRef#15287) Fixed nullable eventhandlers (JabRef#15288) New Crowdin updates (JabRef#15285) Fix the ESC key for GlobalSearchResultDialog (JabRef#15259) Remove jbang plugin banner (JabRef#15282) Chore(deps): Bump org.apache.httpcomponents.core5:httpcore5 in /versions (JabRef#15281) Udpate to latest gradle master (JabRef#15279) Migrate to GemsFX Notifications (JabRef#14762) Chore(deps): Bump JetBrains/junie-github-action from 0 to 1 (JabRef#15272) Chore(deps): Bump docker/setup-qemu-action from 3 to 4 (JabRef#15269) Feature/citation count dropdown (JabRef#15216) Update dependency org.apache.maven.plugins:maven-resources-plugin to v3.5.0 (JabRef#15275) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15273) Fix more security Fix pr_body leakage Chore: add dependency-management.md (JabRef#15278) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for nullable eventhandlers in #14762
No changelog since introducing PR was merged after last release.
Steps to test
Drag-and-drop a pdf file on JabRef to import citation
Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)