Skip to content

Migrate to GemsFX Notifications#14762

Merged
calixtus merged 42 commits into
mainfrom
notifications
Mar 6, 2026
Merged

Migrate to GemsFX Notifications#14762
calixtus merged 42 commits into
mainfrom
notifications

Conversation

@calixtus

@calixtus calixtus commented Dec 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

ToDos:

  • Fix Show InfoCenter button in MenuBar
  • Align at bottom
  • [ ] Fix background happens irregularily, might be known bug.
  • Migrate notifications
  • Migrate additional notification pane over maintable (for external modification notification)
  • Investigate if background jobs can be migrated (create custom notification ?)
  • Polish

More polish, maybe icons etc. in follow-up prs.

  • Migrate AutomaticFieldEditorDialog to new notifications (review separately starting with 9ccfe6b)

See https://github.com/dlsc-software-consulting-gmbh/GemsFX/blob/master/gemsfx-demo/src/main/java/com/dlsc/gemsfx/demo/InfoCenterApp.java

grafik

Steps to test

Run JabRef, do something that produces a notification (e.g. View > Next preview or open a file)

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@calixtus calixtus added component: ui dev: no-bot-comments If set, there should be no comments from our bots labels Dec 29, 2025
@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Jan 22, 2026
@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

@calixtus
Merge remote-tracking branch 'upstream/main' into notifications
2e29a5d 
# Conflicts:
#	jabgui/src/main/java/org/jabref/gui/DialogService.java
#	jablib/src/main/java/org/jabref/logic/util/NotificationService.java
@calixtus
Merge remote-tracking branch 'upstream/main' into notifications
a56bddf
@calixtus
fix errors
07847a6
@calixtus
Merge remote-tracking branch 'upstream/main' into notifications
1b2f308 
# Conflicts:
#	jabgui/src/main/java/org/jabref/gui/frame/JabRefFrame.java
#	jabgui/src/main/java/org/jabref/gui/frame/MainToolBar.java
@calixtus
Fix timing problem with InfoCenterPane instantiation
8351fbf
@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@calixtus

calixtus commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

Background tasks:
grafik

@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@calixtus

calixtus commented Feb 26, 2026

Copy link
Copy Markdown
Member Author
grafik

@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@calixtus calixtus enabled auto-merge March 4, 2026 20:22
@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@qodo-free-for-open-source-projects

This comment was marked as outdated.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

This comment has been minimized.

Sign in to view
@testlens-app

testlens-app Bot commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 5b07083
▶️ Tests: 10126 executed
⚪️ Checks: 55/55 completed

Learn more about TestLens at testlens.app.

@calixtus calixtus added this pull request to the merge queue Mar 6, 2026
@Siedlerchr

Siedlerchr commented Mar 6, 2026

Copy link
Copy Markdown
Member

tested, works great!

@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Mar 6, 2026
Merged via the queue into main with commit a07a0a4 Mar 6, 2026
56 checks passed
@calixtus calixtus deleted the notifications branch March 6, 2026 10:26
koppor
koppor reviewed Mar 6, 2026
View reviewed changes
Comment thread jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java
REPLACE_ALL(Localization.lang("Find and replace"), KeyBinding.REPLACE_STRING),
MANAGE_KEYWORDS(Localization.lang("Manage keywords")),
MASS_SET_FIELDS(Localization.lang("Manage field names & content")),
INFOCENTER(Localization.lang("Show notifications"), IconTheme.JabRefIcons.EMAIL),

@koppor koppor Mar 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is really at the "Edit" menu - Isn't it located somewhere in the help menu?

@InAnYan InAnYan Apr 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't found it in any of the menus 😅

@calixtus calixtus Apr 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, should be added to the help menu too i think

@calixtus calixtus Apr 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a toggle

This was referenced Mar 6, 2026
Closed
Merged
Siedlerchr added a commit to statxc/jabref that referenced this pull request Mar 10, 2026
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix/issue-15108
ac1ca15 
* upstream/main: (59 commits)
  Fix 15000 identifier (JabRef#15286)
  Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15305)
  Supress JavaFX VirtualFlow Info log noise for large libraries (10k+). (JabRef#15298)
  Chore(deps): Bump commons-logging:commons-logging in /versions (JabRef#15304)
  Fix merge dialog closing immediately when only one PDF importer returns metadata (JabRef#15127) (JabRef#15287)
  Fixed nullable eventhandlers (JabRef#15288)
  New Crowdin updates (JabRef#15285)
  Fix the ESC key for GlobalSearchResultDialog (JabRef#15259)
  Remove jbang plugin banner (JabRef#15282)
  Chore(deps): Bump org.apache.httpcomponents.core5:httpcore5 in /versions (JabRef#15281)
  Udpate to latest gradle master (JabRef#15279)
  Migrate to GemsFX Notifications (JabRef#14762)
  Chore(deps): Bump JetBrains/junie-github-action from 0 to 1 (JabRef#15272)
  Chore(deps): Bump docker/setup-qemu-action from 3 to 4 (JabRef#15269)
  Feature/citation count dropdown (JabRef#15216)
  Update dependency org.apache.maven.plugins:maven-resources-plugin to v3.5.0 (JabRef#15275)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15273)
  Fix more security
  Fix pr_body leakage
  Chore: add dependency-management.md (JabRef#15278)
  ...
calixtus added a commit that referenced this pull request Apr 4, 2026
@calixtus
Leftover cleanups from notifications migration #14762
2fa5866
@calixtus calixtus mentioned this pull request Apr 4, 2026
Merged
2 tasks
github-merge-queue Bot pushed a commit that referenced this pull request Apr 4, 2026
@calixtus
Small cleanups and enhancements (#15496)
4ed2022 
* Enhanced error handling for search index clearing

* Reduced log level unimportant messages to reduce console noise

* Leftover cleanups from notifications migration #14762

---------

Co-authored-by: Carl Christian Snethlage <calixtus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor left review comments

@InAnYan InAnYan InAnYan left review comments

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects[bot] qodo-free-for-open-source-projects[bot] left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

component: notifications component: ui status: changes-required Pull requests that are not yet complete status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calixtus @Siedlerchr @koppor @InAnYan