Identifier selection on fresh start in New Entry Dialog#15286
Conversation
Automatically selects the appropriate fetcher when entering an identifier (DOI, arXiv, ISBN, SSRN, etc. only those supported in Identifier interface) in the Lookup identifier tab. Fixes JabRef#15000
Ensure the correct identifier fetcher is selected when initializing the dialog from clipboard content and when parsing the identifier text. Refactors updateFetcherFromIdentifierText to use the Identifier API more clearly and updates the fetcher accordingly. Fixes JabRef#15000
|
Hey @andrea02polimi! 👋 Thank you for contributing to JabRef! We have automated checks in place, based on which you will soon get feedback if any of them are failing. We also use Qodo for review assistance. It will update your pull request description with a review help and offer suggestions to improve the pull request. After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. You can read about the whole pull request process in our contribution guide. Please ensure that your pull request is in line with our AI Usage Policy and make necessary disclosures. |
Review Summary by QodoAuto-detect identifier type on fresh start in New Entry dialog
WalkthroughsDescription• Auto-detect identifier type when opening New Entry dialog with clipboard content • Refactored identifier detection logic to use Identifier API consistently • Fixed text field binding to use correct field for identifier input • Improved fetcher initialization and null-safety checks Diagramflowchart LR
A["Dialog Initialization"] --> B["Check Clipboard Content"]
B --> C["Detect Identifier Type"]
C --> D["Set Appropriate Fetcher"]
D --> E["Pre-fill Identifier Field"]
B --> F["User Types in Field"]
F --> G["Update Fetcher on Text Change"]
File Changes1. jabgui/src/main/java/org/jabref/gui/newentry/NewEntryView.java
|
Code Review by Qodo
1.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ All tests passed ✅🏷️ Commit: 6954dd9 Learn more about TestLens at testlens.app. |
* upstream/main: (59 commits) Fix 15000 identifier (JabRef#15286) Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15305) Supress JavaFX VirtualFlow Info log noise for large libraries (10k+). (JabRef#15298) Chore(deps): Bump commons-logging:commons-logging in /versions (JabRef#15304) Fix merge dialog closing immediately when only one PDF importer returns metadata (JabRef#15127) (JabRef#15287) Fixed nullable eventhandlers (JabRef#15288) New Crowdin updates (JabRef#15285) Fix the ESC key for GlobalSearchResultDialog (JabRef#15259) Remove jbang plugin banner (JabRef#15282) Chore(deps): Bump org.apache.httpcomponents.core5:httpcore5 in /versions (JabRef#15281) Udpate to latest gradle master (JabRef#15279) Migrate to GemsFX Notifications (JabRef#14762) Chore(deps): Bump JetBrains/junie-github-action from 0 to 1 (JabRef#15272) Chore(deps): Bump docker/setup-qemu-action from 3 to 4 (JabRef#15269) Feature/citation count dropdown (JabRef#15216) Update dependency org.apache.maven.plugins:maven-resources-plugin to v3.5.0 (JabRef#15275) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15273) Fix more security Fix pr_body leakage Chore: add dependency-management.md (JabRef#15278) ...
* Auto-detect identifier type in New Entry dialog Automatically selects the appropriate fetcher when entering an identifier (DOI, arXiv, ISBN, SSRN, etc. only those supported in Identifier interface) in the Lookup identifier tab. Fixes JabRef#15000 * Auto-detect identifier type in New Entry dialog Ensure the correct identifier fetcher is selected when initializing the dialog from clipboard content and when parsing the identifier text. Refactors updateFetcherFromIdentifierText to use the Identifier API more clearly and updates the fetcher accordingly. Fixes JabRef#15000 * Update changelog for auto identifier detection on fresh start * bug fix: overeager clipboard prefill * Link implementation to requirement newentry.clipboard.autofocus * Apply javadoc formatter * Link implementation to requirement newentry.clipboard.autofocus * Link implementation to requirement newentry.clipboard.autofocus * Use correct requirement newentry.clipboard.autofocus --------- Co-authored-by: andreazhang <andrea.zhang@polimi.mail.com>
* Auto-detect identifier type in New Entry dialog Automatically selects the appropriate fetcher when entering an identifier (DOI, arXiv, ISBN, SSRN, etc. only those supported in Identifier interface) in the Lookup identifier tab. Fixes JabRef#15000 * Auto-detect identifier type in New Entry dialog Ensure the correct identifier fetcher is selected when initializing the dialog from clipboard content and when parsing the identifier text. Refactors updateFetcherFromIdentifierText to use the Identifier API more clearly and updates the fetcher accordingly. Fixes JabRef#15000 * Update changelog for auto identifier detection on fresh start * bug fix: overeager clipboard prefill * Link implementation to requirement newentry.clipboard.autofocus * Apply javadoc formatter * Link implementation to requirement newentry.clipboard.autofocus * Link implementation to requirement newentry.clipboard.autofocus * Use correct requirement newentry.clipboard.autofocus --------- Co-authored-by: andreazhang <andrea.zhang@polimi.mail.com>
Closes #15000
PR Description
Automatically detects the identifier type on fresh start.
Previously, when opening "Add entry using identifier" with an identifier already in the clipboard, the identifier field was pre-filled but the identifier type was not automatically selected and remained empty.
Steps to test
Note: it works for all types present in the
Identifierclass, namely:10.1145/3368089.3409749(DOI)arXiv:1706.037629780262033848(ISBN)https://ssrn.com/abstract=123456Checklist
CHANGELOG.md