• Uncommented WixUIBannerBmp variable in Windows installer configuration
• Changed forward slashes to backslashes in banner file path
• Enables custom banner display in WiX installer UI

Enable WiX banner with corrected path separator

• Uncommented the WixUIBannerBmp WixVariable declaration
• Changed file path separator from forward slashes to backslashes for Windows compatibility
• Enables custom banner image display in WiX installer UI

jabgui/buildres/windows/main.wxs

Description

The new ` element is opened but never closed/self-closed, making main.wxs` not well-formed XML and
likely breaking the WiX build. This diverges from established file conventions and reduces
reviewability/maintainability.

Code

jabgui/buildres/windows/main.wxs[104]

+    <WixVariable Id="WixUIBannerBmp" Value="$(var.JpConfigDir)\JabRefTopBanner.bmp">

Evidence

PR Compliance ID 8 requires preserving existing coding conventions; introducing malformed XML breaks
established conventions and can cause build failures. The modified line adds a non-self-closed ``
element with no corresponding closing tag in the immediate file context.

AGENTS.md
jabgui/buildres/windows/main.wxs[104-106]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`jabgui/buildres/windows/main.wxs` introduces a `<WixVariable ...>` start tag but does not close it, making the XML invalid and likely breaking the WiX build.
## Issue Context
WiX variable declarations are typically self-closing elements (e.g., `<WixVariable ... />`). The current code has no `</WixVariable>` later in the file context.
## Fix Focus Areas
- jabgui/buildres/windows/main.wxs[104-106]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

The same $(var.JpConfigDir) is combined using '/' in the include directive but '\\' for the banner
path, which is inconsistent and can be brittle depending on tooling/path normalization.

Code

jabgui/buildres/windows/main.wxs[104]

+    <WixVariable Id="WixUIBannerBmp" Value="$(var.JpConfigDir)\JabRefTopBanner.bmp">

Evidence

This file already establishes a convention of using forward slashes with $(var.JpConfigDir). The new
banner path uses a backslash, creating an inconsistency in how paths are constructed from the same
variable.

jabgui/buildres/windows/main.wxs[15-15]
jabgui/buildres/windows/main.wxs[104-104]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`main.wxs` mixes `/` and `\\` when appending to `$(var.JpConfigDir)`. This inconsistency can lead to hard-to-debug path issues in some build environments and reduces maintainability.
### Issue Context
The file already uses `$(var.JpConfigDir)/...` for the preprocessor include.
### Fix Focus Areas
- jabgui/buildres/windows/main.wxs[15-15]
- jabgui/buildres/windows/main.wxs[104-104]
### Suggested change
After fixing the XML closure, consider changing the banner value to:

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

• Uncommented WixUIBannerBmp variable in Windows installer configuration
• Changed forward slashes to backslashes in file path for Windows compatibility

Enable WixUI banner with corrected path

• Uncommented the WixUIBannerBmp variable declaration
• Changed file path from forward slashes to backslashes for Windows compatibility
• Updated path from $(var.JpConfigDir)/JabRefTopBanner.bmp to
 $(var.JpConfigDir)\JabRefTopBanner.bmp

jabgui/buildres/windows/main.wxs