Fix: Reset External File Type to default by pluto-han · Pull Request #15167 · JabRef/jabref

pluto-han · 2026-02-19T16:14:15Z

Related issues and pull requests

PR Description

This PR fixes the issue where resetting preference does not reset External File Type to default. This is fixed by adding getDefaultExternalFileTypes() in ExternalApplicationsPreferences() .ExternalApplicationsPreferences().

Required vefirication screenshot:

Steps to test

Open File -> Preferences. Click reset preferences.
Note that it does not clear External File Type but reset it to default.

Checklist

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

qodo-free-for-open-source-projects · 2026-02-19T16:14:27Z

Review Summary by Qodo

Fix External File Type reset to default in preferences

🐞 Bug fix

Walkthroughs

Description

• Fixes External File Type not resetting to default when preferences are reset
• Initializes external file types with default values in constructor
• Updates CHANGELOG.md with issue reference

File Changes

1. jabgui/src/main/java/org/jabref/gui/frame/ExternalApplicationsPreferences.java 🐞 Bug fix +2/-1

Initialize external file types with defaults
• Added import for ExternalFileTypes class
• Changed default initialization of externalFileTypes from empty set to default external file
 types
• Uses Set.copyOf(ExternalFileTypes.getDefaultExternalFileTypes()) instead of Set.of()
jabgui/src/main/java/org/jabref/gui/frame/ExternalApplicationsPreferences.java

2. CHANGELOG.md 📝 Documentation +1/-0

Document External File Type reset fix

• Added entry documenting the fix for issue #15117
• Describes the fix for External File Type reset behavior

CHANGELOG.md

qodo-free-for-open-source-projects · 2026-02-19T16:17:04Z

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (2) 📎 Requirement gaps (0)

1. ~~Misaligned externalFileTypes argument~~ ☑ 📘 Rule violation ✓ Correctness

Description

The new constructor argument line introduces excessive whitespace before the inline comment,
deviating from surrounding formatting and reducing readability. This violates the requirement to
keep formatting consistent and diffs minimal.

Code

jabgui/src/main/java/org/jabref/gui/frame/ExternalApplicationsPreferences.java[54]

+                Set.copyOf(ExternalFileTypes.getDefaultExternalFileTypes()),                                                                    // externalFileTypes

Evidence

The checklist requires adhering to existing formatting and avoiding style-only noise in touched
areas. The modified line has unusually large spacing before the // externalFileTypes comment
compared to adjacent arguments, indicating a formatting inconsistency introduced by this PR.

AGENTS.md
AGENTS.md
jabgui/src/main/java/org/jabref/gui/frame/ExternalApplicationsPreferences.java[51-56]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A modified argument line in `ExternalApplicationsPreferences()` has excessive whitespace before the inline comment, deviating from surrounding formatting.
## Issue Context
The constructor arguments use aligned inline comments for readability; the new `externalFileTypes` argument was updated but now has inconsistent spacing.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/frame/ExternalApplicationsPreferences.java[51-56]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. No test for preference reset 📘 Rule violation ⛯ Reliability

Description

This PR changes default handling of externalFileTypes when creating default preferences, which is
a behavior change. No corresponding test changes are included to prevent regressions.

Code

jabgui/src/main/java/org/jabref/gui/frame/ExternalApplicationsPreferences.java[54]

+                Set.copyOf(ExternalFileTypes.getDefaultExternalFileTypes()),                                                                    // externalFileTypes

Evidence

The checklist requires behavior changes to be covered by tests. The PR modifies default preference
construction for externalFileTypes, but the provided diff contains no test additions/updates to
assert the new default/reset behavior.

AGENTS.md
jabgui/src/main/java/org/jabref/gui/frame/ExternalApplicationsPreferences.java[50-67]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A behavior change was made to default construction of `ExternalApplicationsPreferences` (`externalFileTypes` now uses `ExternalFileTypes.getDefaultExternalFileTypes()`), but no tests were updated to cover this reset/default behavior.
## Issue Context
The change fixes a regression where resetting preferences did not restore External File Types to defaults. A deterministic test should assert that default preferences (or the reset path, if testable) contains the expected default external file types.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/frame/ExternalApplicationsPreferences.java[50-67]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. ~~Changelog link format~~ ☑ 🐞 Bug ✓ Correctness

Description

The new CHANGELOG entry uses inconsistent issue link formatting and inconsistent
wording/capitalization compared to adjacent entries and the UI tab name, reducing documentation
consistency.

Code

CHANGELOG.md[49]

+- We fixed an issue where resetting preference does not reset External File Type to default. [15117](https://github.com/JabRef/jabref/issues/15117)

Evidence
The new entry links to the issue without the conventional # prefix used by surrounding items, and
the UI uses the phrasing “External file types” (plural, lower-case), while the changelog says
“External File Type”.
CHANGELOG.md[44-55]
jabgui/src/main/java/org/jabref/gui/preferences/externalfiletypes/ExternalFileTypesTab.java[35-38]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new CHANGELOG entry is inconsistent with surrounding entries: it uses `[15117](...)` instead of `[#15117](...)`, and it refers to “External File Type” (singular, title case) while the UI uses “External file types”.
## Issue Context
This is a documentation-only consistency fix; no runtime behavior changes required.
## Fix Focus Areas
- CHANGELOG.md[49-49]
- jabgui/src/main/java/org/jabref/gui/preferences/externalfiletypes/ExternalFileTypesTab.java[35-38]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

testlens-app · 2026-02-19T16:53:05Z

🔎 No tests executed 🔎

🏷️ Commit: 54526dc
▶️ Tests: 0 executed
⚪️ Checks: 49/49 completed

Learn more about TestLens at testlens.app.

subhramit · 2026-02-20T10:28:13Z

                Localization.lang("References"),                                             // eMailSubject
                OS.WINDOWS,                                                                  // shouldAutoOpenEmailAttachmentsFolder
-                Set.of(),                                                                    // externalFileTypes
+                Set.copyOf(ExternalFileTypes.getDefaultExternalFileTypes()),                                                                    // externalFileTypes


Why copyOf?
Also please adjust the comment alignment with the others in the column

Because Set.copyOf can unpack elements in the list, but Set.of cannot.

Comments are aligned now.

aniruddhkorde9-dot · 2026-02-21T15:36:56Z

Hello! I am a new contributor looking to get involved. I would love to work on this issue. Could you please assign it to me?

subhramit · 2026-02-21T19:58:09Z

Hello! I am a new contributor looking to get involved. I would love to work on this issue. Could you please assign it to me?

You'll be blocked if you have no idea about GitHub and spam assignment requests on PRs this way. Please have the minimum courtesy of looking through how Open Source projects are worked on, and go through a project's contributing guidelines.

github-actions · 2026-02-23T03:56:14Z

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

calixtus

Looks good to me

* refs/heads/main: Increase max assignments from 2 to 3 Chore(deps): Bump io.zonky.test:embedded-postgres in /versions (#15213) Chore(deps): Bump jablib/src/main/resources/csl-styles (#15211) New Crowdin updates (#15208) Fix: Prevent creating empty or duplicate fields (#15168) chore(deps): update jackson monorepo to v3.1.0 (#15203) Update KeywordEditor to work with escaping (#14929) Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (#15205) Chore(deps): Bump tools.jackson:jackson-bom in /versions (#15206) Fix: Reset External File Type to default (#15167) docs: fix link formatting in ADR 0012 (#15201)

* reset preference * add CHANGELOG.md * add CHANGELOG.md * align comments * update CHANGELOG.md * Fixed comment indentation * fix mapping of vars * fix gradle --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Co-authored-by: Siedlerchr <siedlerkiller@gmail.com>

pluto-han added 2 commits February 19, 2026 14:03

reset preference

b8a39db

add CHANGELOG.md

d4fd162

github-actions Bot added good first issue An issue intended for project-newcomers. Varies in difficulty. status: changes-required Pull requests that are not yet complete labels Feb 19, 2026

add CHANGELOG.md

585b1fd

github-actions Bot mentioned this pull request Feb 19, 2026

Resetting of Preferences clears External File Type and does not reset them to default #15117

Closed

2 tasks

github-actions Bot added status: no-bot-comments and removed status: changes-required Pull requests that are not yet complete labels Feb 19, 2026

subhramit reviewed Feb 20, 2026

View reviewed changes

align comments

bba39c1

pluto-han added 2 commits February 21, 2026 23:42

Merge branch 'main' into fix-for-issue-15117

55eeaf8

update CHANGELOG.md

4ffc3bf

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: no-bot-comments labels Feb 21, 2026

Merge branch 'main' into fix-for-issue-15117

ecf19a5

github-actions Bot added status: no-bot-comments and removed status: changes-required Pull requests that are not yet complete labels Feb 23, 2026

calixtus added 2 commits February 23, 2026 21:52

Merge branch 'main' into fix-for-issue-15117

3df6a3a

Fixed comment indentation

dc79548

calixtus previously approved these changes Feb 23, 2026

View reviewed changes

calixtus enabled auto-merge February 23, 2026 20:54

fix mapping of vars

54526dc

Siedlerchr dismissed calixtus’s stale review via 54526dc February 23, 2026 21:21

github-actions Bot removed the status: no-bot-comments label Feb 23, 2026

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Feb 23, 2026

fix gradle

6c35220

calixtus approved these changes Feb 23, 2026

View reviewed changes

github-actions Bot added status: no-bot-comments and removed status: changes-required Pull requests that are not yet complete labels Feb 23, 2026

calixtus added this pull request to the merge queue Feb 23, 2026

github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Feb 23, 2026

Merged via the queue into JabRef:main with commit 2cdc35c Feb 23, 2026
51 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Reset External File Type to default#15167

Fix: Reset External File Type to default#15167
calixtus merged 11 commits into
JabRef:mainfrom
pluto-han:fix-for-issue-15117

pluto-han commented Feb 19, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Feb 19, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Feb 19, 2026 •

edited

Loading

Uh oh!

testlens-app Bot commented Feb 19, 2026 •

edited

Loading

Uh oh!

subhramit Feb 20, 2026

Uh oh!

pluto-han Feb 20, 2026 •

edited

Loading

Uh oh!

aniruddhkorde9-dot commented Feb 21, 2026

Uh oh!

subhramit commented Feb 21, 2026

Uh oh!

github-actions Bot commented Feb 23, 2026

Uh oh!

calixtus left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

pluto-han commented Feb 19, 2026

Related issues and pull requests

PR Description

Steps to test

Checklist

Uh oh!

qodo-free-for-open-source-projects Bot commented Feb 19, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects Bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

testlens-app Bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔎 No tests executed 🔎

Uh oh!

subhramit Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

pluto-han Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aniruddhkorde9-dot commented Feb 21, 2026

Uh oh!

subhramit commented Feb 21, 2026

Uh oh!

github-actions Bot commented Feb 23, 2026

Uh oh!

calixtus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

qodo-free-for-open-source-projects Bot commented Feb 19, 2026 •

edited

Loading

testlens-app Bot commented Feb 19, 2026 •

edited

Loading

pluto-han Feb 20, 2026 •

edited

Loading