Conversation
Contributor
Review Summary by QodoUpdate localization files with Crowdin translations
WalkthroughsDescription• Remove deprecated field validation message across multiple languages • Add new French translations for field formatters and entry cleanup • Add new Italian translations for search configuration and import features • Update Italian field validation message with improved wording Diagramflowchart LR
A["Crowdin Updates"] --> B["Remove deprecated message"]
A --> C["Add new translations"]
B --> D["9 language files"]
C --> E["French translations"]
C --> F["Italian translations"]
D --> G["Updated l10n files"]
E --> G
F --> G
File Changes1. jablib/src/main/resources/l10n/JabRef_de.properties
|
Contributor
Code Review by Qodo
1. Removed locale validation key
|
jabref-machine
approved these changes
Feb 24, 2026
| Optional=Optional | ||
| Required=Erforderlich | ||
| Entry\ type\ cannot\ be\ empty\ and\ must\ not\ contain\ spaces.=Eintragstyp darf nicht leer sein und darf keine Leerzeichen enthalten. | ||
| Field\ cannot\ be\ empty.\ Please\ enter\ a\ name.=Feld darf nicht leer sein. Bitte geben Sie einen Namen ein. |
Contributor
There was a problem hiding this comment.
1. Removed locale validation key 🐞 Bug ✓ Correctness
The GUI still requests the key "Field cannot be empty. Please enter a name.", but this PR removes that key from multiple locale bundles, so users in those locales will see the raw English key text instead of a translation.
Agent Prompt
### Issue description
The localization key `Field cannot be empty. Please enter a name.` is still used by `CustomEntryTypesTabViewModel`, but translations for this key were removed from several locale bundles. This causes untranslated English UI text for users in those locales.
### Issue Context
JabRef’s localization layer returns the key itself when no translation is found, so the regression is silent and won’t crash, but it degrades UX.
### Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/preferences/customentrytypes/CustomEntryTypesTabViewModel.java[74-82]
- jablib/src/main/resources/l10n/JabRef_de.properties[2216-2221]
- jablib/src/main/resources/l10n/JabRef_es.properties[2204-2210]
- jablib/src/main/resources/l10n/JabRef_fr.properties[2246-2252]
- jablib/src/main/resources/l10n/JabRef_ja.properties[1775-1781]
- jablib/src/main/resources/l10n/JabRef_ko.properties[1680-1685]
- jablib/src/main/resources/l10n/JabRef_nl.properties[1836-1841]
- jablib/src/main/resources/l10n/JabRef_pt_BR.properties[2192-2197]
- jablib/src/main/resources/l10n/JabRef_ru.properties[1776-1781]
- jablib/src/main/resources/l10n/JabRef_tr.properties[1868-1873]
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[2214-2219]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
✅ All tests passed ✅🏷️ Commit: 669aa90 Learn more about TestLens at testlens.app. |
Siedlerchr
added a commit
that referenced
this pull request
Feb 25, 2026
* refs/heads/main: Increase max assignments from 2 to 3 Chore(deps): Bump io.zonky.test:embedded-postgres in /versions (#15213) Chore(deps): Bump jablib/src/main/resources/csl-styles (#15211) New Crowdin updates (#15208) Fix: Prevent creating empty or duplicate fields (#15168) chore(deps): update jackson monorepo to v3.1.0 (#15203) Update KeywordEditor to work with escaping (#14929) Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (#15205) Chore(deps): Bump tools.jackson:jackson-bom in /versions (#15206) Fix: Reset External File Type to default (#15167) docs: fix link formatting in ADR 0012 (#15201)
RakockiW
pushed a commit
to RakockiW/jabref
that referenced
this pull request
Mar 1, 2026
* New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (German) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Japanese) * New translations jabref_en.properties (Korean) * New translations jabref_en.properties (Dutch) * New translations jabref_en.properties (Russian) * New translations jabref_en.properties (Turkish) * New translations jabref_en.properties (Chinese Simplified) * New translations jabref_en.properties (Portuguese, Brazilian)
priyanshu16095
pushed a commit
to priyanshu16095/jabref
that referenced
this pull request
Mar 3, 2026
* New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (German) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Japanese) * New translations jabref_en.properties (Korean) * New translations jabref_en.properties (Dutch) * New translations jabref_en.properties (Russian) * New translations jabref_en.properties (Turkish) * New translations jabref_en.properties (Chinese Simplified) * New translations jabref_en.properties (Portuguese, Brazilian)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.