Reset and Import for GroupsPreferences#14572
Merged
Merged
Conversation
Removed unnecessary line break in preference loading method.
Contributor
Author
|
Hi @calixtus can you please review and merge my pr? |
Member
|
I think you forgot to remove the default values from the defaults map. |
calixtus
reviewed
Dec 12, 2025
Contributor
Author
There was a problem hiding this comment.
I have please check there are no actual changes
Contributor
Author
There was a problem hiding this comment.
can you tell what is the change that i need to undo here?
Contributor
Author
There was a problem hiding this comment.
is there a new line that i removed?
Member
There was a problem hiding this comment.
I did it using GitHub UI.
you needed to use the file from main - git checkout main -- ...path... would be the solution.
calixtus
reviewed
Dec 12, 2025
koppor
requested changes
Dec 12, 2025
Comment on lines
+49
to
+54
| false, | ||
| false, | ||
| false, | ||
| false, | ||
| false, | ||
| GroupHierarchyType.INDEPENDENT |
Member
There was a problem hiding this comment.
Where are the comments?
OK, maybe, you did not see, but I really wonder
Screenshot from the issue decsription
koppor
previously requested changes
Dec 12, 2025
Comment on lines
+49
to
+54
| true, // Default view mode intersection | ||
| true, // Default view mode filter | ||
| false, // Default view mode invert | ||
| true, // Default auto assign group | ||
| true, // Default display group content | ||
| GroupHierarchyType.INDEPENDENT // Default hierarchical context |
Contributor
Author
There was a problem hiding this comment.
is was because of intelij's feature of displaying the variables name before the value its because of that sorry let me correct it
Contributor
Author
calixtus
approved these changes
Dec 12, 2025
Siedlerchr
added a commit
that referenced
this pull request
Dec 14, 2025
* upstream/main: (23 commits) Chore(deps): Bump org.mockito:mockito-core in /jablib (#14611) Chore(deps): Bump actions/download-artifact from 6 to 7 (#14605) Chore(deps): Bump com.squareup.okio:okio-jvm in /versions (#14613) Chore(deps): Bump DavidAnson/markdownlint-cli2-action from 21 to 22 (#14607) Chore(deps): Bump org.mockito:mockito-core in /versions (#14615) New translations jabref_en.properties (Italian) (#14596) Reset and Import for GroupsPreferences (#14572) Enable parallel tests (#14571) Copy over label in all cases Also allow adding label Fix workflow (#14586) Unassign issues on stale (#14585) Increase max assignments from 1 to 2 Reduce time for initial PR to 14 days (#14580) New Crowdin updates (#14579) chore(deps): update dependency org.eclipse.jgit:org.eclipse.jgit.pgm to v7.5.0.202512021534-r (#14577) Fix stale closing Try to fix commenting on closed PRs Add 15 non-standard BibLaTeX entry types with .withType() method (#14534) New Crowdin updates (#14570) ...
Siva-Sai22
pushed a commit
to Siva-Sai22/jabref
that referenced
this pull request
Dec 19, 2025
* Added all the necessary methods to both files * Remove newlines Removed unnecessary line break in preference loading method. * Refactor GroupsPreferences to support default constructor and setAll method. * Remove closing component tag from Project.xml * Fix formatting in Project.xml code style settings * Fix code scheme closing tag in Project.xml * Fix missing newline at end of Project.xml * Fix missing newline at end of Project.xml * Removed unnecessary lines * Discard changes to .idea/codeStyles/Project.xml * Removed Default values for the Map * Added Comments to GroupsPreferences. Corrected formatting in JabRefCliPreferences * Format constructor parameters for readability * Change GroupsPreferences constructor to private --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14408
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)