Add 15 non-standard BibLaTeX entry types with .withType() method by shubhamk0205 · Pull Request #14534 · JabRef/jabref

shubhamk0205 · 2025-12-06T01:20:56Z

Adds 15 non-standard BibLaTeX entry types (Artwork, Audio, Bibnote, Commentary, Image, Jurisdiction, Legislation, Legal, Letter, Movie, Music, Performance, Review, Standard, Video) that are hard-coded and only available in BibLaTeX mode. These types are displayed in a dedicated "Non-standard Types" group in the New Entry dialog and in the context menu. The implementation introduces a .withType() method to BibEntryType that allows creating type variants with the same field definitions, enabling all 15 types to be implemented as one-liners based on the MISC entry type.

Steps to test

Prerequisites: Ensure the library is in BibLaTeX mode (Library → Library Properties → General → Library mode = "biblatex").

New Entry dialog: Press Ctrl+N → Scroll to "Non-standard types" section → Verify all 15 types are visible with tooltips → Click any type to create an entry → Verify correct type is set.
Context menu: Right-click an entry → "Change entry type" → "Non-standard Types" → Verify all 15 types listed → Select a type → Verify entry type changes → Confirm no duplicates in main menu.
BibTeX mode: Switch to BibTeX mode → Open New Entry dialog → Verify "Non-standard types" section is hidden → Right-click entry → Verify "Non-standard Types" submenu is not present.
Persistence: Create entry with non-standard type → Add fields → Save library → Close and reopen → Verify entry type persists.

Screenshots

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Siedlerchr · 2025-12-06T15:42:00Z

 Plain\ citation\ parsing\ may\ generate\ inappropriate\ results.=Plain citation parsing may generate inappropriate results.
 Recommended\ types=Recommended types
+Non-standard\ types=Non-standard types
+Non-standard\ Types=Non-standard Types


Duplicate here and add all the other new descriptions

Siedlerchr · 2025-12-06T15:42:15Z

 public class KeyCollisionException extends RuntimeException {

-    private String id;
+    private @Nullable String id;


Do not modify this class

Siedlerchr · 2025-12-06T15:43:32Z

 */
 public class BiblatexEntryTypeDefinitions {

+    static final BibEntryType MISC = new BibEntryTypeBuilder()


Please move to the old position after article, makes it easer to review the changes and I don't think there are some

Siedlerchr · 2025-12-06T15:46:28Z

+     * @param newType The new EntryType to use
+     * @return A new BibEntryType instance with the new type but same field definitions
+     */
+    public BibEntryType withType(@NonNull EntryType newType) {


This is unnecesary, we already hava. constructor

Siedlerchr

See comments
Also you are missing tests

* New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (Danish) * New translations jabref_en.properties (German) * New translations jabref_en.properties (Greek) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Japanese) * New translations jabref_en.properties (Korean) * New translations jabref_en.properties (Dutch) * New translations jabref_en.properties (Norwegian) * New translations jabref_en.properties (Polish) * New translations jabref_en.properties (Portuguese) * New translations jabref_en.properties (Russian) * New translations jabref_en.properties (Swedish) * New translations jabref_en.properties (Turkish) * New translations jabref_en.properties (Chinese Simplified) * New translations jabref_en.properties (Vietnamese) * New translations jabref_en.properties (Portuguese, Brazilian) * New translations jabref_en.properties (Indonesian) * New translations jabref_en.properties (Tagalog)

koppor · 2025-12-07T20:13:54Z

+    private static final BibEntryType MISC = new BibEntryTypeBuilder()
+            .withType(StandardEntryType.Misc)
+            .withRequiredFields(new OrFields(StandardField.AUTHOR, StandardField.EDITOR), StandardField.TITLE, StandardField.DATE)
+            .withImportantFields(
+                    StandardField.SUBTITLE, StandardField.TITLEADDON, StandardField.HOWPUBLISHED, StandardField.LOCATION, StandardField.DOI,
+                    StandardField.EPRINT, StandardField.EPRINTCLASS, StandardField.EPRINTTYPE, StandardField.URL, StandardField.URLDATE)
+            .withDetailFields(StandardField.LANGUAGE,
+                    StandardField.TYPE, StandardField.VERSION, StandardField.NOTE, StandardField.ORGANIZATION,
+                    StandardField.PAGETOTAL, StandardField.ADDENDUM, StandardField.PUBSTATE)
+            .build();
+
    private static final BibEntryType BOOK = new BibEntryTypeBuilder()


We like alphabetical ordering - please keep the position

understood . on it

…java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

…the connected files

calixtus · 2025-12-08T21:39:37Z

+    // Creates object with default preference values
+    private ProxyPreferences() {
+        this(
+                false,      // useProxy: Whether to enable proxy usage
+                "",         // proxyHostname: The hostname of proxy
+                "80",       // proxyPort: Port number on which the proxy is listening
+                false,      // useAuthentication: Whether proxy authentication should be enabled
+                "",         // proxyUsername: Username for proxy authentication (if enabled)
+                "",         // proxyPassword: Password for proxy authentication (if enabled)
+                false       // persistPassword: Whether the proxy password should be saved/persisted
+        );
+    }
+
+    public static ProxyPreferences getDefault() {
+        return new ProxyPreferences();
+    }
+
+    public void setAll(ProxyPreferences preferences) {
+        this.useProxy.set(preferences.shouldUseProxy());
+        this.hostname.set(preferences.getHostname());
+        this.port.set(preferences.getPort());
+        this.useAuthentication.set(preferences.shouldUseAuthentication());
+        this.username.set(preferences.getUsername());
+        this.password.set(preferences.getPassword());
+        this.persistPassword.set(preferences.shouldPersistPassword());
+    }
+


This looks like an artifact from another PR...

this file is not actually modified in this PR , it is identical to main , the commit appears in the history because i think it was merged from the main , but there are no actual changes to that file

@calixtus if u still want this to be removed from the history i will make a new clean pr with the same changes

No, do not create another PR. Just fix / cleanup your branch and push it. the GitHub PR will be updated automatically.

This reverts commit 430b6b9. Clean PR

koppor · 2025-12-11T13:18:03Z

+- We added 15 non-standard BibLaTeX entry types (Artwork, Audio, Bibnote, Commentary, Image, Jurisdiction, Legislation, Legal, Letter, Movie, Music, Performance, Review, Standard, Video) available in BibLaTeX mode only. These types are displayed in a dedicated "Non-standard types" group in the New Entry dialog and in the context menu. [#12963](https://github.com/JabRef/jabref/issues/12963)
 - Improved merge dialog decisions for fields containing person names (e.g., `author`, `editor`) by using a new plausibility comparator. JabRef now prefers the side with more detailed/complete author information. [#14454](https://github.com/JabRef/jabref/issues/14454)
+- We added 15 non-standard BibLaTeX entry types (Artwork, Audio, Bibnote, Commentary, Image, Jurisdiction, Legislation, Legal, Letter, Movie, Music, Performance, Review, Standard, Video) available in BibLaTeX mode only. These types are displayed in a dedicated "Non-standard types" group in the New Entry dialog and in the context menu. [#12963](https://github.com/JabRef/jabref/issues/12963)


Duplicate entry. Plesae fix.

koppor · 2025-12-11T13:19:37Z

-| [ScienceDirect](https://www.sciencedirect.com)                                                                                                    | [Elsevier Dev Portal](https://dev.elsevier.com/)                                                               | `ScienceDirectApiKey`          |                                                                     |
-| [SemanticScholar](https://www.semanticscholar.org/)                                                                                               | <https://www.semanticscholar.org/product/api#api-key-form>                                                     | `SemanticScholarApiKey`        | [20.000 calls/week](https://dev.elsevier.com/api_key_settings.html) |
+| [ScienceDirect](https://www.sciencedirect.com)                                                                                                    | [Elsevier Dev Portal](https://dev.elsevier.com/)                                                               | `ScienceDirectApiKey`          | [20.000 calls/week](https://dev.elsevier.com/api_key_settings.html) |
+| [SemanticScholar](https://www.semanticscholar.org/)                                                                                               | <https://www.semanticscholar.org/product/api#api-key-form>                                                     | `SemanticScholarApiKey`        |                                                                     |


I am not sure about this change - Do we have an issue with GitHub?

main shows at https://github.com/JabRef/jabref/blob/main/docs/code-howtos/fetchers.md

I think some merge went wrong

I merged main and I think it disappeared

Maybe some rebase thingy...

koppor

I fixed the CHANGELOG.md for myself.

obsolete

…Ref#14534) * Add 15 non-standard BibLaTeX entry types with .withType() method * updated ChangeLog.md * fixed formatting issue * fixed Formatting * fixed Checkstyle's DeclarationOrder * fix checkstyle errors * fixed Key Collision error * New Crowdin updates (JabRef#14535) * New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (Danish) * New translations jabref_en.properties (German) * New translations jabref_en.properties (Greek) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Japanese) * New translations jabref_en.properties (Korean) * New translations jabref_en.properties (Dutch) * New translations jabref_en.properties (Norwegian) * New translations jabref_en.properties (Polish) * New translations jabref_en.properties (Portuguese) * New translations jabref_en.properties (Russian) * New translations jabref_en.properties (Swedish) * New translations jabref_en.properties (Turkish) * New translations jabref_en.properties (Chinese Simplified) * New translations jabref_en.properties (Vietnamese) * New translations jabref_en.properties (Portuguese, Brazilian) * New translations jabref_en.properties (Indonesian) * New translations jabref_en.properties (Tagalog) * Revise JavaDoc links in README.md (JabRef#14533) * applied given changes * fixed formatting * fixed formatting * Update jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> * fixed alphabatical ordering * Fix link * Proxy Preference reset (JabRef#14554) * Fix typos (JabRef#14552) * Add LlmPlainCitationParserTest (JabRef#14553) * Junie try 1 * Refine test * Fix casing * updated ChangeLog.md * moved the non-standard types to their own own enum class and updated the connected files * eevert "Proxy Preference reset (JabRef#14554)" This reverts commit 430b6b9. Clean PR * Fix CHANGELOG.md --------- Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Lalit Kumar Verma <lalit2506verma@gmail.com>

* upstream/main: (23 commits) Chore(deps): Bump org.mockito:mockito-core in /jablib (#14611) Chore(deps): Bump actions/download-artifact from 6 to 7 (#14605) Chore(deps): Bump com.squareup.okio:okio-jvm in /versions (#14613) Chore(deps): Bump DavidAnson/markdownlint-cli2-action from 21 to 22 (#14607) Chore(deps): Bump org.mockito:mockito-core in /versions (#14615) New translations jabref_en.properties (Italian) (#14596) Reset and Import for GroupsPreferences (#14572) Enable parallel tests (#14571) Copy over label in all cases Also allow adding label Fix workflow (#14586) Unassign issues on stale (#14585) Increase max assignments from 1 to 2 Reduce time for initial PR to 14 days (#14580) New Crowdin updates (#14579) chore(deps): update dependency org.eclipse.jgit:org.eclipse.jgit.pgm to v7.5.0.202512021534-r (#14577) Fix stale closing Try to fix commenting on closed PRs Add 15 non-standard BibLaTeX entry types with .withType() method (#14534) New Crowdin updates (#14570) ...

…Ref#14534) * Add 15 non-standard BibLaTeX entry types with .withType() method * updated ChangeLog.md * fixed formatting issue * fixed Formatting * fixed Checkstyle's DeclarationOrder * fix checkstyle errors * fixed Key Collision error * New Crowdin updates (JabRef#14535) * New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (Danish) * New translations jabref_en.properties (German) * New translations jabref_en.properties (Greek) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Japanese) * New translations jabref_en.properties (Korean) * New translations jabref_en.properties (Dutch) * New translations jabref_en.properties (Norwegian) * New translations jabref_en.properties (Polish) * New translations jabref_en.properties (Portuguese) * New translations jabref_en.properties (Russian) * New translations jabref_en.properties (Swedish) * New translations jabref_en.properties (Turkish) * New translations jabref_en.properties (Chinese Simplified) * New translations jabref_en.properties (Vietnamese) * New translations jabref_en.properties (Portuguese, Brazilian) * New translations jabref_en.properties (Indonesian) * New translations jabref_en.properties (Tagalog) * Revise JavaDoc links in README.md (JabRef#14533) * applied given changes * fixed formatting * fixed formatting * Update jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> * fixed alphabatical ordering * Fix link * Proxy Preference reset (JabRef#14554) * Fix typos (JabRef#14552) * Add LlmPlainCitationParserTest (JabRef#14553) * Junie try 1 * Refine test * Fix casing * updated ChangeLog.md * moved the non-standard types to their own own enum class and updated the connected files * eevert "Proxy Preference reset (JabRef#14554)" This reverts commit 430b6b9. Clean PR * Fix CHANGELOG.md --------- Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Lalit Kumar Verma <lalit2506verma@gmail.com>

ThiloteE · 2026-02-01T12:01:10Z

@shubhamk0205 This PR caused some issues (see #14985 and #14984). Either we fix it with a follow up PR or we have to revert this one before the JabRef 6.0 release. What's your opinion? Do you have time and willingness for a follow up?

shubhamk0205 · 2026-02-03T21:50:00Z

@shubhamk0205 This PR caused some issues (see #14985 and #14984). Either we fix it with a follow up PR or we have to revert this one before the JabRef 6.0 release. What's your opinion? Do you have time and willingness for a follow up?

sure i will start working on the fix

shubhamk0205 added 2 commits December 6, 2025 06:29

Add 15 non-standard BibLaTeX entry types with .withType() method

03b48c6

updated ChangeLog.md

a27a967

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 6, 2025

shubhamk0205 added 5 commits December 6, 2025 06:57

fixed formatting issue

7d50ef8

fixed Formatting

0a7edfe

fixed Checkstyle's DeclarationOrder

2877bff

fix checkstyle errors

31c6a90

fixed Key Collision error

17049e0

Siedlerchr reviewed Dec 6, 2025

View reviewed changes

Comment thread jabgui/src/main/java/org/jabref/gui/newentry/NewEntryView.java

Siedlerchr reviewed Dec 6, 2025

View reviewed changes

Siedlerchr requested changes Dec 6, 2025

View reviewed changes

Siedlerchr and others added 5 commits December 7, 2025 03:54

Revise JavaDoc links in README.md (JabRef#14533)

5b004f0

applied given changes

77b86ad

fixed formatting

59247bd

fixed formatting

317234e

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 7, 2025

shubhamk0205 requested a review from Siedlerchr December 7, 2025 11:18

Merge branch 'main' into fix-for-issue-12963

8a38484

koppor requested changes Dec 7, 2025

View reviewed changes

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 7, 2025

Update jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.…

65f4fd3

…java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 7, 2025

fixed alphabatical ordering

202afdd

shubhamk0205 requested a review from koppor December 7, 2025 23:26

Merge branch 'main' into fix-for-issue-12963

4b5fd02

D-Prasanth-Kumar approved these changes Dec 8, 2025

View reviewed changes

moved the non-standard types to their own own enum class and updated …

aa3a428

…the connected files

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

calixtus reviewed Dec 8, 2025

View reviewed changes

koppor added the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

shubhamk0205 requested a review from calixtus December 9, 2025 19:39

eevert "Proxy Preference reset (JabRef#14554)"

ee0b097

This reverts commit 430b6b9. Clean PR

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 11, 2025

koppor requested changes Dec 11, 2025

View reviewed changes

Merge branch 'main' into fix-for-issue-12963

0138f25

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 11, 2025

Fix CHANGELOG.md

f8c89fe

koppor approved these changes Dec 11, 2025

View reviewed changes

koppor enabled auto-merge December 11, 2025 13:29

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 11, 2025

koppor requested a review from Siedlerchr December 11, 2025 16:46

Siedlerchr approved these changes Dec 11, 2025

View reviewed changes

koppor added this pull request to the merge queue Dec 11, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025

koppor added this pull request to the merge queue Dec 11, 2025

Merged via the queue into JabRef:main with commit aafb809 Dec 11, 2025
55 checks passed

github-actions Bot mentioned this pull request Dec 11, 2025

Add "Non-standard Types" of biblatex entry types #12963

Closed

This was referenced Jan 30, 2026

[6.0alpha4] (Non-standard) entry type depicted with wrong required fields after switching tabs in entry editor #14985

Closed

[6.0alpha4] library file modified externally (fixed by switching entrytype to misc) #14984

Closed

Uh oh!

Conversation

shubhamk0205 commented Dec 6, 2025 • edited by calixtus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Screenshots

Mandatory checks

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubhamk0205 Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ThiloteE commented Feb 1, 2026

Uh oh!

shubhamk0205 commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shubhamk0205 commented Dec 6, 2025 •

edited by calixtus

Loading

Siedlerchr Dec 6, 2025 •

edited

Loading

Siedlerchr Dec 6, 2025 •

edited

Loading

shubhamk0205 Dec 7, 2025 •

edited

Loading