Automatic lookup DOI at citation information.#13596
Merged
koppor merged 3 commits intoJul 28, 2025
Merged
Conversation
Comment on lines
+161
to
+165
| private EventHandler<ActionEvent> doiLookUp() { | ||
| return actionEvent -> { | ||
| viewModel.lookUpDoi(currentEntry); | ||
| }; | ||
| } |
There was a problem hiding this comment.
The lambda expression contains unnecessary braces and semicolon. It can be simplified to 'return actionEvent -> viewModel.lookUpDoi(currentEntry)' for better readability.
Member
There was a problem hiding this comment.
@andrzej-kaminski @ankamde You can file a follow-up PR to fix this.
koppor
approved these changes
Jul 28, 2025
koppor
left a comment
Member
There was a problem hiding this comment.
Very nice code. I "just" had to unify the notificastion output with the tab "Citation relations" and also add a "dot" due to consistency (see lines above and below in JabRef_en.properties)
I took the liberty to do it for myself. 😅
Contributor
|
Sure, no worries! |
Siedlerchr
added a commit
that referenced
this pull request
Aug 2, 2025
* 'main' of github.com:JabRef/jabref: (26 commits) Change Open AI to Open AI (or API Compatible) (#13608) Remove all assignment tracking labels Updated architecture and components link in CONTRIBUTING.md (#13606) #13301 Fix/unicode reference marks (#13590) Show fetch exception at citation relation (#13549) More jbang caching Sequential run for moving issues Update CSL Styles (#13601) Fix gradle issues (#13603) Add System.exit (#13510) New Crowdin updates (#13600) Automatic lookup DOI at citation information. (#13596) Update heylogs from 0.10.0 to 0.11.1 (#13594) add fallback and reenable defaultcomeslast (#13593) Fix debian vagrant image (#13589) Fix: Replace string "Tests" with "Source Code Tests" in PR Comment (#13587) Fix version for SNAPSHOT (#13581) Update JDK and JavaFX (#13580) Add icon (#13579) Fixes link I broke in PR 13568 (#13577) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13561
In the tab "Citation information, if there is no DOI, offer a "link" to determine the DOI.
Steps to test
@Article{,
author = {Oliver Kopp and Carl Christian Snethlage and Christoph Schwentker},
journal = {TUGboat},
title = {JabRef: BibTeX-based literature management software},
year = {2023},
issn = {0896-3207},
number = {3},
pages = {441--447},
volume = {44},
issue = {138},
ranking = {rank4},
}
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)