#13301 Fix/unicode reference marks#13590
Merged
Merged
Conversation
Uses Pattern.UNICODE_CHARACTER_CLASS so that \w also matches non-ASCII characters (e.g. Cyrillic, Chinese) in citation keys. Adds unit tests with Cyrillic keys.
Member
|
Hi, thanks for your contribution. |
subhramit
reviewed
Jul 26, 2025
Member
|
Hi, the changes look fine, thanks for the video too! However, please fix the PR description as some of the information is hallucinated:
And especially don't use AI when trying to mark the mandatory checks:
|
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
|
@trag-bot didn't find any issues in the code! ✅✨ |
subhramit
approved these changes
Jul 29, 2025
koppor
approved these changes
Jul 29, 2025
2 tasks
Siedlerchr
added a commit
that referenced
this pull request
Aug 2, 2025
* 'main' of github.com:JabRef/jabref: (26 commits) Change Open AI to Open AI (or API Compatible) (#13608) Remove all assignment tracking labels Updated architecture and components link in CONTRIBUTING.md (#13606) #13301 Fix/unicode reference marks (#13590) Show fetch exception at citation relation (#13549) More jbang caching Sequential run for moving issues Update CSL Styles (#13601) Fix gradle issues (#13603) Add System.exit (#13510) New Crowdin updates (#13600) Automatic lookup DOI at citation information. (#13596) Update heylogs from 0.10.0 to 0.11.1 (#13594) add fallback and reenable defaultcomeslast (#13593) Fix debian vagrant image (#13589) Fix: Replace string "Tests" with "Source Code Tests" in PR Comment (#13587) Fix version for SNAPSHOT (#13581) Update JDK and JavaFX (#13580) Add icon (#13579) Fixes link I broke in PR 13568 (#13577) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
Pattern.UNICODE_CHARACTER_CLASSso that\walso matches non-ASCII characters (e.g. Cyrillic, Chinese) in citation keys.Adds unit tests with Cyrillic keys.
Closes #<13301>
Summary of changes
Compiles both regex patterns with
Pattern.UNICODE_CHARACTER_CLASS, allowing Unicode citation keys.Adds two test cases (
Ты2025,Я2025) to verify parsing of Cyrillic keys.Steps to test
Build & launch JabRef from this branch
In JabRef, create a new library containing:
Connect to an open LibreOffice Writer document via the OO/LO panel.
Insert citations for both entries, then click Make/Sync bibliography.
Expected: bibliography appears without error; Writer’s field names show in LibreOffice Writer.
Run automated tests
Screen.Recording.2025-07-26.at.12.48.36.mov
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user “We fixed an issue where the LibreOffice integration did not support citation keys containing Unicode characters.”