Skip to content

Add icon#13579

Merged
Siedlerchr merged 2 commits into
mainfrom
fix-13570
Jul 23, 2025
Merged

Add icon#13579
Siedlerchr merged 2 commits into
mainfrom
fix-13570

Conversation

@koppor

@koppor koppor commented Jul 23, 2025

Copy link
Copy Markdown
Member

Closes #13570

Steps to test

  1. Launch JabRef on linux
  2. Check icon

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the dev: binaries Binary builds should be uploaded to builds.jabref.org label Jul 23, 2025
@koppor koppor mentioned this pull request Jul 23, 2025
2 tasks
Comment thread jabgui/build.gradle.kts
Siedlerchr
Siedlerchr previously approved these changes Jul 23, 2025
@trag-bot

trag-bot Bot commented Jul 23, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@github-actions

Copy link
Copy Markdown
Contributor

The build of this PR is available at https://builds.jabref.org/pull/13579/merge.

@Siedlerchr Siedlerchr added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 1461f7f Jul 23, 2025
2 checks passed
@Siedlerchr Siedlerchr deleted the fix-13570 branch July 23, 2025 19:57
dcarpentiero pushed a commit to dcarpentiero/jabref that referenced this pull request Jul 24, 2025
* Add icon

* Add icon for macOS
@NeymanDmitry

Copy link
Copy Markdown

The penguin disappeared, but the gear remained when launching the app.

Screenshot from 2025-07-24 19-35-51

JabRef 6.0-alpha2.497--2025-07-23--d0637f9
Linux 6.14.0-24-generic amd64
Java 24.0.2
JavaFX 24.0.2+1

@koppor

koppor commented Jul 25, 2025

Copy link
Copy Markdown
Member Author

The penguin disappeared, but the gear remained when launching the app.

You mean:

  1. Not started app: Icon OK
  2. Starting app: Gear Icon (a second icon?)
  3. Running app: Icon OK?

@NeymanDmitry

Copy link
Copy Markdown
  1. Not started app: Icon OK --> True!
  2. Starting app: Gear Icon (a second icon?) --> False! Nothing happens until the app is fully loaded.
  3. Running app: Icon OK? --> The standard icon is OK, but an additional gear icon for the active application appears!

Siedlerchr added a commit that referenced this pull request Aug 2, 2025
* 'main' of github.com:JabRef/jabref: (26 commits)
  Change Open AI to Open AI  (or API Compatible)  (#13608)
  Remove all assignment tracking labels
  Updated architecture and components link in CONTRIBUTING.md (#13606)
  #13301 Fix/unicode reference marks (#13590)
  Show fetch exception at citation relation (#13549)
  More jbang caching
  Sequential run for moving issues
  Update CSL Styles (#13601)
  Fix gradle issues (#13603)
  Add System.exit (#13510)
  New Crowdin updates (#13600)
  Automatic lookup DOI at citation information. (#13596)
  Update heylogs from 0.10.0 to 0.11.1 (#13594)
  add fallback and reenable defaultcomeslast (#13593)
  Fix debian vagrant image (#13589)
  Fix: Replace string "Tests" with "Source Code Tests" in PR Comment (#13587)
  Fix version for SNAPSHOT (#13581)
  Update JDK and JavaFX (#13580)
  Add icon (#13579)
  Fixes link I broke in PR 13568 (#13577)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The icon of JabRef is OpenJDK

3 participants