Skip to content

Run Windows tests only on main (and on demand)#13210

Merged
koppor merged 2 commits into
mainfrom
run-windows-tests-on-demand
Jun 1, 2025
Merged

Run Windows tests only on main (and on demand)#13210
koppor merged 2 commits into
mainfrom
run-windows-tests-on-demand

Conversation

@koppor

@koppor koppor commented Jun 1, 2025

Copy link
Copy Markdown
Member

Follow-up to #12869 (and somehow #9992)

Run Windows tests on main - and manual trigger only; because they take too long - and we have seldomly changes working not on Windows.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [./ Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@trag-bot

trag-bot Bot commented Jun 1, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

1 similar comment
@trag-bot

trag-bot Bot commented Jun 1, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨


tests-windows:
name: Unit tests (Windows) – ${{ matrix.module }}
if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or should this be and and?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A workflow can be run EITHER on push or on dispatch -- it is not possible to manually trigger and say: this also happened on push.

@koppor koppor enabled auto-merge June 1, 2025 18:47
@koppor koppor added this pull request to the merge queue Jun 1, 2025
Merged via the queue into main with commit 8d2d595 Jun 1, 2025
2 checks passed
@koppor koppor deleted the run-windows-tests-on-demand branch June 1, 2025 19:21
Siedlerchr added a commit to brandon-lau0/jabref that referenced this pull request Jun 2, 2025
…or-test

* upstream/main: (102 commits)
  Try to fix output
  Improve AI preferences UI and templates (JabRef#13202)
  Bump jablib/src/main/abbrv.jabref.org from `6926b83` to `333c2f1` (JabRef#13216)
  Bump jablib/src/main/resources/csl-styles from `8a2317a` to `c3df987` (JabRef#13215)
  Fixed search result focus handling (JabRef#13174)
  New Crowdin updates (JabRef#13214)
  Add Pseudonymization to CLI (JabRef#13158)
  Try parallel gource build
  Update gource.yml
  Fix position of checkout
  Preapre: Enable gradle configuration cache (JabRef#13212)
  Add yml as YAML extension (JabRef#13213)
  Fix wrong detection of issue numbers (JabRef#13211)
  Miscellaneous refactoring - II (JabRef#13197)
  Run Windows tests only on main (and on demand) (JabRef#13210)
  Fix porcelain for consistency check (JabRef#13209)
  Use setup-jbang action (instead of custom call of .sh script) (JabRef#13208)
  Add link to JabRef guru (JabRef#13207)
  Switch to gradlex for modularity (JabRef#13112)
  feat(ci-cd): change issue URL pattern (JabRef#13206)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants