Skip to content

Add explicit tests on Mac and Windows#9992

Closed
koppor wants to merge 4 commits into
mainfrom
add-test-on-windows
Closed

Add explicit tests on Mac and Windows#9992
koppor wants to merge 4 commits into
mainfrom
add-test-on-windows

Conversation

@koppor

@koppor koppor commented Jun 8, 2023

Copy link
Copy Markdown
Member

Triggered by #9988

This PR enables running our tests on Windows and Mac OS. In case we add some OS-specific funtionality with tests, they will be executed on the CI, too.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr previously approved these changes Jun 8, 2023
@Siedlerchr

Siedlerchr commented Jun 8, 2023

Copy link
Copy Markdown
Member

cli tests with string align fails. Seems probably an issue with the whitespace char or so

@Siedlerchr Siedlerchr added the status: changes-required Pull requests that are not yet complete label Jun 9, 2023
@Siedlerchr

Copy link
Copy Markdown
Member

Some FileUtil Test fails on Windows and on mac the css file base64 encoding differs. Guess this is okay.

@github-actions

github-actions Bot commented Jul 1, 2023

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr

Copy link
Copy Markdown
Member

Closing this due to inactivity and currenltly not that important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: changes-required Pull requests that are not yet complete status: freeze Issues posponed to a (much) later future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants