Skip to content

Improve AI preferences UI and templates#13202

Merged
subhramit merged 6 commits into
JabRef:mainfrom
InAnYan:fix/ai-preferences
Jun 2, 2025
Merged

Improve AI preferences UI and templates#13202
subhramit merged 6 commits into
JabRef:mainfrom
InAnYan:fix/ai-preferences

Conversation

@InAnYan

@InAnYan InAnYan commented May 31, 2025

Copy link
Copy Markdown
Member

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/822.

Changes:

  • AI preferences:
    • Add explanation to AI features.
    • Move additional features to miscellaneous.
    • Hide expert settings, if their modification is turned off.
    • Add button to reset only one template.
  • AI templates:
    • Now each AI functionality piece is represented by 2 templates - one for system message, other for user message. This is more modern and robust style.
    • Added customizable prompt for plain citation parsing.

UI screenshots of preferences:

Hidden expert settings:
image

Expanded expert settings:
image

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@InAnYan

InAnYan commented May 31, 2025

Copy link
Copy Markdown
Member Author

I could make 2 PRs, one for AI preferences, other for templates, but that would introduce breaking changes.

I'm too lazy, so I made 1 PR. The only problem with this approach is that we can discuss AI preferences UI look for too long

@InAnYan

InAnYan commented May 31, 2025

Copy link
Copy Markdown
Member Author

Oh, I forgot about localization.

(I will sleep now)

trag-bot[bot]
trag-bot Bot reviewed May 31, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/ai/AiService.java
trag-bot[bot]
trag-bot Bot reviewed May 31, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/ai/chatting/AiChatLogic.java
trag-bot[bot]
trag-bot Bot reviewed May 31, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/ai/chatting/AiChatLogic.java
trag-bot[bot]
trag-bot Bot reviewed May 31, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/ai/chatting/AiChatLogic.java
trag-bot[bot]
trag-bot Bot reviewed May 31, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/ai/templates/AiTemplatesService.java
trag-bot[bot]
trag-bot Bot reviewed May 31, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/ai/templates/AiTemplatesService.java
trag-bot[bot]
trag-bot Bot reviewed May 31, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/ai/templates/AiTemplatesService.java
trag-bot[bot]
trag-bot Bot reviewed May 31, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/ai/templates/AiTemplatesService.java
ThiloteE
ThiloteE reviewed Jun 1, 2025
View reviewed changes
Comment thread jabgui/src/main/resources/org/jabref/gui/preferences/ai/AiTab.fxml Outdated
subhramit
subhramit reviewed Jun 1, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java Outdated
@subhramit

subhramit commented Jun 1, 2025

Copy link
Copy Markdown
Member

Conflicts probably arose here because of my last PR. I'll push a commit to resolve

Took the opportunity to fix localization and checkstyle as well

@subhramit subhramit added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 2, 2025
Siedlerchr
Siedlerchr previously approved these changes Jun 2, 2025
View reviewed changes
@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 2, 2025
@subhramit subhramit removed this pull request from the merge queue due to a manual request Jun 2, 2025
@subhramit

subhramit commented Jun 2, 2025

Copy link
Copy Markdown
Member

Committing thilo's suggestion, in case we forget later

@subhramit @ThiloteE
Update jabgui/src/main/resources/org/jabref/gui/preferences/ai/AiTab.…
75a0d80 
…fxml

Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@subhramit subhramit enabled auto-merge June 2, 2025 18:12
@jabref-machine

jabref-machine commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

Your pull request needs to link an issue correctly.

To ease organizational workflows, please link this pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue:

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message.

Examples

  • ✅ Fixes #xyz links pull-request to issue. Merging the PR will close the issue.
  • ✅ Fixes https://github.com/JabRef/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
  • ✅ Fixes https://github.com/Koppor/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
  • ❌ Fixes [#xyz](https://github.com/JabRef/jabref/issues/xyz) links pull-request to issue. Merging the PR will NOT close the issue.

@subhramit

subhramit commented Jun 2, 2025

Copy link
Copy Markdown
Member

image

(for later) @koppor is {{matrix.module}} intended here after the recent changes?

@JabRef JabRef deleted a comment from trag-bot Bot Jun 2, 2025
@subhramit subhramit added this pull request to the merge queue Jun 2, 2025
Merged via the queue into JabRef:main with commit ed1b433 Jun 2, 2025
1 check passed
Siedlerchr added a commit to brandon-lau0/jabref that referenced this pull request Jun 2, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into external-link-creat…
50889e8 
…or-test

* upstream/main: (102 commits)
  Try to fix output
  Improve AI preferences UI and templates (JabRef#13202)
  Bump jablib/src/main/abbrv.jabref.org from `6926b83` to `333c2f1` (JabRef#13216)
  Bump jablib/src/main/resources/csl-styles from `8a2317a` to `c3df987` (JabRef#13215)
  Fixed search result focus handling (JabRef#13174)
  New Crowdin updates (JabRef#13214)
  Add Pseudonymization to CLI (JabRef#13158)
  Try parallel gource build
  Update gource.yml
  Fix position of checkout
  Preapre: Enable gradle configuration cache (JabRef#13212)
  Add yml as YAML extension (JabRef#13213)
  Fix wrong detection of issue numbers (JabRef#13211)
  Miscellaneous refactoring - II (JabRef#13197)
  Run Windows tests only on main (and on demand) (JabRef#13210)
  Fix porcelain for consistency check (JabRef#13209)
  Use setup-jbang action (instead of custom call of .sh script) (JabRef#13208)
  Add link to JabRef guru (JabRef#13207)
  Switch to gradlex for modularity (JabRef#13112)
  feat(ci-cd): change issue URL pattern (JabRef#13206)
  ...
@InAnYan InAnYan deleted the fix/ai-preferences branch April 15, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThiloteE ThiloteE ThiloteE left review comments

@trag-bot trag-bot[bot] trag-bot[bot] left review comments

@subhramit subhramit subhramit approved these changes

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees

No one assigned

Labels

component: ai component: preferences component: ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@InAnYan @subhramit @jabref-machine @Siedlerchr @ThiloteE