Make lobid fetcher search for ISBN as well#13107
Merged
Merged
Conversation
Should resolve more books Fixes #13076
…ddLobidIsbnFetcher * 'addLobidIsbnFetcher' of github.com:JabRef/jabref: (26 commits) Bump com.konghq:unirest-java-core from 4.4.6 to 4.4.7 (#13104) Bump ai.djl:bom from 0.32.0 to 0.33.0 (#13106) Bump org.openrewrite.rewrite from 7.5.0 to 7.6.1 (#13105) Bump com.tngtech.archunit:archunit-junit5-engine from 1.4.0 to 1.4.1 (#13103) Bump com.konghq:unirest-modules-gson from 4.4.6 to 4.4.7 (#13102) Bump jablib/src/main/resources/csl-styles from `b8070a7` to `9b777f6` (#13101) Refine http sever doc (#13100) Add type "Bug" (#13099) Fix dash feat: select correct tab for creation of new entry (#13087) (#13091) Add missing empty line Fix notarization flag (#13095) Add more options to ADR-044 (#13098) Update year (#13097) Add ADR for migration from Apache Commons to Picocli (#13096) fix-localization (#13092) Fix condition for "comment-on-pr" fix-git-version (#13093) hotfix: enable ea build also on label added Check label "dev: binary" for upload to builds.jabref.org (#13086) ...
Member
Author
|
I have no idea how to fix the import order, IntelliJ does not do any changes :( |
| } | ||
|
|
||
| @Override | ||
| public URL getUrlForIdentifier(String identifier) throws URISyntaxException, MalformedURLException { |
There was a problem hiding this comment.
The method getUrlForIdentifier throws URISyntaxException and MalformedURLException, which are checked exceptions. Consider using exceptions for exceptional states, not for normal control flow.
| .withField(StandardField.URL, "http://lobid.org/resources/990212549810206441") | ||
| .withField(StandardField.YEAR, "2016"); | ||
|
|
||
| Optional<BibEntry> fetchedEntry = fetcher.performSearchById("9783862065752"); |
There was a problem hiding this comment.
The method performSearchById should not throw exceptions for normal control flow. Exceptions should be used for exceptional states only.
koppor
approved these changes
May 12, 2025
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve more books
Fixes #13076
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)