Skip to content

Fix notarization flag#13095

Merged
koppor merged 23 commits into
mainfrom
koppor-patch-1
May 11, 2025
Merged

Fix notarization flag#13095
koppor merged 23 commits into
mainfrom
koppor-patch-1

Conversation

@koppor

@koppor koppor commented May 10, 2025

Copy link
Copy Markdown
Member

Follow-up to #13086

Notarization was not correctly routed through..

image

Trying to debug

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr reviewed May 10, 2025
View reviewed changes
Comment thread .github/workflows/binaries-ea.yml Outdated
fi

if { [[ "$RUNNER_OS" == macOS ]] && ( [[ "${GITHUB_REF}" == refs/tags/* ]] || [[ "${{ inputs.notarization }}" == "true" ]] ); }; then
if { [[ ( [[ "${GITHUB_REF}" == refs/tags/* ]] || [[ "${{ inputs.notarization }}" == "true" ]] ); }; then

@Siedlerchr Siedlerchr May 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we suddenly check for tags??

@koppor koppor May 10, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this in the old run, too. -->

jabref/.github/workflows/deployment.yml

Line 226 in 1eb3493

if: ${{ (steps.checksecrets.outputs.secretspresent == 'YES') && (!startsWith(github.ref, 'refs/heads/gh-readonly-queue')) && ((matrix.os != 'macos-13') || !((startsWith(github.ref, 'refs/tags/') || (inputs.notarization == true)))) }}

@Siedlerchr Siedlerchr May 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I wonder if we still need this. I think we used this as part of the release process to use only tag builds but with the manual activation switch I think it is no longer needed

@koppor koppor May 10, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of keeping it: Fully automated release builds without the need of any manual trigger!

@koppor koppor marked this pull request as ready for review May 10, 2025 18:43
@koppor koppor marked this pull request as draft May 10, 2025 18:44
@koppor koppor mentioned this pull request May 11, 2025
Merged
1 task
@koppor koppor added the dev: binaries Binary builds should be uploaded to builds.jabref.org label May 11, 2025
@koppor

koppor commented May 11, 2025

Copy link
Copy Markdown
Member Author

Added disk space checking:

image

@trag-bot

trag-bot Bot commented May 11, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@github-actions

github-actions Bot commented May 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor marked this pull request as ready for review May 11, 2025 18:36
@koppor koppor merged commit 3e1bd93 into main May 11, 2025
2 checks passed
@koppor koppor deleted the koppor-patch-1 branch May 11, 2025 18:36
@trag-bot

trag-bot Bot commented May 11, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

Siedlerchr added a commit that referenced this pull request May 12, 2025
@Siedlerchr
Merge branch 'addLobidIsbnFetcher' of github.com:JabRef/jabref into a…
6692a1e 
…ddLobidIsbnFetcher

* 'addLobidIsbnFetcher' of github.com:JabRef/jabref: (26 commits)
  Bump com.konghq:unirest-java-core from 4.4.6 to 4.4.7 (#13104)
  Bump ai.djl:bom from 0.32.0 to 0.33.0 (#13106)
  Bump org.openrewrite.rewrite from 7.5.0 to 7.6.1 (#13105)
  Bump com.tngtech.archunit:archunit-junit5-engine from 1.4.0 to 1.4.1 (#13103)
  Bump com.konghq:unirest-modules-gson from 4.4.6 to 4.4.7 (#13102)
  Bump jablib/src/main/resources/csl-styles from `b8070a7` to `9b777f6` (#13101)
  Refine http sever doc (#13100)
  Add type "Bug" (#13099)
  Fix dash
  feat: select correct tab for creation of new entry (#13087) (#13091)
  Add missing empty line
  Fix notarization flag (#13095)
  Add more options to ADR-044 (#13098)
  Update year (#13097)
  Add ADR for migration from Apache Commons to Picocli (#13096)
  fix-localization (#13092)
  Fix condition for "comment-on-pr"
  fix-git-version (#13093)
  hotfix: enable ea build also on label added
  Check label "dev: binary" for upload to builds.jabref.org (#13086)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees

No one assigned

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @Siedlerchr