Skip to content

Check label "dev: binary" for upload to builds.jabref.org#13086

Merged
koppor merged 27 commits into
mainfrom
add-on-demand-build-upload
May 10, 2025
Merged

Check label "dev: binary" for upload to builds.jabref.org#13086
koppor merged 27 commits into
mainfrom
add-on-demand-build-upload

Conversation

@koppor

@koppor koppor commented May 9, 2025

Copy link
Copy Markdown
Member

Our build ("artifact") server often runs out of diskscape. Since, we typically do not need to binary available easily, we can reduce the amount of disk space.

Idea: Use label "dev: binary" fo binary builds uploaded to the build server. If no build server upload is done; githubs store is used. Thus, the build will be available in all cases.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Comment thread .github/workflows/deployment.yml Fixed
Comment thread .github/workflows/deployment.yml Fixed
@koppor koppor added the dev: binaries Binary builds should be uploaded to builds.jabref.org label May 9, 2025
Comment thread .github/workflows/binaries.yml Fixed
Comment thread .github/workflows/binaries.yml Fixed
Comment thread .github/workflows/binaries-ea.yml Fixed
@koppor

koppor commented May 9, 2025

Copy link
Copy Markdown
Member Author

if build, ea is now also build:

image

@koppor koppor removed the dev: binaries Binary builds should be uploaded to builds.jabref.org label May 9, 2025
@koppor koppor marked this pull request as ready for review May 9, 2025 14:57
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 9, 2025
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 10, 2025
@koppor koppor marked this pull request as draft May 10, 2025 11:18
@koppor koppor added the dev: binaries Binary builds should be uploaded to builds.jabref.org label May 10, 2025
@trag-bot

trag-bot Bot commented May 10, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@github-actions

github-actions Bot commented May 10, 2025

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor

koppor commented May 10, 2025

Copy link
Copy Markdown
Member Author

Both variants work: with binary build and without.

I also adressed the CodeQL comments.

I merge - fixes can come later

@koppor koppor marked this pull request as ready for review May 10, 2025 14:59
@koppor koppor merged commit e0f9e86 into main May 10, 2025
2 checks passed
@koppor koppor deleted the add-on-demand-build-upload branch May 10, 2025 15:00
@trag-bot

trag-bot Bot commented May 10, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor mentioned this pull request May 10, 2025
1 task
Siedlerchr added a commit that referenced this pull request May 12, 2025
…ddLobidIsbnFetcher

* 'addLobidIsbnFetcher' of github.com:JabRef/jabref: (26 commits)
  Bump com.konghq:unirest-java-core from 4.4.6 to 4.4.7 (#13104)
  Bump ai.djl:bom from 0.32.0 to 0.33.0 (#13106)
  Bump org.openrewrite.rewrite from 7.5.0 to 7.6.1 (#13105)
  Bump com.tngtech.archunit:archunit-junit5-engine from 1.4.0 to 1.4.1 (#13103)
  Bump com.konghq:unirest-modules-gson from 4.4.6 to 4.4.7 (#13102)
  Bump jablib/src/main/resources/csl-styles from `b8070a7` to `9b777f6` (#13101)
  Refine http sever doc (#13100)
  Add type "Bug" (#13099)
  Fix dash
  feat: select correct tab for creation of new entry (#13087) (#13091)
  Add missing empty line
  Fix notarization flag (#13095)
  Add more options to ADR-044 (#13098)
  Update year (#13097)
  Add ADR for migration from Apache Commons to Picocli (#13096)
  fix-localization (#13092)
  Fix condition for "comment-on-pr"
  fix-git-version (#13093)
  hotfix: enable ea build also on label added
  Check label "dev: binary" for upload to builds.jabref.org (#13086)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants