Skip to content

Fix dependendency issues with commons logging#11403

Merged
Siedlerchr merged 9 commits into
mainfrom
updateUnirest
Jun 22, 2024
Merged

Fix dependendency issues with commons logging#11403
Siedlerchr merged 9 commits into
mainfrom
updateUnirest

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Jun 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Update gemfx
update unirest to 4.x and update http client

Fixes #11401
Fixes #11397
Fixes #11398

PubMed import works now: tested with file:
pubmed-36096847.txt

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 21, 2024
@ryan-carpenter

ryan-carpenter commented Jun 22, 2024

Copy link
Copy Markdown

PubMed import also works for me after installing today's rpm.

github-actions[bot]
github-actions Bot reviewed Jun 22, 2024
View reviewed changes
Comment thread src/main/java/org/jabref/logic/net/URLDownload.java Outdated
Comment thread src/main/java/org/jabref/logic/net/URLDownload.java Outdated
Comment thread src/main/java/org/jabref/logic/net/URLDownload.java Outdated
@Siedlerchr Siedlerchr enabled auto-merge June 22, 2024 10:13
@Siedlerchr Siedlerchr mentioned this pull request Jun 22, 2024
Merged
6 tasks
koppor
koppor requested changes Jun 22, 2024
View reviewed changes
Comment thread build.gradle Outdated
Comment thread build.gradle Outdated
Comment thread build.gradle Outdated
Comment thread build.gradle Outdated
Comment thread build.gradle
@github-actions

github-actions Bot commented Jun 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus

calixtus commented Jun 22, 2024

Copy link
Copy Markdown
Member

Looks good to me so far.
The gvk fetcher and the BVB fetcher break with a strange error. Everything seems to be in order. I'll look into it later.
Doesn't have to stop merging this pr.

koppor
koppor approved these changes Jun 22, 2024
View reviewed changes

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge and fix later if an issue occurs 😅

Comment thread build.gradle
// but it was removed in the newer releases.
// The pom.xml associated with such a non-modular artifact does not mention that the artifact depends on the removed code
// (because the artifact was published when this code was still available in the JDK).
forceMerge "controlsfx", "bcprov", "jaxb", "istack", "stax", "log4j"

@koppor koppor Jun 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to try if logging works for a library logging using log4j. I don't know how to find out which one is it 😅🙈

@Siedlerchr Siedlerchr Jun 22, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around in Jabref and tested different dialogs and actions and so far I did not stumble across any error

@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 22, 2024
Merged via the queue into main with commit 7e4e7d3 Jun 22, 2024
@Siedlerchr Siedlerchr deleted the updateUnirest branch June 22, 2024 15:50
Siedlerchr added a commit that referenced this pull request Jun 22, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixMedlineImporterK…
1b6532c 
…eywword

* upstream/main:
  Fix dependendency issues with commons logging (#11403)
  New Crowdin updates (#11411)
  Fix search result mapping use UIDs instead of hashcodes (#11402)
  New translations jabref_en.properties (Russian) (#11404)

# Conflicts:
#	build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@koppor koppor koppor approved these changes

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

4 participants

@Siedlerchr @ryan-carpenter @calixtus @koppor