Skip to content

fix: remove duplicate loading spinner on A2A agents page#2892

Merged
crivetimihai merged 1 commit intoIBM:mainfrom
omorros:fix/agents-double-spinner
Feb 13, 2026
Merged

fix: remove duplicate loading spinner on A2A agents page#2892
crivetimihai merged 1 commit intoIBM:mainfrom
omorros:fix/agents-double-spinner

Conversation

@omorros
Copy link
Copy Markdown
Contributor

@omorros omorros commented Feb 12, 2026

🔗 Related Issue

Closes #2887

📝 Summary

Remove inline placeholder spinner from #agents-table div, keeping only the HTMX #agents-loading indicator. This matches
the pattern already used for servers and tools tabs (commit 6b3283e).

🏷️ Type of Change

  • Bug fix
  • Feature / Enhancement
  • Documentation
  • Refactor
  • Chore (deps, CI, tooling)
  • Other (describe below)

🧪 Verification

Check Command Status
Lint suite make lint N/A (HTML template only)
Unit tests make test N/A (HTML template only)
Coverage ≥ 80% make coverage N/A (HTML template only)

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • Tests added/updated for changes
  • Documentation updated (if applicable)
  • No secrets or credentials committed

📓 Notes (optional)

Single-line HTML removal — no Python code changed, so lint/test/coverage are not affected.

@omorros
fix: remove duplicate loading spinner on A2A agents page
65c9cc3 
Remove inline placeholder spinner from #agents-table div, keeping only the HTMX #agents-loading indicator. This matches the pattern already used for servers and tools tabs (commit 6b3283e). Fixes #2887.

Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
@crivetimihai crivetimihai mentioned this pull request Feb 13, 2026
Open
7 tasks
@crivetimihai
Copy link
Copy Markdown
Member

crivetimihai commented Feb 13, 2026

Thanks @omorros — clean fix. Removing the inline placeholder spinner and relying solely on the HTMX indicator matches the pattern from commit 6b3283e4.

Does this also need to be applied to the MCP Servers, Virtual Servers, and Tools tabs? Issue #2689 reports the same double spinner on those pages.

@omorros
Copy link
Copy Markdown
Contributor Author

omorros commented Feb 13, 2026

Hi @crivetimihai, I investigated this and tested locally, I can only see a single loading spinner on all tabs (MCP Servers,
Virtual Servers, Tools, and A2A Agents) both on page refresh and when toggling "Show Inactive".

Looking at the code, the inline placeholder spinners for Servers, Virtual Servers, and Tools were already removed in commit
6b3283e (PR #2720). My PR #2892 covers the A2A Agents tab which was the only one still having the duplicate spinner.

Could @alinam941106a confirm they are running the latest main branch? The issue might have been observed on an older build
that didn't include #2720.

@crivetimihai crivetimihai self-assigned this Feb 13, 2026
@crivetimihai
Copy link
Copy Markdown
Member

crivetimihai commented Feb 13, 2026

OK, thanks! I'll rebase / get this merged, if something else is found, let's open another issues. Great work!

@crivetimihai
Copy link
Copy Markdown
Member

crivetimihai commented Feb 13, 2026

Rebased onto current main — no conflicts.

Verified consistency: servers, tools, resources, and prompts tabs all use only the HTMX htmx-indicator pattern (no inline placeholder spinner). This PR brings the agents tab in line with that established pattern.

No security, performance, or logic concerns — pure HTML deletion.

crivetimihai
crivetimihai approved these changes Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved. Correct, consistent, and minimal fix.

@omorros
Copy link
Copy Markdown
Contributor Author

omorros commented Feb 13, 2026

Thanks @crivetimihai for the review and the rebase!

@crivetimihai crivetimihai merged commit d7a5951 into IBM:main Feb 13, 2026
44 checks passed
@omorros omorros deleted the fix/agents-double-spinner branch February 13, 2026 12:44
suciu-daniel pushed a commit that referenced this pull request Feb 16, 2026
@omorros @suciu-daniel
fix: remove duplicate loading spinner on A2A agents page (#2892)
eb5d11e 
Remove inline placeholder spinner from #agents-table div, keeping only the HTMX #agents-loading indicator. This matches the pattern already used for servers and tools tabs (commit 6b3283e). Fixes #2887.

Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
vishu-bh pushed a commit that referenced this pull request Feb 18, 2026
@omorros @vishu-bh
fix: remove duplicate loading spinner on A2A agents page (#2892)
37832fa 
Remove inline placeholder spinner from #agents-table div, keeping only the HTMX #agents-loading indicator. This matches the pattern already used for servers and tools tabs (commit 6b3283e). Fixes #2887.

Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
kcostell06 pushed a commit to kcostell06/mcp-context-forge that referenced this pull request Feb 24, 2026
@omorros
fix: remove duplicate loading spinner on A2A agents page (IBM#2892)
133e67f 
Remove inline placeholder spinner from #agents-table div, keeping only the HTMX #agents-loading indicator. This matches the pattern already used for servers and tools tabs (commit 66423cd). Fixes IBM#2887.

Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crivetimihai crivetimihai crivetimihai approved these changes

Assignees

@crivetimihai crivetimihai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG][UI]: Agents page has double loading spinner on refresh

2 participants

@omorros @crivetimihai