Merged
Conversation
fdbf546 to
26bfebb
Compare
marekdano
approved these changes
Feb 6, 2026
Collaborator
marekdano
left a comment
There was a problem hiding this comment.
Tested and it looks good!
LGTM
e27e0d0 to
26bfebb
Compare
This commit addresses multiple loading spinner issues in the admin UI:
1. Fixed double loading spinners on initial page load/refresh
- Removed redundant initial placeholder spinners from Gateways, Catalog,
Tools, and Tool Operations panels
- Now relies solely on HTMX indicators for loading states
- Affected files: mcpgateway/templates/admin.html
2. Fixed spurious spinners triggered by background requests
- Added CSS rules to prevent all .htmx-indicator elements from showing
on unrelated requests
- Scoped indicators to specific panels
- Only show indicators when explicitly targeted via hx-indicator attribute
- Uses proper CSS specificity to ensure targeted indicators are shown
- Prevents spinners from appearing during background /trace requests
- Affected files: mcpgateway/static/admin.css
3. Standardized Resources panel loading indicator
- Replaced simple spinner div with proper HTMX indicator matching other panels
- Added animated SVG spinner with "Loading resources..." text
- Affected files: mcpgateway/templates/admin.html
4. Aligned Prompts panel implementation with other panels
- Removed dual loading state (inline + external indicator)
- Standardized to single external HTMX indicator for consistency
- Changed spinner color to indigo for consistency with other panels
- Affected files: mcpgateway/templates/admin.html
5. Fixed Tool Operations panel loading indicator
- Added indicator to admin.html (outside swap target) so it exists on
initial page load
- Removed duplicate indicator from toolops_partial.html to avoid ID conflict
- Affected files: mcpgateway/templates/admin.html,
mcpgateway/templates/toolops_partial.html
All panels now have consistent loading behavior:
- Single loading indicator per panel
- No spurious spinners on background requests
- Proper HTMX indicator visibility control via CSS
Fixes #2689
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
26bfebb to
791359c
Compare
crivetimihai
approved these changes
Feb 6, 2026
10 tasks
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
This commit addresses multiple loading spinner issues in the admin UI:
1. Fixed double loading spinners on initial page load/refresh
- Removed redundant initial placeholder spinners from Gateways, Catalog,
Tools, and Tool Operations panels
- Now relies solely on HTMX indicators for loading states
- Affected files: mcpgateway/templates/admin.html
2. Fixed spurious spinners triggered by background requests
- Added CSS rules to prevent all .htmx-indicator elements from showing
on unrelated requests
- Scoped indicators to specific panels
- Only show indicators when explicitly targeted via hx-indicator attribute
- Uses proper CSS specificity to ensure targeted indicators are shown
- Prevents spinners from appearing during background /trace requests
- Affected files: mcpgateway/static/admin.css
3. Standardized Resources panel loading indicator
- Replaced simple spinner div with proper HTMX indicator matching other panels
- Added animated SVG spinner with "Loading resources..." text
- Affected files: mcpgateway/templates/admin.html
4. Aligned Prompts panel implementation with other panels
- Removed dual loading state (inline + external indicator)
- Standardized to single external HTMX indicator for consistency
- Changed spinner color to indigo for consistency with other panels
- Affected files: mcpgateway/templates/admin.html
5. Fixed Tool Operations panel loading indicator
- Added indicator to admin.html (outside swap target) so it exists on
initial page load
- Removed duplicate indicator from toolops_partial.html to avoid ID conflict
- Affected files: mcpgateway/templates/admin.html,
mcpgateway/templates/toolops_partial.html
All panels now have consistent loading behavior:
- Single loading indicator per panel
- No spurious spinners on background requests
- Proper HTMX indicator visibility control via CSS
Fixes IBM#2689
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
📌 Summary
This PR addresses multiple loading spinner issues in the admin UI:
Before - Double spinner:
main.mov
After:
main-fix.mov
Before - Colateral spinner:
1-traces-spinner.mov
After:
1-traces-spinner-fix.mov
Before - Missing spinner:
2-no-spinner.mov
After:
2-no-spinner-fix.mov
Before - Different spinner:
3-different-spinners.mov
After:
3-different-spinners-fix.mov
Fixes #2689
🔁 Reproduction Steps
🐞 Root Cause
There was a redundant initial placeholder spinner on some of the panels. Some were missing the
hx-indicatorattribute.💡 Fix Description
Fixed double loading spinners on initial page load/refresh
Fixed spurious spinners triggered by background requests
Standardized Resources panel loading indicator
Aligned Prompts panel implementation with other panels
All panels now have consistent loading behavior:
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)