test failure on macOS 10.15

Error: 10 failed steps!
brew install --build-from-source berglas
brew install --build-from-source charm
brew install --build-from-source cig
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source ship
brew install --build-from-source tektoncd-cli
brew install --build-from-source the_platinum_searcher
brew install --build-from-source wellington
brew install --build-from-source wskdeploy

test failure on macOS 10.14

Error: 11 failed steps!
brew install --build-from-source berglas
brew install --build-from-source charm
brew install --build-from-source cig
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source grv
brew install --build-from-source ship
brew install --build-from-source tektoncd-cli
brew install --build-from-source the_platinum_searcher
brew install --build-from-source wellington
brew install --build-from-source wskdeploy

test failure on macOS 10.13

Error: 10 failed steps!
brew install --build-from-source berglas
brew install --build-from-source charm
brew install --build-from-source cig
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source ship
brew install --build-from-source tektoncd-cli
brew install --build-from-source the_platinum_searcher
brew install --build-from-source wellington
brew install --build-from-source wskdeploy

These 3

charm
dashing
wellington

are covered in #56539

new issues

do I still need to bump the revision in Formula/godep.rb ? The formula has been marked as deprecate! from #58115

@jnozsc, another thing I just realized is if you checked the previous PRs, we should have two separate commits:

• one for go, go 1.14.7
• one for dep, godep: revision bump for go

But we can totally do it after fixing the stuff that we can fix.

@chenrui333
thanks.

That's exactly what I am still confused. in previous PR #58115 , godep had been marked as deprecate! , do we still need to maintain it?

That's exactly what I am still confused. in previous PR #58115 , godep had been marked as deprecate! , do we still need to maintain it?

It's just deprecated. It isn't removed so people can and will still install it. And that install should be working correctly

ok, thanks for clarifying this

cancelled the build for now, and we can have a final run after fixing the stuff that we can fix. And then merging this patch upgrade.

rebase from master. let's check whether these issues get fixed or not

I am also inclined to do the merge and rebase to fix each formula (it is little bit costly to have golang runs)

the test on 10.15 takes too much time, let's focus on 10.14 and 10.13 first

tests fail on 10.14

Error: 6 failed steps!
brew install --build-from-source charm
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source grv
brew test --retry --verbose ssh-vault
brew install --build-from-source wellington

tests fails on 10.13

Error: 4 failed steps!
brew install --build-from-source charm
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source wellington

the revision bump on godep definitely fixes some issues

what we have now

Emm... Have these formula been fixed?

the test on 10.15 is too longer than it should be, should we restart it? cc @chenrui333

the test on 10.15 is too longer than it should be, should we restart it? cc @chenrui333

nope, unless there is something very wrong happening. We can also cross map how much time it should run before.

it took 13 hours on previous go PR. #58115

Two days over the previous release is indeed too long (1d 23h 18m 37s vs 13h 9m 26s), cancelled the build

update the table above by adding a installation analytics column.

Due to the number of installation, I would like to suggest to rebase from master again, leave buggy stuff with low installation on tracking with #56539, and merge this PR if no new issue gets introduced

trigger the test again by rebasing on master

trigger the test again by rebasing on master

I submit a ticket for grv rgburke/grv#107

go 1.15 is coming: #59486.
Probably we'll need to move 1.14 to versioned formulae, so we need this update as well.

I have acknowledged the 1.15 release, the test on 10.15 is almost done (if you check the github action log). Once it finishes, the PR should be ready to review

There should be no new issues introduced, except grv, which I have already submitted the upstream tickets.

For rest of these issues, they are being tracked in #56539 , basically most of them are pending on an upstream release

10.15

brew install --build-from-source charm
brew install --build-from-source prometheus
brew test --retry --verbose sync_gateway
brew test --retry --verbose termshark
brew install --build-from-source wellington

10.14

Error: 4 failed steps!
brew install --build-from-source charm
brew test --retry --verbose faas-cli
brew install --build-from-source grv
brew install --build-from-source wellington

10.13

Error: 2 failed steps!
brew install --build-from-source charm
brew install --build-from-source wellington

summary

I suggest a merge and handle the leftover in #56539

Sounds good with me. Going for the merge now.

Just 🚢 it.