go 1.15 by bayandin · Pull Request #59486 · Homebrew/homebrew-core

bayandin · 2020-08-11T22:03:38Z

Created with brew bump-formula-pr.

chenrui333 · 2020-08-12T00:03:33Z

just a note in here, we will need an alias for go@1.14

Moulick · 2020-08-12T08:28:01Z

First time looking at the checks for brew, forgive me if I am totally off, but the checks for this PR have been running for 10+ hours, is that expected ?

gromgit · 2020-08-12T08:37:20Z

the checks for this PR have been running for 10+ hours, is that expected ?

Yes. As a rule, a version bump for any formula triggers a rebuild and retest for all build dependents. For go, that's almost 500 other formulae.

Moulick · 2020-08-12T08:42:46Z

the checks for this PR have been running for 10+ hours, is that expected ?

Yes. As a rule, a version bump for any formula triggers a rebuild and retest for all build dependents. For go, that's almost 500 other formulae.

Ah, got it. Thanks for the explain @gromgit.

bayandin · 2020-08-12T09:28:34Z

just a note in here, we will need an alias for go@1.14

As usual, I would prefer to do it if it'll be not possible to upgrade all the formula to 1.15

Formula/go.rb

Moulick · 2020-08-12T10:04:54Z

Any way to see how many of the 500 have been successfully tested @gromgit ?

SMillerDev · 2020-08-12T10:29:17Z

Please also deprecate the appropriate old version.

bayandin · 2020-08-12T10:30:48Z

Any way to see how many of the 500 have been successfully tested @gromgit ?

Last time it took ~12h on 10.14 and >24h on 10.15

Moulick · 2020-08-12T10:48:56Z

wow, that's a big difference, like is 1.15 slow or like more formulae or some other reason entirely ?

bayandin · 2020-08-12T11:57:47Z

10.14 results:
(feel free to create upstream issues or submit patches)

There is a bunch a fails related to these change: https://golang.org/doc/go1.15#flag

When the flag package sees -h or -help, and those flags are not defined, it now prints a usage message. If the FlagSet was created with ExitOnError, FlagSet.Parse would then exit with a status of 2. In this release, the exit status for -h or -help has been changed to 0. In particular, this applies to the default handling of command line flags.

brew test --retry --verbose awsweeper
brew test --retry --verbose bettercap
brew test --retry --verbose geph2

Another bunch of fails looks similar and their error messages include panic: qtls.ConnectionState not compatible with tls.ConnectionState (it comes from different versions of https://github.com/lucas-clemente/quic-go/blob/v0.17.3/internal/handshake/unsafe.go#L26)

brew test --retry --verbose algernon
brew install --build-from-source caddy
brew test --retry --verbose ipfs
brew test --retry --verbose syncthing

And different ones:

brew install --build-from-source charm

==> go build github.com/juju/charmstore-client/cmd/charm
Last 150 lines from /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs/charm/03.go:
2020-08-12 00:36:27 +0100

go
build
github.com/juju/charmstore-client/cmd/charm

go: gopkg.in/juju/charmstore.v5@v5.6.4 requires
	github.com/CanonicalLtd/omniutils@v0.0.0-20180607151646-ed3ed7dca482: invalid version: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /private/tmp/charm-20200812-73191-1vunaz6/charmstore-client-2.4.0/pkg/mod/cache/vcs/05d357a6fb7db8f493808e9721a54716ec1be125069f304bb38b18b745c601ec: exit status 128:
	fatal: could not read Username for 'https://github.com': terminal prompts disabled

brew install --build-from-source grv

2020-08-12T03:49:52.9310710Z go build --tags static -ldflags "-X 'main.version=v0.3.2-0-g13658da' -X 'main.buildDateTime=2020-08-12 04:48:26 BST'" -o grv ./cmd/grv
2020-08-12T03:49:52.9310860Z # github.com/rgburke/grv/cmd/grv
2020-08-12T03:49:52.9310980Z /usr/local/Cellar/go/1.15/libexec/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
2020-08-12T03:49:52.9311110Z Undefined symbols for architecture x86_64:
2020-08-12T03:49:52.9311220Z   "_current_item", referenced from:
2020-08-12T03:49:52.9311340Z       __cgo_eed8f6ed3399_Cfunc_current_item in 000010.o
2020-08-12T03:49:52.9311480Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_current_item, __cgo_eed8f6ed3399_Cfunc_set_current_item )
2020-08-12T03:49:52.9311600Z   "_free_item", referenced from:
2020-08-12T03:49:52.9311720Z       __cgo_eed8f6ed3399_Cfunc_free_item in 000010.o
2020-08-12T03:49:52.9311850Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_free_item)
2020-08-12T03:49:52.9311960Z   "_free_menu", referenced from:
2020-08-12T03:49:52.9312070Z       __cgo_eed8f6ed3399_Cfunc_free_menu in 000010.o
2020-08-12T03:49:52.9312190Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_free_menu)
2020-08-12T03:49:52.9312310Z   "_item_count", referenced from:
2020-08-12T03:49:52.9312420Z       __cgo_eed8f6ed3399_Cfunc_item_count in 000010.o
2020-08-12T03:49:52.9312540Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_item_count)
2020-08-12T03:49:52.9312660Z   "_item_description", referenced from:
2020-08-12T03:49:52.9312770Z       __cgo_eed8f6ed3399_Cfunc_item_description in 000010.o
2020-08-12T03:49:52.9312880Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_item_description)
2020-08-12T03:49:52.9313000Z   "_item_index", referenced from:
2020-08-12T03:49:52.9313120Z       __cgo_eed8f6ed3399_Cfunc_item_index in 000010.o
2020-08-12T03:49:52.9313240Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_item_index)
2020-08-12T03:49:52.9313760Z   "_item_name", referenced from:
2020-08-12T03:49:52.9313910Z       __cgo_eed8f6ed3399_Cfunc_item_name in 000010.o
2020-08-12T03:49:52.9314040Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_item_name)
2020-08-12T03:49:52.9314170Z   "_item_opts_off", referenced from:
2020-08-12T03:49:52.9314280Z       __cgo_eed8f6ed3399_Cfunc_item_opts_off in 000010.o
2020-08-12T03:49:52.9314520Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_item_opts_off)
2020-08-12T03:49:52.9314630Z   "_item_opts_on", referenced from:
2020-08-12T03:49:52.9314760Z       __cgo_eed8f6ed3399_Cfunc_item_opts_on in 000010.o
2020-08-12T03:49:52.9314890Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_item_opts_on)
2020-08-12T03:49:52.9315020Z   "_item_value", referenced from:
2020-08-12T03:49:52.9315140Z       __cgo_eed8f6ed3399_Cfunc_item_value in 000010.o
2020-08-12T03:49:52.9315290Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_item_value, __cgo_eed8f6ed3399_Cfunc_item_value )
2020-08-12T03:49:52.9315430Z   "_item_visible", referenced from:
2020-08-12T03:49:52.9315560Z       __cgo_eed8f6ed3399_Cfunc_item_visible in 000010.o
2020-08-12T03:49:52.9315690Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_item_visible)
2020-08-12T03:49:52.9315810Z   "_menu_back", referenced from:
2020-08-12T03:49:52.9315930Z       __cgo_eed8f6ed3399_Cfunc_menu_back in 000010.o
2020-08-12T03:49:52.9316070Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_back, __cgo_eed8f6ed3399_Cfunc_menu_back )
2020-08-12T03:49:52.9316210Z   "_menu_driver", referenced from:
2020-08-12T03:49:52.9316330Z       __cgo_eed8f6ed3399_Cfunc_menu_driver in 000010.o
2020-08-12T03:49:52.9316610Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_menu_driver)
2020-08-12T03:49:52.9316720Z   "_menu_fore", referenced from:
2020-08-12T03:49:52.9316830Z       __cgo_eed8f6ed3399_Cfunc_menu_fore in 000010.o
2020-08-12T03:49:52.9317200Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_menu_fore, __cgo_eed8f6ed3399_Cfunc_set_menu_fore )
2020-08-12T03:49:52.9317530Z   "_menu_items", referenced from:
2020-08-12T03:49:52.9317880Z       __cgo_eed8f6ed3399_Cfunc_menu_items in 000010.o
2020-08-12T03:49:52.9318170Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_items, __cgo_eed8f6ed3399_Cfunc_menu_items )
2020-08-12T03:49:52.9318310Z   "_menu_opts_off", referenced from:
2020-08-12T03:49:52.9318430Z       __cgo_eed8f6ed3399_Cfunc_menu_opts_off in 000010.o
2020-08-12T03:49:52.9318560Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_menu_opts_off)
2020-08-12T03:49:52.9318850Z   "_menu_opts_on", referenced from:
2020-08-12T03:49:52.9318960Z       __cgo_eed8f6ed3399_Cfunc_menu_opts_on in 000010.o
2020-08-12T03:49:52.9319100Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_menu_opts_on)
2020-08-12T03:49:52.9319220Z   "_menu_pad", referenced from:
2020-08-12T03:49:52.9319340Z       __cgo_eed8f6ed3399_Cfunc_menu_pad in 000010.o
2020-08-12T03:49:52.9319490Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_pad, __cgo_eed8f6ed3399_Cfunc_menu_pad )
2020-08-12T03:49:52.9319630Z   "_menu_pattern", referenced from:
2020-08-12T03:49:52.9319760Z       __cgo_eed8f6ed3399_Cfunc_menu_pattern in 000010.o
2020-08-12T03:49:52.9319910Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_menu_pattern, __cgo_eed8f6ed3399_Cfunc_set_menu_pattern )
2020-08-12T03:49:52.9320050Z   "_menu_request_by_name", referenced from:
2020-08-12T03:49:52.9320170Z       __cgo_eed8f6ed3399_Cfunc_menu_request_by_name in 000010.o
2020-08-12T03:49:52.9320300Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_menu_request_by_name)
2020-08-12T03:49:52.9320590Z   "_menu_request_name", referenced from:
2020-08-12T03:49:52.9320720Z       __cgo_eed8f6ed3399_C2func_menu_request_name in 000010.o
2020-08-12T03:49:52.9320840Z       __cgo_eed8f6ed3399_Cfunc_menu_request_name in 000010.o
2020-08-12T03:49:52.9320990Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_menu_request_name, __cgo_eed8f6ed3399_C2func_menu_request_name )
2020-08-12T03:49:52.9321130Z   "_menu_spacing", referenced from:
2020-08-12T03:49:52.9321250Z       __cgo_eed8f6ed3399_Cfunc_menu_spacing in 000010.o
2020-08-12T03:49:52.9321390Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_menu_spacing, __cgo_eed8f6ed3399_Cfunc_set_menu_spacing )
2020-08-12T03:49:52.9321520Z   "_menu_win", referenced from:
2020-08-12T03:49:52.9321640Z       __cgo_eed8f6ed3399_Cfunc_menu_win in 000010.o
2020-08-12T03:49:52.9321770Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_win, __cgo_eed8f6ed3399_Cfunc_menu_win )
2020-08-12T03:49:52.9321900Z   "_new_item", referenced from:
2020-08-12T03:49:52.9322020Z       __cgo_eed8f6ed3399_C2func_new_item in 000010.o
2020-08-12T03:49:52.9322140Z       __cgo_eed8f6ed3399_Cfunc_new_item in 000010.o
2020-08-12T03:49:52.9322430Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_new_item, __cgo_eed8f6ed3399_C2func_new_item )
2020-08-12T03:49:52.9322560Z   "_new_menu", referenced from:
2020-08-12T03:49:52.9322670Z       __cgo_eed8f6ed3399_C2func_new_menu in 000010.o
2020-08-12T03:49:52.9322790Z       __cgo_eed8f6ed3399_Cfunc_new_menu in 000010.o
2020-08-12T03:49:52.9322920Z      (maybe you meant: __cgo_eed8f6ed3399_C2func_new_menu, __cgo_eed8f6ed3399_Cfunc_new_menu )
2020-08-12T03:49:52.9323060Z   "_pos_menu_cursor", referenced from:
2020-08-12T03:49:52.9323170Z       __cgo_eed8f6ed3399_Cfunc_pos_menu_cursor in 000010.o
2020-08-12T03:49:52.9323300Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_pos_menu_cursor)
2020-08-12T03:49:52.9323740Z   "_post_menu", referenced from:
2020-08-12T03:49:52.9323880Z       __cgo_eed8f6ed3399_Cfunc_post_menu in 000010.o
2020-08-12T03:49:52.9323990Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_post_menu)
2020-08-12T03:49:52.9324120Z   "_scale_menu", referenced from:
2020-08-12T03:49:52.9324250Z       __cgo_eed8f6ed3399_Cfunc_scale_menu in 000010.o
2020-08-12T03:49:52.9324380Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_scale_menu)
2020-08-12T03:49:52.9324500Z   "_set_current_item", referenced from:
2020-08-12T03:49:52.9324870Z       __cgo_eed8f6ed3399_Cfunc_set_current_item in 000010.o
2020-08-12T03:49:52.9325060Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_current_item)
2020-08-12T03:49:52.9325400Z   "_set_item_value", referenced from:
2020-08-12T03:49:52.9325520Z       __cgo_eed8f6ed3399_Cfunc_set_item_value in 000010.o
2020-08-12T03:49:52.9325660Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_item_value)
2020-08-12T03:49:52.9325780Z   "_set_menu_back", referenced from:
2020-08-12T03:49:52.9325910Z       __cgo_eed8f6ed3399_Cfunc_set_menu_back in 000010.o
2020-08-12T03:49:52.9326040Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_back)
2020-08-12T03:49:52.9326160Z   "_set_menu_fore", referenced from:
2020-08-12T03:49:52.9326290Z       __cgo_eed8f6ed3399_Cfunc_set_menu_fore in 000010.o
2020-08-12T03:49:52.9326570Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_fore)
2020-08-12T03:49:52.9326680Z   "_set_menu_format", referenced from:
2020-08-12T03:49:52.9326800Z       __cgo_eed8f6ed3399_Cfunc_set_menu_format in 000010.o
2020-08-12T03:49:52.9326930Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_format)
2020-08-12T03:49:52.9327200Z   "_set_menu_grey", referenced from:
2020-08-12T03:49:52.9327320Z       __cgo_eed8f6ed3399_Cfunc_set_menu_grey in 000010.o
2020-08-12T03:49:52.9327440Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_grey)
2020-08-12T03:49:52.9327560Z   "_set_menu_items", referenced from:
2020-08-12T03:49:52.9327680Z       __cgo_eed8f6ed3399_Cfunc_set_menu_items in 000010.o
2020-08-12T03:49:52.9327790Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_items)
2020-08-12T03:49:52.9327910Z   "_set_menu_mark", referenced from:
2020-08-12T03:49:52.9328030Z       __cgo_eed8f6ed3399_Cfunc_set_menu_mark in 000010.o
2020-08-12T03:49:52.9328150Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_mark)
2020-08-12T03:49:52.9328270Z   "_set_menu_pad", referenced from:
2020-08-12T03:49:52.9328380Z       __cgo_eed8f6ed3399_Cfunc_set_menu_pad in 000010.o
2020-08-12T03:49:52.9328510Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_pad)
2020-08-12T03:49:52.9328630Z   "_set_menu_pattern", referenced from:
2020-08-12T03:49:52.9328740Z       __cgo_eed8f6ed3399_Cfunc_set_menu_pattern in 000010.o
2020-08-12T03:49:52.9328870Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_pattern)
2020-08-12T03:49:52.9328990Z   "_set_menu_spacing", referenced from:
2020-08-12T03:49:52.9329110Z       __cgo_eed8f6ed3399_Cfunc_set_menu_spacing in 000010.o
2020-08-12T03:49:52.9329230Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_spacing)
2020-08-12T03:49:52.9329350Z   "_set_menu_sub", referenced from:
2020-08-12T03:49:52.9329460Z       __cgo_eed8f6ed3399_Cfunc_set_menu_sub in 000010.o
2020-08-12T03:49:52.9329590Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_sub)
2020-08-12T03:49:52.9329690Z   "_set_menu_win", referenced from:
2020-08-12T03:49:52.9329810Z       __cgo_eed8f6ed3399_Cfunc_set_menu_win in 000010.o
2020-08-12T03:49:52.9329930Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_set_menu_win)
2020-08-12T03:49:52.9330220Z   "_unpost_menu", referenced from:
2020-08-12T03:49:52.9330340Z       __cgo_eed8f6ed3399_Cfunc_unpost_menu in 000010.o
2020-08-12T03:49:52.9330460Z      (maybe you meant: __cgo_eed8f6ed3399_Cfunc_unpost_menu)
2020-08-12T03:49:52.9330580Z ld: symbol(s) not found for architecture x86_64
2020-08-12T03:49:52.9331360Z clang: error: linker command failed with exit code 1 (use -v to see invocation)
2020-08-12T03:49:52.9331450Z 
2020-08-12T03:49:52.9331880Z make: *** [build-only] Error 2

brew test --retry --verbose kyma-cli

==> /usr/local/Cellar/kyma-cli/1.14.0/bin/kyma --help
runtime: netpoll: break fd ready for -2
fatal error: runtime: netpoll: break fd ready for something unexpected

runtime stack:
runtime.throw(0x32b9bd8, 0x39)
	/usr/local/Cellar/go/1.15/libexec/src/runtime/panic.go:1116 +0x72
runtime.netpoll(0x12892d2b3, 0x6cc6735e58301)
	/usr/local/Cellar/go/1.15/libexec/src/runtime/netpoll_kqueue.go:147 +0x33e
runtime.findrunnable(0xc000072800, 0x0)
	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2434 +0x785
runtime.schedule()
	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2669 +0x2d7
runtime.park_m(0xc000001500)
	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2837 +0x9d
runtime.mcall(0x80000)
	/usr/local/Cellar/go/1.15/libexec/src/runtime/asm_amd64.s:318 +0x5b

goroutine 1 [runnable, locked to thread]:
golang.org/x/text/internal/language.init()
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/text@v0.3.2/internal/language/tables.go:1259 +0x29c

goroutine 34 [chan receive]:

k8s.io/klog.(*loggingT).flushDaemon(0x461f8a0)
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/k8s.io/klog@v1.0.0/klog.go:1010 +0x8b
created by k8s.io/klog.init.0
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/k8s.io/klog@v1.0.0/klog.go:411 +0xd8

goroutine 7 [select]:
go.opencensus.io/stats/view.(*worker).start(0xc0000b24b0)
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/go.opencensus.io@v0.22.0/stats/view/worker.go:154 +0x105
created by go.opencensus.io/stats/view.init.0
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/go.opencensus.io@v0.22.0/stats/view/worker.go:32 +0x57

brew install --build-from-source wellington

==> go build -ldflags -X github.com/wellington/wellington/version.Version=1.0.4 /usr/local/Cellar/wellington/1.0.4/bin/wt wt/main.go
Last 150 lines from /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs/wellington/01.go:
2020-08-12 12:06:12 +0100

go
build
-ldflags
-X github.com/wellington/wellington/version.Version=1.0.4
-o
/usr/local/Cellar/wellington/1.0.4/bin/wt
wt/main.go

# github.com/wellington/wellington/vendor/github.com/fsnotify/fsevents
vendor/github.com/fsnotify/fsevents/fsevents.go:38:31: constant 36893488147419103231 overflows uint64
vendor/github.com/fsnotify/fsevents/fsevents.go:236:37: cannot use nil as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFStringCreateWithCString
vendor/github.com/fsnotify/fsevents/fsevents.go:237:16: cannot use cPaths (type _Ctype_CFArrayRef) as type _Ctype_CFMutableArrayRef in assignment
vendor/github.com/fsnotify/fsevents/fsevents.go:240:33: constant 36893488147419103231 overflows _Ctype_ulonglong

brew install --build-from-source yaegi

==> brew install --build-from-source yaegi
==> FAILED
==> Downloading https://github.com/containous/yaegi/archive/v0.8.13.tar.gz
==> Downloading from https://codeload.github.com/containous/yaegi/tar.gz/v0.8.13
==> go build cmd/yaegi/yaegi.go
Last 150 lines from /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs/yaegi/01.go:
2020-08-12 12:14:29 +0100

go
build
-trimpath
-o
/usr/local/Cellar/yaegi/0.8.13/bin/yaegi
cmd/yaegi/yaegi.go

package command-line-arguments
	imports github.com/containous/yaegi/stdlib/syscall: build constraints exclude all Go files in /private/tmp/yaegi-20200812-17468-1okdmux/yaegi-0.8.13/stdlib/syscall
package command-line-arguments
	imports github.com/containous/yaegi/stdlib/unsafe: build constraints exclude all Go files in /private/tmp/yaegi-20200812-17468-1okdmux/yaegi-0.8.13/stdlib/unsafe

Addresses Homebrew#59486

gromgit · 2020-08-12T12:37:02Z

Another bunch of fails looks similar and their error messages include panic: qtls.ConnectionState not compatible with tls.ConnectionState

Fixing this seems to be roadblocked by upstream: quic-go/quic-go#2614

Addresse Homebrew#59486

gromgit · 2020-08-12T12:53:21Z

Old build issues:

charm: Build failure on macOS juju/charmstore-client#209
grv: can not build grv on Mojave rgburke/grv#107
wellington: Create a new release wellington/wellington#218

yaegi upstream just updated their stdlib mapping to go1.15, will have to wait for a new release: traefik/yaegi@1fe75f1

@bayandin, I think all the above covers your 10.14 list.

Addresses Homebrew#59486

Addresses #59486 Closes #59506. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

Addresse #59486 Closes #59507. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

bayandin · 2020-08-12T13:41:45Z

@bayandin, I think all the above covers your 10.14 list.

Looks great, thank you @gromgit!

Nothing extra has failed on High Sierra. Let's wait for Catalina results.
In the meantime, I'll prepare go@1.14 versioned formula for go-quic-related formulae

bayandin · 2020-08-12T14:27:14Z

There are no extra fails on Catalina as well, let's give it another try

Addresses #59486

bayandin · 2020-08-13T13:20:38Z

Here're fresh results (from 10.13 and 10.14):

brew install --build-from-source grv -- known issue can not build grv on Mojave rgburke/grv#107
brew install --build-from-source charm -- known issue Build failure on macOS juju/charmstore-client#209
brew install --build-from-source wellington -- known issue Create a new release wellington/wellington#218

brew test --retry --verbose bettercap -- will be fixed by #59505
brew install --build-from-source mmctl -- will fixed by #59561

~~And it looks like godep restore doesn't work as expected anymore (for all godep dependant formulae):~~ My bad, I've lost revision bump for godep during the rebase.

And this error still exists:

brew test --retry --verbose kyma-cli -- reported to upstream kyma-cli panics on macOS High Sierra / Mojave if built using go 1.15 kyma-project/cli#557

2020-08-13T00:48:11.8649640Z �[34m==>�[0m �[1m/usr/local/Cellar/kyma-cli/1.14.0/bin/kyma install --kubeconfig ./kubeconfig 2>&1�[0m
2020-08-13T00:48:11.8650190Z runtime: netpoll: break fd ready for -2
2020-08-13T00:48:11.8650340Z fatal error: runtime: netpoll: break fd ready for something unexpected
2020-08-13T00:48:11.8650420Z 
2020-08-13T00:48:11.8650540Z runtime stack:
2020-08-13T00:48:11.8650660Z runtime.throw(0x32b9bd8, 0x39)
2020-08-13T00:48:11.8650800Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/panic.go:1116 +0x72
2020-08-13T00:48:11.8650930Z runtime.netpoll(0x41c836, 0x7094753a67c01)
2020-08-13T00:48:11.8651060Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/netpoll_kqueue.go:147 +0x33e
2020-08-13T00:48:11.8651190Z runtime.findrunnable(0xc00006f800, 0x0)
2020-08-13T00:48:11.8651320Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2434 +0x785
2020-08-13T00:48:11.8651450Z runtime.schedule()
2020-08-13T00:48:11.8651570Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2669 +0x2d7
2020-08-13T00:48:11.8651700Z runtime.park_m(0xc000500180)
2020-08-13T00:48:11.8651830Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2837 +0x9d
2020-08-13T00:48:11.8651950Z runtime.mcall(0x80000)
2020-08-13T00:48:11.8652070Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/asm_amd64.s:318 +0x5b
2020-08-13T00:48:11.8652160Z 
2020-08-13T00:48:11.8652270Z goroutine 1 [runnable, locked to thread]:
2020-08-13T00:48:11.8652420Z strings.genSplit(0x3269c9f, 0x1f, 0x3227788, 0x1, 0x0, 0xffffffffffffffff, 0xc000358980, 0x55, 0xc0003585f0)
2020-08-13T00:48:11.8652550Z 	/usr/local/Cellar/go/1.15/libexec/src/strings/strings.go:236 +0x2c5
2020-08-13T00:48:11.8652680Z strings.Split(...)
2020-08-13T00:48:11.8652810Z 	/usr/local/Cellar/go/1.15/libexec/src/strings/strings.go:299
2020-08-13T00:48:11.8652940Z golang.org/x/text/internal/language/compact.init.0()
2020-08-13T00:48:11.8653090Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/text@v0.3.2/internal/language/compact/compact.go:56 +0x6f
2020-08-13T00:48:11.8653180Z 
2020-08-13T00:48:11.8653300Z goroutine 6 [chan receive]:
2020-08-13T00:48:11.8653420Z k8s.io/klog.(*loggingT).flushDaemon(0x461f8a0)
2020-08-13T00:48:11.8653800Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/k8s.io/klog@v1.0.0/klog.go:1010 +0x8b
2020-08-13T00:48:11.8653990Z created by k8s.io/klog.init.0
2020-08-13T00:48:11.8654170Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/k8s.io/klog@v1.0.0/klog.go:411 +0xd8
2020-08-13T00:48:11.8654280Z 
2020-08-13T00:48:11.8655070Z goroutine 9 [select]:
2020-08-13T00:48:11.8655260Z go.opencensus.io/stats/view.(*worker).start(0xc000110500)
2020-08-13T00:48:11.8655420Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/go.opencensus.io@v0.22.0/stats/view/worker.go:154 +0x105
2020-08-13T00:48:11.8655560Z created by go.opencensus.io/stats/view.init.0
2020-08-13T00:48:11.8655710Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/go.opencensus.io@v0.22.0/stats/view/worker.go:32 +0x57
2020-08-13T00:48:11.8656670Z �[32m==>�[0m �[1mTesting kyma-cli (again)�[0m
2020-08-13T00:48:11.8657420Z /usr/bin/sandbox-exec -f /private/tmp/homebrew20200813-21230-js630z.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/kyma-cli.rb --verbose --retry
2020-08-13T00:48:11.8658270Z �[34m==>�[0m �[1m/usr/local/Cellar/kyma-cli/1.14.0/bin/kyma install --kubeconfig ./kubeconfig 2>&1�[0m
2020-08-13T00:48:11.8658830Z runtime: netpoll: break fd ready for -2
2020-08-13T00:48:11.8658990Z fatal error: runtime: netpoll: break fd ready for something unexpected
2020-08-13T00:48:11.8659080Z 
2020-08-13T00:48:11.8659200Z runtime stack:
2020-08-13T00:48:11.8659300Z runtime.throw(0x32b9bd8, 0x39)
2020-08-13T00:48:11.8659430Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/panic.go:1116 +0x72
2020-08-13T00:48:11.8659560Z runtime.netpoll(0x268690, 0x70947c09a9001)
2020-08-13T00:48:11.8659700Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/netpoll_kqueue.go:147 +0x33e
2020-08-13T00:48:11.8659830Z runtime.findrunnable(0xc00006d000, 0x0)
2020-08-13T00:48:11.8659960Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2434 +0x785
2020-08-13T00:48:11.8660080Z runtime.schedule()
2020-08-13T00:48:11.8660210Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2669 +0x2d7
2020-08-13T00:48:11.8660320Z runtime.park_m(0xc000502000)
2020-08-13T00:48:11.8660450Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:2837 +0x9d
2020-08-13T00:48:11.8660580Z runtime.mcall(0x80000)
2020-08-13T00:48:11.8660870Z 	/usr/local/Cellar/go/1.15/libexec/src/runtime/asm_amd64.s:318 +0x5b
2020-08-13T00:48:11.8660950Z 
2020-08-13T00:48:11.8661050Z goroutine 1 [runnable, locked to thread]:
2020-08-13T00:48:11.8661180Z errors.New(0x32b3344, 0x37, 0x35a15a0, 0xc00036e730)
2020-08-13T00:48:11.8661300Z 	/usr/local/Cellar/go/1.15/libexec/src/errors/errors.go:58 +0x78
2020-08-13T00:48:11.8661430Z golang.org/x/text/internal/language.init()
2020-08-13T00:48:11.8661580Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/text@v0.3.2/internal/language/parse.go:39 +0x20f
2020-08-13T00:48:11.8661660Z 
2020-08-13T00:48:11.8661770Z goroutine 6 [chan receive]:
2020-08-13T00:48:11.8661890Z k8s.io/klog.(*loggingT).flushDaemon(0x461f8a0)
2020-08-13T00:48:11.8662110Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/k8s.io/klog@v1.0.0/klog.go:1010 +0x8b
2020-08-13T00:48:11.8662290Z created by k8s.io/klog.init.0
2020-08-13T00:48:11.8662460Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/k8s.io/klog@v1.0.0/klog.go:411 +0xd8
2020-08-13T00:48:11.8662580Z 
2020-08-13T00:48:11.8662690Z goroutine 9 [select]:
2020-08-13T00:48:11.8662820Z go.opencensus.io/stats/view.(*worker).start(0xc0001104b0)
2020-08-13T00:48:11.8663030Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/go.opencensus.io@v0.22.0/stats/view/worker.go:154 +0x105
2020-08-13T00:48:11.8663170Z created by go.opencensus.io/stats/view.init.0
2020-08-13T00:48:11.8663320Z 	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/go.opencensus.io@v0.22.0/stats/view/worker.go:32 +0x57
2020-08-13T00:48:11.8663910Z �[31mError:�[0m kyma-cli: failed
2020-08-13T00:48:11.8664050Z An exception occurred within a child process:
2020-08-13T00:48:11.8664550Z   Test::Unit::AssertionFailedError: <1> expected but was
2020-08-13T00:48:11.8664680Z <2>.

bayandin · 2020-08-15T06:55:58Z

Final failures:

brew install --build-from-source charm -- known issue Build failure on macOS juju/charmstore-client#209
brew install --build-from-source grv (on Mojave only) -- known issue can not build grv on Mojave rgburke/grv#107
brew install --build-from-source mmctl -- already fixed by mmctl: release retag #59561
brew install --build-from-source wellington -- known issue Create a new release wellington/wellington#218

Switched to go@1.14

algernon -- support Go 1.15 quic-go/quic-go#2614
caddy -- support Go 1.15 quic-go/quic-go#2614
ipfs -- support Go 1.15 quic-go/quic-go#2614
syncthing -- support Go 1.15 quic-go/quic-go#2614
kyma-cli -- kyma-cli panics on macOS High Sierra / Mojave if built using go 1.15 kyma-project/cli#557

I believe we're good to go 🎉

SMillerDev · 2020-08-15T07:29:26Z

Could you put that in the go upgrade failure tracking issue as well?

chenrui333 · 2020-08-15T18:42:19Z

Agree, let's track the upgrade failures in a separate issue.

Moving forward with a merge now! :)

chenrui333 · 2020-08-15T20:03:46Z

go 1.15 was shipped. thanks @bayandin for the efforts!!

bayandin added the go Go use is a significant feature of the PR or issue label Aug 11, 2020

cblecker mentioned this pull request Aug 11, 2020

go 1.15 #59487

Closed

5 tasks

bayandin mentioned this pull request Aug 11, 2020

go 1.14.7 #59242

Closed

bayandin commented Aug 12, 2020

View reviewed changes

Formula/go.rb Outdated Show resolved Hide resolved

gromgit mentioned this pull request Aug 12, 2020

awsweeper: remove unnecessary help test #59504

Closed

5 tasks

gromgit mentioned this pull request Aug 12, 2020

bettercap: fix test #59505

Merged

5 tasks

gromgit added a commit to gromgit/homebrew-core that referenced this pull request Aug 12, 2020

geph2: fix test + license

ce62d08

Addresses Homebrew#59486

gromgit mentioned this pull request Aug 12, 2020

geph2: fix test + license #59506

Closed

5 tasks

gromgit added a commit to gromgit/homebrew-core that referenced this pull request Aug 12, 2020

kyma-cli: remove unnecessary help/version tests

00e3a21

Addresse Homebrew#59486

gromgit mentioned this pull request Aug 12, 2020

kyma-cli: remove unnecessary help/version tests #59507

Closed

5 tasks

gromgit added a commit to gromgit/homebrew-core that referenced this pull request Aug 12, 2020

bettercap: fix test

c34bafc

Addresses Homebrew#59486

BrewTestBot pushed a commit that referenced this pull request Aug 12, 2020

geph2: fix test + license

5547193

Addresses #59486 Closes #59506. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

bayandin mentioned this pull request Aug 12, 2020

rubocop/urls: add go@1.14 to binary URLs allowlist Homebrew/brew#8320

Merged

6 tasks

chris-crone mentioned this pull request Aug 12, 2020

Bump Go to 1.15 docker-archive/compose-cli#464

Merged

bayandin pushed a commit that referenced this pull request Aug 13, 2020

bettercap: fix test (#59505)

062c447

Addresses #59486

bayandin added 9 commits August 14, 2020 11:08

go 1.15

ef34470

godep: revision bump for go

7ba4267

go@1.14 1.14.7 (new formula)

bb3d825

algernon: use go@1.14

4cbd96d

caddy: use go@1.14

e16d336

ipfs: use go@1.14

61bcdd9

kyma-cli: use go@1.14

2d931d1

syncthing: use go@1.14

37309a4

go@1.13 mark EOL

7630f5a

bayandin requested review from SMillerDev and chenrui333 August 15, 2020 06:57

SMillerDev approved these changes Aug 15, 2020

View reviewed changes

sethvargo mentioned this pull request Aug 15, 2020

Test and upgrade to Go 1.15 google/exposure-notifications-verification-server#220

Closed

chenrui333 approved these changes Aug 15, 2020

View reviewed changes

chenrui333 mentioned this pull request Aug 15, 2020

go 1.15 upgrade failure tracker #59698

Closed

chenrui333 closed this in 74a11f9 Aug 15, 2020

bayandin deleted the bump-go-1.15 branch August 16, 2020 11:35

arbourd mentioned this pull request Dec 17, 2020

go 1.15.6 #66355

Closed

Uh oh!

Conversation

bayandin commented Aug 11, 2020

Uh oh!

chenrui333 commented Aug 12, 2020

Uh oh!

Moulick commented Aug 12, 2020

Uh oh!

gromgit commented Aug 12, 2020

Uh oh!

Moulick commented Aug 12, 2020

Uh oh!

bayandin commented Aug 12, 2020

Uh oh!

Uh oh!

Moulick commented Aug 12, 2020

Uh oh!

SMillerDev commented Aug 12, 2020

Uh oh!

bayandin commented Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Moulick commented Aug 12, 2020

Uh oh!

bayandin commented Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gromgit commented Aug 12, 2020

Uh oh!

gromgit commented Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bayandin commented Aug 12, 2020

Uh oh!

bayandin commented Aug 12, 2020

Uh oh!

bayandin commented Aug 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bayandin commented Aug 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SMillerDev commented Aug 15, 2020

Uh oh!

chenrui333 commented Aug 15, 2020

Uh oh!

chenrui333 commented Aug 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bayandin commented Aug 12, 2020 •

edited

Loading

bayandin commented Aug 12, 2020 •

edited

Loading

gromgit commented Aug 12, 2020 •

edited

Loading

bayandin commented Aug 13, 2020 •

edited

Loading

bayandin commented Aug 15, 2020 •

edited

Loading