Skip to content

ship: 0.54.1#59302

Closed
jnozsc wants to merge 1 commit intoHomebrew:masterfrom
jnozsc:ship_fix_upstream_deps
Closed

ship: 0.54.1#59302
jnozsc wants to merge 1 commit intoHomebrew:masterfrom
jnozsc:ship_fix_upstream_deps

Conversation

@jnozsc
Copy link
Contributor

@jnozsc jnozsc commented Aug 7, 2020 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

found from #59242
fixed from upstream by replicatedhq/ship#1126

@jnozsc jnozsc mentioned this pull request Aug 7, 2020
Closed
@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue labels Aug 7, 2020
chenrui333
chenrui333 previously approved these changes Aug 8, 2020
View reviewed changes
@chenrui333 chenrui333 dismissed their stale review August 8, 2020 00:00

revision bump needed

chenrui333
chenrui333 reviewed Aug 8, 2020
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need revision 1 after license field.

@jnozsc jnozsc force-pushed the ship_fix_upstream_deps branch from 5bc622a to d8dfe46 Compare August 8, 2020 00:04
@jnozsc
Copy link
Contributor Author

jnozsc commented Aug 8, 2020

added

@laverya
Copy link
Contributor

laverya commented Aug 8, 2020

so I just released ship v0.54.1
which might be a better solution

@jnozsc
Copy link
Contributor Author

jnozsc commented Aug 8, 2020 •
edited
Loading

@laverya absolutely! I update this PR to v0.54.1. Thanks for this quick release

@jnozsc jnozsc force-pushed the ship_fix_upstream_deps branch from d8dfe46 to e5887eb Compare August 8, 2020 00:31
@jnozsc jnozsc force-pushed the ship_fix_upstream_deps branch from e5887eb to 733fd9d Compare August 8, 2020 00:33
@jnozsc jnozsc changed the title ship: fix dependency issue ship: 0.45.1 Aug 8, 2020
@jnozsc jnozsc changed the title ship: 0.45.1 ship: 0.54.1 Aug 8, 2020
@chenrui333
Copy link
Member

chenrui333 commented Aug 8, 2020

Thanks @laverya, @jnozsc!! ❤️

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Aug 8, 2020

🤖 A scheduled task has triggered a merge.

@jnozsc jnozsc deleted the ship_fix_upstream_deps branch August 8, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees

No one assigned

Labels

go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jnozsc @laverya @chenrui333 @BrewTestBot