Skip to content

go 1.14.6#58115

Closed
roopakv wants to merge 1 commit intoHomebrew:masterfrom
roopakv:roopak/go_1_14_5
Closed

go 1.14.6#58115
roopakv wants to merge 1 commit intoHomebrew:masterfrom
roopakv:roopak/go_1_14_5

Conversation

@roopakv
Copy link
Contributor

@roopakv roopakv commented Jul 17, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@roopakv
Copy link
Contributor Author

roopakv commented Jul 17, 2020

@Bo98 what is the best way to re-trigger the builds? seems like failed downloads were the error.

@SMillerDev
Copy link
Member

Done

@roopakv
Copy link
Contributor Author

roopakv commented Jul 19, 2020

seems like the failures are

  • auditbeat
  • berglas
  • charm
  • dashing
  • docker2aci
  • packetbeat
  • wellington
  • ship

@SMillerDev and @Bo98 do we need to go fix these packages first? what are the steps we follow now?

@SMillerDev
Copy link
Member

If these are broken by the update they need to be reported and fixed.

@roopakv
Copy link
Contributor Author

roopakv commented Jul 19, 2020

@SMillerDev afaik, they have been or are broken. wellington is an example that has been broken since 10.13.

dashing has a https cert error (this is new, but is unrelated to go 1.14.6)

@Bo98
Copy link
Member

Bo98 commented Jul 20, 2020

Looks like the Catalina build didn't complete.

There's also a merge conflict anyway. Can you rebase on master?

@roopakv
Copy link
Contributor Author

roopakv commented Jul 20, 2020

@Bo98 done. before we triggered a restart Catalina did finish and it was the same packages.

Merged master after fixing conflicts, hopefully we should have all builds complete with ~the same errors

@SMillerDev
Copy link
Member

Please don't introduce merge commits. We keep our log to one commit per formula. If you want the newest changes you'll have to rebase.

@roopakv
Copy link
Contributor Author

roopakv commented Jul 20, 2020

@SMillerDev updated.

curious: any reason why we don't use "squash and merge" so that even if a PR has multiple commits, history is linear? Im guessing because of the build pipeline, but want to double check

@Bo98
Copy link
Member

Bo98 commented Jul 20, 2020

Bottle commits like 8c9d754 wouldn't get applied if we used GitHub's merge button.

@roopakv
Copy link
Contributor Author

roopakv commented Jul 21, 2020

Failing formulae:

  • auditbeat
  • berglas
  • charm
  • dashing
  • gobuster
  • grv
  • heartbeat
  • packetbeat
  • ship
  • wellington

I'm going to see which of them are existing issues and see if we can send fixes to the repos. @Bo98, curious if you know where we are painting the list of broken golang reps, the issue seems to be closed?

@chenrui333
Copy link
Member

@roopakv previous upgrade failure tracker, #56539

@dawidd6 dawidd6 changed the title Golang 1.14.6 go 1.14.6 Jul 26, 2020
@AnyCPU
Copy link

AnyCPU commented Jul 28, 2020

What should be done to make go 1.14.6 available for upgrade?
What should be done to decrease time needed to prepare a new release?

@SMillerDev
Copy link
Member

Fix the build issues to get this migrated faster, and make sure that projects dependent on go have proper CI that'll catch these issues.

@Bo98
Copy link
Member

Bo98 commented Jul 29, 2020

Hi, sorry for the delay in responding here - I've been less active this week.

@Bo98, curious if you know where we are painting the list of broken golang reps, the issue seems to be closed?

I believe #56539 is being used now.

I'll make this a priority to review tomorrow evening. I think it would be worthwhile rebasing in the meantime until then so I'm not reviewing unrelated breakages which have already been fixed.

@roopakv
Copy link
Contributor Author

roopakv commented Jul 30, 2020

@Bo98 seems like godep is archived: https://github.com/tools/godep

do we remove godep in a separate PR? brew says there is a problem since repo is archived.

@SMillerDev
Copy link
Member

You can mark it deprecated with a date in this one.

@roopakv
Copy link
Contributor Author

roopakv commented Jul 30, 2020

@SMillerDev is that as simple as adding

deprecate! date: "2020-07-28"

to the formula?

when i try running brew audit Formula/godep.rb i never see the github error. i tried updating brew and running with debug, seems like that check is always skipped. what am i missing?

@SMillerDev
Copy link
Member

Yeah, although it should be the date that it was archived. brew audit --online will show this (since it needs to connect to github)

@roopakv
Copy link
Contributor Author

roopakv commented Jul 30, 2020

@SMillerDev yeah i tried with --online and still no dice. not sure what i am missing

image

@SMillerDev
Copy link
Member

Did you already mark it as deprecated? Because it will be skipped if you do. Otherwise you have something making brew audits ignore --online

@BrewTestBot BrewTestBot added the gopath deprecation Deprecate GOPATH in favor of Go Modules label Jul 30, 2020
@Bo98 Bo98 removed the gopath deprecation Deprecate GOPATH in favor of Go Modules label Jul 31, 2020
@Bo98
Copy link
Member

Bo98 commented Aug 1, 2020

Thanks. I've gone through all that failed and have matched them up with existing issues or PRs, bar a couple which I'll open a separate PR to fix shortly.

Typically we do one commit per formula:

  • go 1.14.6
  • godep: revision bump for go

I've done that for you while merging.

@Bo98
Copy link
Member

Bo98 commented Aug 1, 2020

Merged as 33b25d5 and cf7ad55.

@Bo98 Bo98 closed this Aug 1, 2020
@roopakv
Copy link
Contributor Author

roopakv commented Aug 1, 2020

thanks @Bo98 I'll keep that in mind for the future. I just copied what we did for 1.14.5

@roopakv roopakv deleted the roopak/go_1_14_5 branch August 1, 2020 04:33
@roopakv roopakv deleted the roopak/go_1_14_5 branch August 1, 2020 04:33
@jnozsc jnozsc mentioned this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants