go 1.14.6#58115
Conversation
|
@Bo98 what is the best way to re-trigger the builds? seems like failed downloads were the error. |
|
Done |
|
seems like the failures are
@SMillerDev and @Bo98 do we need to go fix these packages first? what are the steps we follow now? |
|
If these are broken by the update they need to be reported and fixed. |
|
@SMillerDev afaik, they have been or are broken. wellington is an example that has been broken since 10.13. dashing has a https cert error (this is new, but is unrelated to go 1.14.6) |
|
Looks like the Catalina build didn't complete. There's also a merge conflict anyway. Can you rebase on master? |
|
@Bo98 done. before we triggered a restart Catalina did finish and it was the same packages. Merged master after fixing conflicts, hopefully we should have all builds complete with ~the same errors |
|
Please don't introduce merge commits. We keep our log to one commit per formula. If you want the newest changes you'll have to rebase. |
|
@SMillerDev updated. curious: any reason why we don't use "squash and merge" so that even if a PR has multiple commits, history is linear? Im guessing because of the build pipeline, but want to double check |
|
Bottle commits like 8c9d754 wouldn't get applied if we used GitHub's merge button. |
|
Failing formulae:
I'm going to see which of them are existing issues and see if we can send fixes to the repos. @Bo98, curious if you know where we are painting the list of broken golang reps, the issue seems to be closed? |
|
What should be done to make go 1.14.6 available for upgrade? |
|
Fix the build issues to get this migrated faster, and make sure that projects dependent on |
|
Hi, sorry for the delay in responding here - I've been less active this week.
I believe #56539 is being used now. I'll make this a priority to review tomorrow evening. I think it would be worthwhile rebasing in the meantime until then so I'm not reviewing unrelated breakages which have already been fixed. |
|
@Bo98 seems like godep is archived: https://github.com/tools/godep do we remove godep in a separate PR? brew says there is a problem since repo is archived. |
|
You can mark it deprecated with a date in this one. |
|
@SMillerDev is that as simple as adding to the formula? when i try running |
|
Yeah, although it should be the date that it was archived. |
|
@SMillerDev yeah i tried with --online and still no dice. not sure what i am missing |
|
Did you already mark it as deprecated? Because it will be skipped if you do. Otherwise you have something making brew audits ignore |
|
Thanks. I've gone through all that failed and have matched them up with existing issues or PRs, bar a couple which I'll open a separate PR to fix shortly. Typically we do one commit per formula:
I've done that for you while merging. |
|
thanks @Bo98 I'll keep that in mind for the future. I just copied what we did for 1.14.5 |

brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?