One more suggestion: consider enabling GitHub Discussions for this repo (Settings → Features → Discussions).

DeepSeek-TUI has a large Chinese user base (most of the issues filed today are in Chinese), and Discussions is where that community naturally organizes — Q&A, show-and-tell, feature ideas that aren't quite ready to be issues. It also keeps issues cleaner by giving users a place to ask "how do I..." without opening a bug report.

Takes 10 seconds to enable and costs nothing. wangfengcsu@qq.com 🐋

Review notes from v0.8.12 integration

Reviewed the sandbox backend infrastructure as part of merging into v0.8.12. Two findings:

create_backend() is never called

The trait abstraction (SandboxBackend), the OpenSandboxBackend HTTP client, the create_backend() factory, and the sandbox_backend field on ToolContext all compile and look well-structured. But create_backend() is called from nowhere in the codebase — not in Engine::new, not in build_tool_context, not in main.rs. The field on ToolContext is always None, and the shell.rs integration path is unreachable.

This means the entire feature is dead code in its current form — users who configure sandbox_backend = "opensandbox" in config.toml will see no effect.

expect() panic risk

In OpenSandboxBackend::new():

let client = reqwest::Client::builder()
    .timeout(Duration::from_secs(timeout_secs))
    .build()
    .expect("reqwest::Client::builder should not fail with default settings");

While the default builder almost never fails, a stripped system without a TLS backend would panic the entire TUI process here — not just this feature, every running session. Should return a Result and propagate the error.

Recommendation

1. Fix the expect() to return Result — one-line change
2. Wire create_backend() into Engine::build_tool_context so the feature actually activates — about 4 lines in the engine

The infrastructure itself is clean. It just needs the last mile of wiring.

v0.8.12 fix applied

Two issues from the review have been resolved on the feat/v0.8.12 branch:

1. expect() panic — OpenSandboxBackend::new() now returns Result and the error propagates via create_backend(). If TLS init fails, the engine continues with local execution as fallback.

2. create_backend() never called — The engine now creates the sandbox backend in Engine::new() (from api_config) and wires it into ToolContext via build_tool_context(). exec_shell checks context.sandbox_backend and routes accordingly.

Commits:

• ca9fccc0d — replace expect() with Result
• b51fa6bc9 — wire create_backend() into the engine

Fixed — added sandbox_backend: Option<Arc<dyn SandboxBackend>> field to Engine, initialized via create_backend(api_config) in Engine::new, and wired into build_tool_context via with_sandbox_backend.

This PR was opened before the v0.8.41 rebrand and is now stale. Feel free to rebase onto current main and reopen. 鲸鱼兄弟们等你 🐋