Skip to content

fix(theme): complete Color::Reset migration across all UI widgets (#601)#651

Closed
merchloubna70-dot wants to merge 1 commit into
Hmbown:mainfrom
merchloubna70-dot:fix/color-theme-complete-601
Closed

fix(theme): complete Color::Reset migration across all UI widgets (#601)#651
merchloubna70-dot wants to merge 1 commit into
Hmbown:mainfrom
merchloubna70-dot:fix/color-theme-complete-601

Conversation

@merchloubna70-dot

Copy link
Copy Markdown

Follow-up to #600/#601, based on Gemini HIGH priority review.

The previous fix only changed one location. This PR replaces all hardcoded Color::Black backgrounds with Color::Reset across 10 UI files, making the TUI fully respect the user's terminal background color.

Files changed: sidebar, session_picker, model_picker, provider_picker, command_palette, pager, plan_prompt, user_input, deepseek_theme, ui.

Implemented using deepseek exec --model deepseek-v4-flash. 🐋

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@Hmbown

Hmbown commented May 5, 2026

Copy link
Copy Markdown
Owner

Triple-check finding: broken test

The production code was correctly changed to Color::Reset for section_bg, but the test at crates/tui/src/deepseek_theme.rs:150 still asserts the old value:

assert_eq!(theme.section_bg, palette::DEEPSEEK_INK);

This will fail with Color::Reset != Color::Rgb(18, 29, 39) at runtime. The assertion needs to be updated to match the new default. The Color::Reset migration itself is correct — it's just the test that's stale.

`section_bg` was changed from `palette::DEEPSEEK_INK` to `Color::Reset`
in the production code, but the test still asserted the old value,
causing a runtime failure. Update assertion to match.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@merchloubna70-dot

Copy link
Copy Markdown
Author

Fixed — updated the test assertion at crates/tui/src/deepseek_theme.rs:150 from palette::DEEPSEEK_INKColor::Reset to match the production code. Also added the ratatui::style::Color import to the test module.

kibuniverse pushed a commit to kibuniverse/DeepSeek-TUI that referenced this pull request May 5, 2026
kibuniverse pushed a commit to kibuniverse/DeepSeek-TUI that referenced this pull request May 5, 2026
…g docstring

Hmbown#651: fix test assertion — section_bg now Color::Reset (was DEEPSEEK_INK)
Hmbown#645: replace expect() with Result in OpenSandboxBackend::new()
Hmbown#653: correct resolve_prefixes docstring to describe deny-always-wins
MMMarcinho pushed a commit to MMMarcinho/DeepSeek-TUI that referenced this pull request May 6, 2026
MMMarcinho pushed a commit to MMMarcinho/DeepSeek-TUI that referenced this pull request May 6, 2026
…g docstring

Hmbown#651: fix test assertion — section_bg now Color::Reset (was DEEPSEEK_INK)
Hmbown#645: replace expect() with Result in OpenSandboxBackend::new()
Hmbown#653: correct resolve_prefixes docstring to describe deny-always-wins
@Hmbown Hmbown closed this May 6, 2026
@Hmbown Hmbown reopened this May 6, 2026
@Hmbown

Hmbown commented May 23, 2026

Copy link
Copy Markdown
Owner

This PR was opened before the v0.8.41 rebrand and is now stale. Feel free to rebase onto current main and reopen. 鲸鱼兄弟们等你 🐋

@Hmbown Hmbown closed this May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants