谁家PR机器人

Review notes from v0.8.12 integration

Reviewed the cache-aware resident file sub-agents as part of merging into v0.8.12. One finding:

Lease table has no cleanup

The global ownership table (HashMap<PathBuf, String> mapping file → agent_id) prevents two agents from holding a resident lease on the same file simultaneously. The lease is acquired on spawn:

if let Some(owner) = guard.get(file_path) {
    Some(format!("Warning: agent {owner} already holds a resident lease on {file_path}"))
} else {
    guard.insert(file_path.to_string(), agent_id.clone());
    None
}

But the lease is never released. Not on agent completion, not on crash, not on cancellation. The only way to clear a lease is to restart the TUI.

This means: spawn an agent on src/main.rs, it finishes its work, try to spawn another on the same file → you get a conflict warning even though the first agent is long gone. It's a soft failure (the spawn still succeeds, just with a warning in the result), but it defeats the purpose of resident mode for repeated work on the same file.

Recommendation

Hook into the agent lifecycle to release leases on terminal states (completed, failed, cancelled). The sub-agent manager's cleanup path is the right place — when an agent transitions to a terminal status, walk its leases and remove them.

@Hmbown Correct — the lease is never released, which makes resident mode unusable for repeated work on the same file. This is a real bug.

Fix: hook into the agent's terminal state transition to remove the lease. The right place is wherever the sub-agent manager marks an agent as completed/failed/cancelled.

I'll push the fix to the PR branch now. The approach:

1. Store the resident_file path alongside the agent in the manager
2. When transitioning to a terminal state (completed/failed/cancelled), acquire the lease table lock and remove the entry

wangfengcsu@qq.com

v0.8.12 fix applied

The lease cleanup leak has been fixed on feat/v0.8.12:

• Moved RESIDENT_LEASES from block-scoped static to module level so it's accessible from all lifecycle hooks
• Added release_resident_leases_for(agent_id) function
• Called at all three terminal transitions:
  • Cancelled — cancel_agent path
  • Failed — update_failed path
  • Completed — before returning SubAgentResult

Previously, leases were acquired on spawn but never released, causing false conflict warnings when respawning on the same file. Now the file is immediately available after an agent finishes.

Commit: 2ee826924

Remaining issue: The lease acquisition inserts "pending" as a placeholder instead of the real agent id. The conflict warning will show "agent pending already holds a lease" rather than the actual agent nickname. This should be a follow-up fix to update the lease with the real id after agent creation.

Fixed the remaining issue — after spawn_background_with_assignment_options returns the real agent_id, the lease entry is now updated from "pending" to the actual id. Conflict warnings will now show the correct agent nickname.

This PR was opened before the v0.8.41 rebrand and is now stale. Feel free to rebase onto current main and reopen. 鲸鱼兄弟们等你 🐋