add python version requirement to BUILDING.md#256
add python version requirement to BUILDING.md#256briaguya0 wants to merge 2 commits intoHarbourMasters:developfrom briaguya0:patch-1
Conversation
extract_assets uses match statements which were added in python version 3.10
|
I know the link is to the windows version of python 3.10, but people who already have and older version of python installed may skip past it not knowing they need a newer version |
|
#251 removes this requirement. putting this to python 3.6 would be good and have this PR sneak in behind it. |
|
Could we actually change this line to: Requires [Python](link) >= 3.6. Seems cleaner to me |
sounds good. to confirm: requires instead of install? |
|
I think so, as you said, some people already have it. There's not necessarily or right or wrong way to do this and requires makes more sense than install to me. I think it just makes sense grammatically. Perhaps someone else has a differing opinion? It's clean, gets to the point without extra words or brackets. |
#251 removes the 3.10 specific match statements, dropping the python version requirement to 3.6.
|
Hi briaguya-ai, I have a bit of an odd request. Could you please PR this to my fork at the below PR? This would help SoH for reviewing the current readme changes all-together and later merging the readme with the linux PR. Thanks! |
|
closing and using MegaMech#2 instead |
…ndo-menu-issue make sure to actually init the cvar
Co-authored-by: briaguya <briaguya@alice>
extract_assets uses match statements which were added in python version 3.10