extract_assets.py, allow drag & drop and downgrade match to elif. Do NOT merge#251
Closed
MegaMech wants to merge 2 commits intoHarbourMasters:developfrom
Closed
extract_assets.py, allow drag & drop and downgrade match to elif. Do NOT merge#251MegaMech wants to merge 2 commits intoHarbourMasters:developfrom
MegaMech wants to merge 2 commits intoHarbourMasters:developfrom
Conversation
Kenix3
approved these changes
May 11, 2022
Collaborator
|
Merge pending conflict resolution. |
Kenix3
pushed a commit
that referenced
this pull request
May 15, 2022
* add python version requirement to BUILDING.md extract_assets uses match statements which were added in python version 3.10 * update wording/version on python requirement #251 removes the 3.10 specific match statements, dropping the python version requirement to 3.6. * Update BUILDING.md * Update BUILDING.md * Update BUILDING.md * Update BUILDING.md * switch python link to download page * Fixed SHA-1 for retail ROM * Added discord link Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com> Co-authored-by: InfoManiac742 <ryanjgabel@gmail.com>
Collaborator
|
Feel free to reopen this PR when you have time to maintain it. |
aMannus
pushed a commit
to aMannus/Shipwright
that referenced
this pull request
Jul 2, 2022
…l-tomb Rando skip royal tomb
Malkierian
pushed a commit
to Malkierian/Shipwright
that referenced
this pull request
Nov 20, 2023
Resolves issue of assertions when the code was in StartFrame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the functionality of extract_assets.py.
The command argument now uses rom name (don't forget the extension):
./extract_assets.py <rom>it no longer uses<number>(selection based on num_roms in directory)This allows dragging and dropping a rom straight into the python file
The match/switch statement has been downgraded to elif for those using python3 from the wood era.
Note: In Windows drag & drop submits the entire path:
C:/Users/%USERNAME%/etc/OTRExporter/rom_name.z64rather than just the file name and extension.I recommend testing this change in Linux to make sure it's functional. Otherwise I'll add more logic to parse out the directory.