add python version requirement to BUILDING.md#2
Merged
MegaMech merged 3 commits intoMegaMech:patch-7from May 8, 2022
briaguya0:patch-1
Merged
add python version requirement to BUILDING.md#2MegaMech merged 3 commits intoMegaMech:patch-7from briaguya0:patch-1
MegaMech merged 3 commits intoMegaMech:patch-7from
briaguya0:patch-1
Conversation
extract_assets uses match statements which were added in python version 3.10
HarbourMasters#251 removes the 3.10 specific match statements, dropping the python version requirement to 3.6.
Author
|
i'd like to change the link to not be a specific windows python version, but instead https://www.python.org/downloads/ the visual studio link is a download page already (https://visualstudio.microsoft.com/vs/community/), so it seems like there's precedent it'll prevent us from needing to update the link when new python versions are released any opposition? edit: the latest python version on the download page is 3.10.4, the current link is 3.10.2 so it's already out of date |
Owner
|
Seems like a good idea to me. Yes, lets do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of HarbourMasters#256