Skip to content

[Do not Merge] An experimental branch with multiple mods and WIP PRs#1853

Closed
lilacLunatic wants to merge 963 commits intoHarbourMasters:developfrom
lilacLunatic:experimental
Closed

[Do not Merge] An experimental branch with multiple mods and WIP PRs#1853
lilacLunatic wants to merge 963 commits intoHarbourMasters:developfrom
lilacLunatic:experimental

Conversation

@lilacLunatic
Copy link
Contributor

@lilacLunatic lilacLunatic commented Oct 26, 2022

This PR isn't meant to ever be merged upstream, and its sole purpose is to provide jenkins builds for players who wish to playtest cutting edge, unstable and unsupported WIP features. Use this at your own risk.
It also advisable not to branch from this, as the git history will probably be clobbered frequently.

The following list contains the mods/third-party branches that are currently merged into this branch:

(Note: I haven't added the bombarang mod to this build as I don't intend to use the op boomerang in my runs. If I ever decide to flesh it out a bit more and put the feature behind a UI toggle, I might merge it in.)

And the following list contains the pull requests to Harbourmasters/Shipwright that are currently merged into this branch:

I'll try to keep those lists up to date but don't blindly believe them as I'll definitely forget something. If you catch anything I miss, please point it out in the comments. I accept suggestions on other branches to merge, which I will add or not purely at my discretion.

Reiterating: This is NOT supported, NOT official, nor properly tested. Expect to encounter potentially game breaking bugs. That being said, feel free to report any issues you encounter in the comments or on the corresponding Discord thread.

Build Artifacts

aMannus and others added 26 commits December 22, 2022 13:28
Some rooms in Master Quest had 10 silver rupees, but the game was programmed to only play the jingle 5 times and then just went silent for the rest. This option adds 5 more transposition values to the array, and an option to play them (so that authentic behavior is preserved by default).
Also adds it to the list to be reset back to 0 when applying the default preset.
@briaguya0 briaguya0 force-pushed the develop branch 2 times, most recently from 05bd4a3 to ba13e6b Compare January 17, 2023 05:34
@briaguya0
Copy link
Contributor

briaguya0 commented Jan 18, 2023

I'm closing this, we've had support for CI on forks for a while now. I know there's still a bit of setup required to handle the extract assets step, if you need help getting that working feel free to reach out.

@briaguya0 briaguya0 closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Not ready or not valid changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants