Rando: Entrance Tracker v1#2005
Merged
briaguya0 merged 17 commits intoHarbourMasters:developfrom Dec 7, 2022
Merged
Conversation
briaguya0
reviewed
Dec 5, 2022
Contributor
briaguya0
left a comment
There was a problem hiding this comment.
overall this is looking really good! looks like there's a ton of logic in here, and it's great to hear that testing has been going well.
i left quite a lot of comments in there, mostly questions and small suggestions for places where having comments explaining the logic would be helpful for readability.
i'm sure some of the changes i suggested could be considered out of scope, so don't feel obligated to address everything
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
briaguya0
reviewed
Dec 7, 2022
Contributor
briaguya0
left a comment
There was a problem hiding this comment.
This is super close to ready to go! Thanks for addressing the comments! Just a few renaming suggestions.
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
briaguya0
reviewed
Dec 7, 2022
soh/soh/Enhancements/randomizer/randomizer_entrance_tracker.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an entrance tracker for entrance rando.
Features include:
The tracker only displays shuffled entrances, and as such wont display anything for a non-entrance rando seed or vanilla saves.
The tracker settings are contained within a tree at the top of the tracker.
Discovered entrances are saved in the
SohStatsstruct using integer division and bit mapping into an array. This is for a reduced structure in the save json and to allow saving/checking an entrance was discovered without looping.I welcome any feedback, especially UI/UX 😃
(Most of the tracker information was taken from the 3ds rando entrance tracker)
Build Artifacts