Adds option to add higher pitches to silver rupee jingle#2246
Merged
briaguya0 merged 5 commits intoHarbourMasters:developfrom Jan 19, 2023
Merged
Adds option to add higher pitches to silver rupee jingle#2246briaguya0 merged 5 commits intoHarbourMasters:developfrom
briaguya0 merged 5 commits intoHarbourMasters:developfrom
Conversation
Some rooms in Master Quest had 10 silver rupees, but the game was programmed to only play the jingle 5 times and then just went silent for the rest. This option adds 5 more transposition values to the array, and an option to play them (so that authentic behavior is preserved by default).
Also adds it to the list to be reset back to 0 when applying the default preset.
dcvz
approved these changes
Dec 26, 2022
Contributor
dcvz
left a comment
There was a problem hiding this comment.
Changes look good, just some small comments on the fix name!
soh/soh/GameMenuBar.cpp
Outdated
| UIWidgets::Tooltip("Fixes camera getting stuck on collision when standing still, also fixes slight shift back in camera when stop moving"); | ||
| UIWidgets::PaddedEnhancementCheckbox("Fix Hanging Ledge Swing Rate", "gFixHangingLedgeSwingRate", true, false); | ||
| UIWidgets::Tooltip("Fixes camera swing rate when player falls of a ledge and camera swings around"); | ||
| UIWidgets::PaddedEnhancementCheckbox("Extend Silver Rupee Jingle", "gSilverRupeeJingleExtend", true, false); |
Contributor
There was a problem hiding this comment.
While extends silver rupee jingle is a good description of what you're doing, I think it's not necessarily descriptive of what the fix is.
How about "Fix jingle for extended silver rupee puzzles"? Or some variant of that?
Contributor
Author
There was a problem hiding this comment.
What about "Fix missing jingle after 5 Silver Rupees"?
05bd4a3 to
ba13e6b
Compare
Contributor
Author
|
Merged in latest develop, no conflicts. |
briaguya0
approved these changes
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some rooms in Master Quest had 10 silver rupees, but the game was programmed to only play the jingle 5 times and then just went silent for the rest. This option adds 5 more transposition values to the array, and an option to play them (so that authentic behavior is preserved by default).
Build Artifacts