Skip to content

Adds game specific camera options#1212

Merged
Kenix3 merged 14 commits intoHarbourMasters:develop-zhorafrom
GreatArgorath:Aim2
Aug 24, 2022
Merged

Adds game specific camera options#1212
Kenix3 merged 14 commits intoHarbourMasters:develop-zhorafrom
GreatArgorath:Aim2

Conversation

@GreatArgorath
Copy link
Member

@GreatArgorath GreatArgorath commented Aug 16, 2022

Resolves #36

Adds:

  • Inversion options for both Y axis and X axis
  • Ability to use right stick for various first person views
  • Ability to disable the auto-center for the C-Up first person view, to allow gyro to be used there
172197379-6258a546-6753-4b73-b81a-92800cc6541e.mp4

@GreatArgorath GreatArgorath requested a review from Kenix3 August 16, 2022 17:47
@briaguya0
Copy link
Contributor

sensitivity has moved out of LUS controller settings with #1220, gamecontroleditor.cpp seems like a good place for aiming and free cam sensitivity settings to live

@jbodner09
Copy link
Contributor

@briaguya-ai where did they end up? That PR seems to just remove them, not move them. Arguably, the entire right stick and gyro sections should move out of LUS controller settings and into this window. I'm adding tabs for all controllers to the GameControlEditor in #449 since I need them for my buttons, so they could move in there, as well as bringing back the removed sensitivity settings, but that seems out of scope for this PR.

@GreatArgorath for this PR, I think you should also have your checkboxes apply per-controller, which means they'd need to also live in my tabs, but obviously it's up to you.

@briaguya0
Copy link
Contributor

That PR seems to just remove them, not move them.

correct. sorry about that. my previous comment was misleading.

the idea is to switch away from what we have in rachael (screenshot from rachael bravo)
image

to

image

this way instead of handling right stick sensitivity settings as part of LUS, sensitivity settings can be handled as a part of the game (SOH).

also, this opens us up to having different sensitivity for aiming (even if we have aiming on the right stick enabled) and free camera

i'm not sure about the gryo sensitivity slider, maybe it makes sense for it to live here? i'll defer to @Kenix3 for opinions on that one.

@GreatArgorath GreatArgorath changed the title Adds camera inversion options + gyro to first person view Adds game specific camera options Aug 17, 2022
Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor note then I can merge this.

@Kenix3 Kenix3 merged commit d735616 into HarbourMasters:develop-zhora Aug 24, 2022
Kenix3 pushed a commit to Kenix3/Shipwright that referenced this pull request Oct 19, 2022
* Adds inversion options

* Fixes compilation

* Adds options to new detailed control editor

* Fixes inversion on C-Up view

* Fixes right stick aiming

* Fixes right stick aiming again

* Adds tooltip function + tooltips to gamecontroleditor.cpp

* Fixes tooltip for X axis

* Uses LUS tooltip function instead of new one

* Adds padding to camera control editor

To fit more in line with other enhancement checkboxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Controller axis inversion

5 participants