Skip to content

Run Playground Preview build against latest PR, not latest main#772

Merged
carstingaxion merged 5 commits intoGatherPress:mainfrom
carstingaxion:fix/playground-preview-checkout-ref
Aug 11, 2024
Merged

Run Playground Preview build against latest PR, not latest main#772
carstingaxion merged 5 commits intoGatherPress:mainfrom
carstingaxion:fix/playground-preview-checkout-ref

Conversation

@carstingaxion
Copy link
Copy Markdown
Collaborator

@carstingaxion carstingaxion commented Aug 11, 2024 •
edited
Loading

Fix ref, to checkout before build, to point to the latest PR commit, not the latest commit of the main branch.

Description of the Change

Closes # Testing & Clean-up after #666, #741, #749, #750, #753, #757 & #770

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Aug 11, 2024

PR Summary

  • Change in the Reference of The Checkout Step
    The reference point in the 'Checkout' phase of the 'playground-preview.yml' workflow has been modified. Instead of using the current GitHub reference, it will now use the unique identifier (SHA) of the latest commit from the pull request. This ensures the correct version of the code is being processed in this workflow.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 11, 2024

Preview changes with Playground

You can preview the least recent changes for PR#772 by following one of the links below:

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carstingaxion
Revert "DO NOT MERGE // TESTING GatherPress#772"
62b0ec9 
This reverts commit e92b21e.
@carstingaxion
Add more inline-docs about pull_request_target
aed4cf8
@carstingaxion
"To checkout the merged commit with actions/checkout on pull_request_…
7d85fca 
…target event, you need to get the pull request by GitHub API and set the merge commit hash to actions/checkout input ref."
@carstingaxion carstingaxion marked this pull request as ready for review August 11, 2024 11:27
@carstingaxion carstingaxion merged commit 55cf0ca into GatherPress:main Aug 11, 2024
carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Aug 11, 2024
@carstingaxion
DO NOT MERGE // TESTING GatherPress#772
70060c6
carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Aug 11, 2024
@carstingaxion
DO NOT MERGE // TESTING GatherPress#772
00640a0
carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Aug 11, 2024
@carstingaxion
DO NOT MERGE // TESTING GatherPress#772
e085f5b
carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Aug 11, 2024
@carstingaxion
DO NOT MERGE // TESTING GatherPress#772
f89b98c
@carstingaxion carstingaxion deleted the fix/playground-preview-checkout-ref branch August 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@carstingaxion