Skip to content

Fix/playground preview enhancements 2#757

Merged
carstingaxion merged 4 commits intoGatherPress:mainfrom
carstingaxion:fix/playground-preview-enhancements-2
Aug 2, 2024
Merged

Fix/playground preview enhancements 2#757
carstingaxion merged 4 commits intoGatherPress:mainfrom
carstingaxion:fix/playground-preview-enhancements-2

Conversation

@carstingaxion
Copy link
Copy Markdown
Collaborator

@carstingaxion carstingaxion commented Aug 2, 2024

Description of the Change

Closes # Testing & Clean-up after #666, #741, #749, #750 & #753

How to test the Change

1. Test that it NOT runs
   
   1. Open a PR
   2. ...with changes to `.github/...` or `.wordpress-org/...`
   3. See that the whole workflow is NOT triggered.

2. Test that it runs _1/2_
   
   1. Open a PR
   2. ... with changes to `src/...`
   3. See that the workflow is triggered & the `build` step runs succesfully.

3. Test that it runs _2/2_
   
   1. Open a PR
   2. ... with changes to `includes/...`
   3. See that the workflow is triggered & the `build` step runs succesfully.

4. Test that it updates the comment _1/2_
   
   1. In one of the opened PRs
   2. ... do some changes to `src/...`
   3. See that the `build` step runs succesfully & the comment is updated.

5. Test that it updates the comment _2/2_
   
   1. In one of the opened PRs
   2. ... do some changes to `includes/...`
   3. See that the `build` step is skipped & the comment is updated.

Changelog Entry

Fixed - Make sure the playground PR preview workflow runs when and only when needed

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Aug 2, 2024

PR Summary

  • Improvement in Artifact Checking Process
    We have added a step to verify if a zipped version of your software (called an "artifact") already exists. We then notify other parts of the system about its presence/absence via an environment variable, streamlining the process.

  • Refinement in Setting up Build Triggers
    We have made changes to the criteria for initiating the building process of your software. This process is now only triggered if there is no pre-existing zipped artifact or if there are any modifications detected in the primary directory that contains your source code (/src/).

  • Optimization in Job Dependencies
    The job titled Build GatherPress plugin & upload as zipped artifact, which compiles your software and then packages it as a zipped artifact for later use, is now more efficient. It will only be triggered based on the presence of modifications in the /src/ directory or the absence of any pre-existing zipped artifact.

  • Addition of Failsafe Mechanism in Job Execution
    We have introduced a failsafe mechanism to ensure the job titled Comment with playground link, which provides a usable testing environment link through a comment, executes irrespective of whether its preceding tasks were completed.

@carstingaxion
Copy link
Copy Markdown
Collaborator Author

Once again this is such of a type of PRs that can not be tested, without being merged, because of the nature of the pull_request_target.

#750 (comment)

@carstingaxion carstingaxion marked this pull request as ready for review August 2, 2024 22:45
@carstingaxion carstingaxion merged commit 1cee648 into GatherPress:main Aug 2, 2024
carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Aug 2, 2024
carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Aug 2, 2024
carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Aug 2, 2024
carstingaxion added a commit to carstingaxion/gatherpress that referenced this pull request Aug 2, 2024
@carstingaxion carstingaxion deleted the fix/playground-preview-enhancements-2 branch August 13, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant