✨😈☝️ pull request preview playground by carstingaxion · Pull Request #666 · GatherPress/gatherpress

carstingaxion · 2024-05-31T18:43:44Z

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New automated comments with links to preview the current PR in WordPress Playground.

Credits

Props @carstingaxion

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

carstingaxion · 2024-05-31T23:08:12Z

What and Why pull_request_target?

pull_request_target is one of the events triggering GitHub Actions workflows.
One of the differences between pull_request_target and pull_request is that pull_request_target triggers workflows based on the latest commit of the pull request's base branch.
Even if workflow files are modified or deleted on feature branches, workflows on the default branch aren't affected so you can prevent malicious code from being executed in CI without code review.

[...]

The GitHub Actions built in environment variables and Context of pull_request_target event are different from those of pull_request event.
For example, the following environment variables and context are different.

event_name, GITHUB_EVENT_NAME
ref, GITHUB_REF
sha, GITHUB_SHA
ref_name, GITHUB_REF_NAME

…ntegration"

…p#L61ff

carstingaxion · 2024-07-28T23:47:13Z

.gatherpress-org/playground-preview/plugin-proxy.php

Needs to be uploaded to gatherpress.org

└── playground-preview ├── .htaccess └── plugin-proxy.php

@MervinHernandez you'll need to work with Carstin on this to get on gatherpress.org

carstingaxion · 2024-07-28T23:47:32Z

.gatherpress-org/playground-preview/.htaccess

Needs to be uploaded to gatherpress.org

└── playground-preview ├── .htaccess └── plugin-proxy.php

carstingaxion · 2024-07-28T23:48:42Z

.gatherpress-org/playground-preview/plugin-proxy.php

+ */
+ini_set( 'display_errors', 0 );
+
+putenv( 'GITHUB_TOKEN=___REPLACE_WITH_REAL_GITHUB_TOKEN___' );


Replace ___REPLACE_WITH_REAL_GITHUB_TOKEN___ with a working PAT (to comment on PRs).

Only in PRODUCTION on gatherpress.org, NOT here in the repo!

.github/scripts/create-preview-links.js

carstingaxion · 2024-07-29T00:52:06Z

Preview-Comment after last commit	A new commit is added	The Preview-Comment is deleted & recreated after the last commit

As the screenshots show: The playground PR previewer is ready and working!

I combined the versions 1 & 2 of this idea and closed #668 as not needed anymore.

Actually this is not yet running on the GatherPress/gatherpress repository, because the workflow needs to be part of the repo itself BEFORE it will run & work. That's why the log of the workflow run says

Error: Unhandled error: HttpError: Resource not accessible by integration

To circumvent this behaviour during development I created carstingaxion#21, which is the working example and origin of the screenshots.

Now I need and would appreciate some help from @MervinHernandez and/or @mauteri :

NEW Action to prepare a .zip file with the current state of the plugin

dca4ba3

carstingaxion changed the title ~~Feature/pull request preview playground~~ ✨😈☝️ pull request preview playground May 31, 2024

This comment was marked as outdated.

Sign in to view

Fix nested zips

4ed15b3

This comment was marked as outdated.

Sign in to view

carstingaxion added 3 commits June 1, 2024 00:02

Exclude /src, /test & some files from being distributed

dbef3f4

NEW step: Comment with playground link

fc07a07

Re-Add file-extension

ffd52ca

This comment was marked as outdated.

Sign in to view

Add debug logging

a70b584

carstingaxion added 19 commits June 1, 2024 01:43

TRY TO FIX: "Unhandled error: HttpError: Resource not accessible by i…

29a6443

…ntegration"

Trigger workflow only for playground-relevant files

2fd282a

Add info on pull_request_target

9cfaff3

Run again

c141afd

Run again

64d1a71

Fix filename

f4780c8

Keep readme on ditribution

198eec7

TRY TO: comment on an PR

3ecf11b

TRY TO: comment on an PR

149ea61

TRY TO: Set GITHUB_TOKEN explicit, to comment on a PR

e00862c

Simplify job names

a0202f0

Create blueprint on thefly

0074760

Let steps depend on each other

d270e31

TEST blueprint creation with hard-coded values

fa33f32

Rename asset-name & Re-Run

b08176f

Unset fixed PR number

0782c88

Match workflow name (with what is compared against at plugin-proxy.ph…

249c810

…p#L61ff

TRY TO: Rename the workflow (because that is checked, not the job name

34b3da3

Change start folder

593d043

carstingaxion added 12 commits July 28, 2024 23:43

Create different playground preview links

bf4f1b8

Polishing the links as buttons

7ab25c9

TRY to fix md rendering

b3f7f90

TRY to fix md rendering

cb887f8

TRY to fix md rendering

e7cbb97

TRY to fix md rendering

9ecc600

Exclude plugin-proxy from CS checks

5042f3d

TRY to fix md rendering

006a53c

TRY to fix md rendering

51adbf7

Add PR number to link text (a11y)

0bcf173

TRY to fix md rendering

8ef56b8

Update doc-comments

c303b63

carstingaxion commented Jul 28, 2024

View reviewed changes

Remove additional files from BUILD

6b79b3d

carstingaxion marked this pull request as ready for review July 29, 2024 00:59

Merge branch 'main' into feature/pull-request-preview-playground

410c468

carstingaxion requested review from MervinHernandez and mauteri July 29, 2024 01:24

mauteri approved these changes Jul 29, 2024

View reviewed changes

mauteri merged commit 9cc0722 into GatherPress:main Jul 29, 2024

This was referenced Aug 10, 2024

Cleanup workflow from un-thought code #770

Merged

Run Playground Preview build against latest PR, not latest main #772

Merged

carstingaxion deleted the feature/pull-request-preview-playground branch August 13, 2024 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨😈☝️ pull request preview playground#666

✨😈☝️ pull request preview playground#666
mauteri merged 70 commits intoGatherPress:mainfrom
carstingaxion:feature/pull-request-preview-playground

carstingaxion commented May 31, 2024 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

carstingaxion commented May 31, 2024

Uh oh!

carstingaxion Jul 28, 2024

Uh oh!

mauteri Jul 29, 2024

Uh oh!

carstingaxion Jul 28, 2024

Uh oh!

carstingaxion Jul 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

carstingaxion commented Jul 29, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

carstingaxion commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the Change

How to test the Change

Changelog Entry

Credits

Checklist:

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

carstingaxion commented May 31, 2024

Uh oh!

carstingaxion Jul 28, 2024

Choose a reason for hiding this comment

Uh oh!

mauteri Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

carstingaxion Jul 28, 2024

Choose a reason for hiding this comment

Uh oh!

carstingaxion Jul 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carstingaxion commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

carstingaxion commented May 31, 2024 •

edited

Loading

carstingaxion Jul 28, 2024 •

edited

Loading

carstingaxion commented Jul 29, 2024 •

edited

Loading