Skip to content

sync beta#278

Merged
ca333 merged 43 commits intobetafrom
dev
Mar 2, 2020
Merged

sync beta#278
ca333 merged 43 commits intobetafrom
dev

Conversation

@ca333
Copy link
Copy Markdown

@ca333 ca333 commented Jan 28, 2020

0.5.3

ca333 and others added 30 commits January 14, 2020 14:49
[zmq] Call va_end() on va_start()ed args.
Alphabetized to make manually finding chains easier.
Because ease of use and utility seems better than pseudo-chronology.
move komodo_passport_iteration and komodo_cbopretupdate from
WaitForShutdown loop to separate thread ThreadUpdateKomodoInternals()
for KMD it should be 10, according to prev implementation in
WaitForShutdown, for assetchains it should be ASSETCHAINS_BLOCKTIME/5
should be +1 bcz it was loop for(i=0; i<=ASSETCHAINS_BLOCKTIME/5;i++)
in original loop.
we don't need iterate all nodes stats inside a miner to know
max of (nStartingHeight, nSyncHeight, nCommonHeight) to get
longestchain. it's wasting CPU resources. also we don't need
additional locks directly in miner.
If any vout of tx is belongs to wallet (IsMine(tx) == true) and tx is not from us, mean,
if every vin not belongs to our wallet (IsFromMe(tx) == false), then tx need to be checked
through wallet filter. If tx haven't any vin from trusted / whitelisted address it shouldn't
be added into wallet.

Using GetTransaction instead of myGetTransaction to get prevTx and
determine vins addresses. This will allow walletfilter code to work
without txindex=1 on any (!) nodes, not only notaries. If even one
-whitelistaddress arg set wallet filter is enabled and should allow
incoming txes from any addresses belongs to wallet (even watch-only)
and addresses listed in -whitelistaddress args. If -whitelistaddress
arg is not set wallet filter is disabled.
A rare race condition may trigger while awaiting the body of a message, see
upsteam commit libevent/libevent@5ff8eb2 for details.

This may fix some reported rpc hangs/crashes.

Issue: bitcoin/bitcoin#11593

Commits:
- bitcoin/bitcoin@6b58360
- bitcoin/bitcoin@97932cd
@ca333 ca333 marked this pull request as ready for review March 2, 2020 07:38
@ca333 ca333 merged commit 78e78f0 into beta Mar 2, 2020
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jul 29, 2024
Update deprecation height and version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants