Easier sort order#274
Conversation
Sync master
sync master
sync master
Alphabetized to make manually finding chains easier.
|
Looks good! I propose to do the same for src/assetchains.old script. Can add the commit if everybody agree. |
|
@tonymorony The contents of
|
|
Yes I see but in such case I don't clearly understand why this file is like a history while
|
My bad. I understood wrong about the And, |
|
Yeah, I just mean that if one is sorted logically second should be sorted as well. If we want to keep it in historial order - so maybe better to keep it for both.
I see - so if only one operator need it maybe he can sync this file on his own. Because now on new chain adding/removal we need to change two almost the same files |
|
dwy complained about it for days, so I made a PR to demonstrate how much faster it was than complaining. As far as I am aware, it is not in use by any internal scripts, and any half decent dev should be able to remap the json if required. |
|
fwiw, I alphabeticised the coins file last year while working with mm2, and it was rejected due to being too much of a hassle to review - again, remapping the json on the fly as required is not too difficult. |
no - alphabetical sequence makes sense. Just cuz a coin is listed at position N doesn't prove it was the Nth added coin.
exactly - we should always use git commit history for this tracking - which is more reliable |
|
#275 |
Alphabetized to make manually finding chains easier.