[zmq] Call va_end() on va_start()ed args.#10056
Merged
laanwj merged 1 commit intobitcoin:masterfrom Mar 27, 2017
Merged
Conversation
Contributor
|
ugh. see this is why we need to test on sparc. :P (On sparc forgetting to va_end will instantly corrupt the stack.) |
Member
|
utACK, haven't checked though whether this covers all cases. |
Contributor
Contributor
|
utACK 5ba61f0. |
Member
That reminds me, ideally we'd use typesafe c++11 variadic templates instead of C varags legacy mess. |
laanwj
added a commit
that referenced
this pull request
Mar 27, 2017
5ba61f0 [zmq] Call va_end() on va_start()ed args. (Karl-Johan Alm) Tree-SHA512: fbd3a0c29308ca9607f362f14fa7ea9c949a3f25dc09a349fe3b3ffd316b573c86778e29d3b9d55c684571eacae50aca90bb872e2e5489818d0af8310511fe79
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 21, 2019
5ba61f0 [zmq] Call va_end() on va_start()ed args. (Karl-Johan Alm) Tree-SHA512: fbd3a0c29308ca9607f362f14fa7ea9c949a3f25dc09a349fe3b3ffd316b573c86778e29d3b9d55c684571eacae50aca90bb872e2e5489818d0af8310511fe79
DeckerSU
added a commit
to DeckerSU/komodo
that referenced
this pull request
Jan 22, 2020
DeckerSU
added a commit
to DeckerSU/KomodoOcean
that referenced
this pull request
Jan 23, 2020
Fair-Exchange
pushed a commit
to Fair-Exchange/SafecoinClassic
that referenced
this pull request
May 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.