SimplePie logging of HTTP requests#815
Merged
Alkarex merged 6 commits intoFreshRSS:devfrom May 9, 2015
Merged
Conversation
This was referenced Mar 22, 2015
Closed
Can simplify the regex (faster because anchored) for cleaning URLs based on the fact that we only have to deal with HTTP or HTTPS
This reverts commit 1c38e64.
Can simplify the regex (faster because anchored) for cleaning URLs based on the fact that we only have to deal with HTTP or HTTPS FreshRSS#715
Member
Author
|
Any comment on this patch? I have to make some changes for #798, which will conflict with this patch if not committed before. |
Alkarex
added a commit
that referenced
this pull request
May 9, 2015
SimplePie logging of HTTP requests
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
May 9, 2015
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Apr 17, 2021
The HTTP Referer might appear in various logs and should not contain HTTP credentials `https://user:password@example.net/` New function `SimplePie_Misc::url_remove_credentials($url)` to strip credentials from a URL, before such a use. Piece of this downstream PR: FreshRSS/FreshRSS#815 (I use this function in several other circumpstances, which will be the topic of distinct PRs)
mblaney
pushed a commit
to simplepie/simplepie
that referenced
this pull request
Apr 23, 2021
The HTTP Referer might appear in various logs and should not contain HTTP credentials `https://user:password@example.net/` New function `SimplePie_Misc::url_remove_credentials($url)` to strip credentials from a URL, before such a use. Piece of this downstream PR: FreshRSS/FreshRSS#815 (I use this function in several other circumpstances, which will be the topic of distinct PRs)
Alkarex
added a commit
to Art4/FreshRSS
that referenced
this pull request
Jun 18, 2024
Alkarex
added a commit
that referenced
this pull request
Sep 14, 2024
* rename lib/SimplePie to lib/CustomSimplePie * add test for autoloading SimplePie with PSR-0 * install SimplePie 1.6.0 * Add SimplePie CHANGELOG.md, ignore irrelevant files * remove unmodified custom classes * rename all customized SimplePie classes * Add autoloading for SimplePie PSR-0 and CustomSimplePie classes * let CustomSimplePie extends SimplePie, remove unchanged code * let CustomSimplePieMisc extends SimplePie\Misc, remove unchanged code * Add tests for autoloading * let CustomSimplePieContentTypeSniffer extends Sniffer, remove unchanged code * remove unchanged CustomSimplePieEnclosure class The fixed typos are commited to SimplePie See simplepie/simplepie@133eac1 * let CustomSimplePieFile extends SimplePie\File, remove unchanged code * let CustomSimplePieParser extends SimplePie\Parser, remove unchanged code * let CustomSimplePieSanitize extends SimplePie\Sanitize, remove unchanged code * let CustomSimplePieHttpParser extends SimplePie\HTTP\Parser, remove unchanged code * Remove CustomSimplePie * Switch SimplePie repo to https://github.com/FreshRSS/simplepie.git * move to latest branch, update all SimplePie source files * Use namespaced SimplePie classes, remove SimplePie library folder * Update to latest SimplePie version with FreshRSS modifications * Bump SimplePie Tests expected to fail due to missing a backport of functionalities * Add fork-specific readme * Re-implement initial syslog SimplePie GET #815 Lacks #6061 * Closer backport of syslog SimplePie GET #6061 But the requests logs will be in the wrong order in case of redirections * Fixes * lib update * SimplePie include a few more files * Try with cache-hash branch * Point to newer commit * Point to newer commit * Finalise logs * Finalise * Bump SimplePie commit * Bump SimplePie commit * Readme SimplePie fork * Bump SimplePie commit * Better logging * Bump SimplePie commit * Reworked approach to work with SimplePie cache Simpler FreshRSS patches * Bump SimplePie commit FreshRSS/simplepie#22 * Simplepie846 FreshRSS/simplepie#23 And additional fixes * Remove log * Cherry pick relevant unmerged SimplePie PRs --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#711
New option (in FreshRSS and in SimplePie) to turn on/off the logging (via syslog) of HTTP requests done by SimplePie.
Passwords are removed from URLs before logging. The regular expression has been slightly updated since #715 (should be faster and safer), taking advantage of RFC 3986.