Allow SimplePie updates with composer by Art4 · Pull Request #4374 · FreshRSS/FreshRSS

Art4 · 2022-05-17T07:47:45Z

Refs #4329

Changes proposed in this pull request:

Restore original code of SimplePie to version 1.6.0
This allows easier updates of SimplePie (optionally with Composer).
Add tests for autoloading the SimplePie library
Move all customized code to new lib CustomSimplePie
classes in CustomSimplePie extends the namespaces SimplePie classes
Add tests for autoloading CustomSimplePie classes

Pull request checklist:

clear commit messages
code manually tested
unit tests written (optional if too hard)
documentation updated
Take use of CustomSimplePie in app code

Additional information can be found in the documentation.

What do you think about this PR?

And I have more questions:

I was not sure where to locate the customized code from SimplePie. Therefore I put it to lib/CustomSimplePie/. Is this ok or could you tell me where I should move this code?
Should I remove/change the header in the CustomSimplePie classes?

…ed code

The fixed typos are commited to SimplePie See simplepie/simplepie@133eac1

…code

…ged code

…nchanged code

Alkarex · 2022-05-17T08:17:21Z

Hello,
I am not sure to understand the extension idea? It looks like we end up with two copies of SimplePie? At a first glance, it does not look easier :-)

P.S. A good part of our local patches are fixes inside the SimplePie code and not only additional functions (for which I agree that extending classes is an elegant approach)

Art4 · 2022-05-17T09:38:06Z

Hello, I am not sure to understand the extension idea? It looks like we end up with two copies of SimplePie? At a first glance, it does not look easier :-)

P.S. A good part of our local patches are fixes inside the SimplePie code and not only additional functions (for which I agree that extending classes is an elegant approach)

The idea behind the extension is that the SimplePie code remains unchanged because major changes are due here in the future. At the same time, it should be possible to make bugfixes or changes as before (because merging in SimplePie unfortunately sometimes takes a bit longer).

CustomSimplePie contains only classes whose code is different from the original SimplePie. This way you don't have "two copies", but you can better see how CustomSimplePie differs from SimplePie. All of your local patches, that are not (yet) merged in SimplePie 1.6.0 are still in CustomSimplePie.

If changes in SimplePie have been merged, the SimplePie version can be updated and the changes in CustomSimplePie can be removed again.

I have to check and rework this further, so that everything works as before. And at the moment the app code does not use CustomSimplePie but Original SimplePie. This is on the todo list.

Art4 · 2022-05-25T07:16:49Z

To continue here I would need answers to my questions.
Or does anyone have a better suggestion on how to solve the problem described?

Alkarex · 2022-05-30T08:40:51Z

I still fail to understand the proposal, or if I understand it correctly, then I do not find it convenient.
Let's say one line of code needs to be changed in one file, then one would need to duplicate that file? But when that files gets updated upstream, we need to update two files? Twice the work? And lost ability to diff the whole code at once. It all sounds to be more complicated and error prone, and I fail to see any advantage

Art4 · 2022-06-01T07:21:43Z

I will try to explain it in another way. So far it looks like this:

Problem 1: You find a bug in SimplePie.
Solution: You create a PR in the SimplePie repository.

Problem 2: SimplePie takes a long time to merge, but you want to use the bugfix already in FreshRSS.
Solution: You have created a fork of SimplePie within FreshRSS where the bug is fixed. You then maintain changes in SimplePie back into the fork.

Problem 3: A feature is missing in SimplePie, e.g. SimplePie::cleanMd5().
Solution: The feature is only implemented in the fork. The fork is therefore always slightly different from the original.

Have I understood this correctly so far?

Then comes the next problem, which I am trying to solve:

Problem 4: SimplePie does a big refactoring. To merge that into the fork, all differences have to be found, the refactored code has to be merged into the fork and the changes have to be applied back into the fork.

In #4329 (comment) you stated:

Regarding SimplePie, I believe we will want to keep the ability to ship customised versions anyway, especially when waiting for upstream PRs to be merged, or when upstream PRs are not accepted

My suggested solution with this PR:

extract all changes of the fork into a custom library (here called CustomSimplePie for lack of creativity).
set the fork back to the original state
let CustomSimplePie build on the original SimplePie (first extend it, later possibly decorate it)
use in FreshRSS only CustomSimplePie.
Bonus: Future updates of SimplePie can be done with Composer, like CssXPath or PHPMailer.

If problem 1,2 or 3 occurs again in the future:

create the feature/bugfix in CustomSimplePie.
create a PR in SimplePie
a) If the PR was merged, update SimplePie in lib and remove the code from `CustomSimplePie
b) If the PR was not merged, leave the feature/bugfix in CustomSimplePie.

All these measures are a preparation for solving another problem that will come in the future.

Problem 5: Future versions of SimplePie (v2) might get dependencies to PSR interfaces and might require PSR implementations (e.g. cache or HTTP client).
Solution: PSR interfaces can be installed in lib folders, optionally also with Composer. Provide a PSR implementation based on the interfaces.

I would like to say again what my motivation is behind this PR. I am not (yet) a user of FreshRSS.

However, I have seen that you are a regular contributor to SimplePie. With the major changes being made (in part because of me) to SimplePie and more to come, I suspect that the way you contribute to SimplePie will become more difficult. Therefore, it feels to me like I'm making things more difficult for you by contributing to SimplePie. I don't like that.

In #4329 (comment) you stated:

Personally, I have a git clone of the libraries we use, and update them via a diff. In the case of SimplePie, which contains more changes, I cherry pick the latest commits.

I suspect that with the major changes in SimplePie, this will be more difficult, or it will require more work. Work that I would like to help with.

Whether this PR is accepted or not is fundamentally not important to me. I may also be wrong in my guess that maintaining your fork will be more difficult. Then maybe this PR can at least help you to find the differences between your fork and SimplePie.

Either way, I'm just trying to make sure my work is useful.

Update to answer your questions:

Let's say one line of code needs to be changed in one file, then one would need to duplicate that file?

Not necessarily. It might also be possible to place the desired feature/bugfix differently in CustomSimplePie than in the PR at SimplePie. But to have a comparability to the PR, this would probably be recommended.

But when that files gets updated upstream, we need to update two files? Twice the work?

You already have this double work, firstly by adding your bug fixes to your fork and secondly by adding the cherry-picking from upstream. After this PR you dont have the cherry-picking anymore, but you have to revert your own changes in CustomSimplePie.

And I would like to say that we only have this problem ("Problem 2") because SimplePie takes a lot of time with merging and releasing. If there were faster updates there, you wouldn't need to maintain a fork, you would just create PRs in SimplePie and then update your copy in lib. (And if a PR is not accepted, the change is applied to CustomSimplePie).

And lost ability to diff the whole code at once.

I may be wrong, but you're losing that ability right now too, because SimplePie's code has changed a lot.

Frenzie · 2022-06-01T08:09:22Z

I fundamentally don't understand how this approach is supposed to help with problem 4. If you copy entire classes and methods to make small changes in them, it seems to me that at best you've just kept the problem exactly the same, and frankly it looks an awful lot like double the work or worse.

I suspect that the way you contribute to SimplePie will become more difficult.

Is it possible that you're coming at this from the wrong angle? It's not necessary to apply these patches at the level of the "compiled" library, which seems to be the underlying assumption behind everything you wrote. Take that assumption away and I don't see how the rest would follow.

Alkarex · 2022-06-01T11:57:09Z

Problem 1: You find a bug in SimplePie. Solution: You create a PR in the SimplePie repository.

Almost: first fixed in the FreshRSS version of SimplePie and if it seems to work as intended, a PR is then proposed upstream.

Problem 2: SimplePie takes a long time to merge, but you want to use the bugfix already in FreshRSS. Solution: You have created a fork of SimplePie within FreshRSS where the bug is fixed. You then maintain changes in SimplePie back into the fork.

Problem 3: A feature is missing in SimplePie, e.g. SimplePie::cleanMd5(). Solution: The feature is only implemented in the fork. The fork is therefore always slightly different from the original.

Have I understood this correctly so far?

For now and at least the near future, problems 1-3 are near identical and result in a local SimplePie soft-"fork".

Problem 4: SimplePie does a big refactoring. To merge that into the fork, all differences have to be found, the refactored code has to be merged into the fork and the changes have to be applied back into the fork.

This upstream refactoring will surely introduce some lag (i.e. sticking with 1.6.x for some time), especially if that big refactoring has little intrinsic value, because the motivation to produce this work will be low.

Yes, the most likely approach will indeed be to re-apply manually, once, the local diffs/patches on top of the refactored version.
I have not assessed how much work that would be.

Meanwhile, if there is any desirable patch landing in SimplePie, it might be cherry-picked and back-ported to 1.6.x.

Note that I still hope to continue reducing the local differences by proposing (or re-proposing, as some had been refused) some changes upstream.

Problem 5: Future versions of SimplePie (v2) might get dependencies to PSR interfaces and might require PSR implementations (e.g. cache or HTTP client). Solution: PSR interfaces can be installed in lib folders, optionally also with Composer. Provide a PSR implementation based on the interfaces.

One problem at a time :-) I do not expect that to be a significant challenge.

I would like to say again what my motivation is behind this PR. I am not (yet) a user of FreshRSS.

However, I have seen that you are a regular contributor to SimplePie. With the major changes being made (in part because of me) to SimplePie and more to come, I suspect that the way you contribute to SimplePie will become more difficult. Therefore, it feels to me like I'm making things more difficult for you by contributing to SimplePie. I don't like that.

I very much appreciate your efforts, attempts, and explanations 👍🏻

I suspect that with the major changes in SimplePie, this will be more difficult, or it will require more work. Work that I would like to help with.

I think the most likely, as written above, is that it will introduce some lag, but not necessarily that it will remain more difficult down the line.

Whether this PR is accepted or not is fundamentally not important to me. I may also be wrong in my guess that maintaining your fork will be more difficult. Then maybe this PR can at least help you to find the differences between your fork and SimplePie.

Either way, I'm just trying to make sure my work is useful.

Thanks :-) Yes, I indeed do not believe that it will make upstream PR significantly more difficult once the (non-rewarding) work of merging the big refactoring has been done.

Alkarex · 2024-09-10T20:56:55Z

I have just added some better / finer logging.
Indeed, after the cache stuff, I am tracking down a double HTTP request being made to the server in case of redirection. So we get for instance: 302, 200, 200, instead of just 302, 200.
Edit: Seems to be a cache not working

Alkarex · 2024-09-11T13:01:46Z

I have fixed a cache-related case but I believe there is still a problem with the way SimplePie caches HTTP redirections, or more exactly does not seem to do so. But that might wait till another PR, as I do not think this is a new bug.

Alkarex · 2024-09-12T12:13:26Z

I need to clean a bit more the cache metadata

Simpler FreshRSS patches

To avoid destroying the cache at every minor update of the SimplePie file, which is an unnacceptable waste of resources FreshRSS/FreshRSS#4374

* Introduce a cache version To avoid destroying the cache at every minor update of the SimplePie file, which is an unnacceptable waste of resources FreshRSS/FreshRSS#4374 * Add FreshRSS comment

FreshRSS/simplepie#22

FreshRSS/simplepie#23 And additional fixes

Alkarex · 2024-09-14T21:11:03Z

Let's give it a spin 🚀

Alkarex · 2024-09-15T13:15:43Z

Follow-up to start adding some HTTP caching compliance FreshRSS/simplepie#26
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [freshrss](https://github.com/FreshRSS/FreshRSS) | minor | `1.24.3` -> `1.26.0` | --- ### Release Notes <details> <summary>FreshRSS/FreshRSS (freshrss)</summary> ### [`v1.26.0`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2025-02-23-FreshRSS-1260) [Compare Source](FreshRSS/FreshRSS@1.25.0...1.26.0) - Features - Add order-by options to sort articles by received date (existing, default), publication date, title, link, random [#7149](FreshRSS/FreshRSS#7149) - Allow searching in all feeds, also feeds only visible at category level with `&get=A`, and also those archived with `&get=Z` [#7144](FreshRSS/FreshRSS#7144) - UI accessible from user-query view - Add search operator `intext:` [#7228](FreshRSS/FreshRSS#7228) - New shortcuts for adding user labels to articles [#7274](FreshRSS/FreshRSS#7274) - New *About* page with system information [#7161](FreshRSS/FreshRSS#7161) - Bug fixing - Fix regression denying access to app manifest [#7158](FreshRSS/FreshRSS#7158) - Fix unwanted feed description updates [#7269](FreshRSS/FreshRSS#7269) - Ensure no PHP buffer for SQLite download (some setups would first put the file in memory) [#7230](FreshRSS/FreshRSS#7230) - Fix XML encoding regression in HTML+XPath mode [#7345](FreshRSS/FreshRSS#7345) - Improve cURL proxy options and fix some constants [#7231](FreshRSS/FreshRSS#7231) - Fix UI of global view unread articles counter [#7247](FreshRSS/FreshRSS#7247) - Hide base theme in carrousel [#7234](FreshRSS/FreshRSS#7234) - Deployment - Reduce superfluous Docker builds [#7137](FreshRSS/FreshRSS#7137) - Docker default image (Debian 12 Bookworm) updated to PHP 8.2.26 and Apache 2.4.62 - Docker alternative image (Alpine 3.21) updated to PHP 8.3.16 - UI - Add footer icons to reader view [#7133](FreshRSS/FreshRSS#7133) - Remove local reference to font *Open Sans* to avoid bugs with some local versions [#7215](FreshRSS/FreshRSS#7215) - Improve stats page layout [#7243](FreshRSS/FreshRSS#7243) - Smaller *mark as read* button in mobile view [#5220](FreshRSS/FreshRSS#5220) - Add CSS class to various types of notifications to allow custom styling [#7287](FreshRSS/FreshRSS#7287) - Various UI and style improvements: [#7162](FreshRSS/FreshRSS#7162), [#7268](FreshRSS/FreshRSS#7268) Security - Better authorization label for OIDC in the UI [#7264](FreshRSS/FreshRSS#7264) - Allow comments in `force-https.txt` [#7259](FreshRSS/FreshRSS#7259) - I18n: - Improve German [#7177](FreshRSS/FreshRSS#7177), [#7275](FreshRSS/FreshRSS#7275), [#7278](FreshRSS/FreshRSS#7278) - Improve Japanese [#7187](FreshRSS/FreshRSS#7187), [#7195](FreshRSS/FreshRSS#7195), [#7332](FreshRSS/FreshRSS#7332) - Misc. - Improve PHP code [#7191](FreshRSS/FreshRSS#7191), [#7204](FreshRSS/FreshRSS#7204) - Upgrade to PHPStan 2 [#7131](FreshRSS/FreshRSS#7131), [#7164](FreshRSS/FreshRSS#7164), [#7224](FreshRSS/FreshRSS#7224), [#7270](FreshRSS/FreshRSS#7270), [#7281](FreshRSS/FreshRSS#7281), [#7282](FreshRSS/FreshRSS#7282) - Update to CssXPath 1.3.0 (no change) [#7211](FreshRSS/FreshRSS#7211) - Update dev dependencies [#7165](FreshRSS/FreshRSS#7165), [#7166](FreshRSS/FreshRSS#7166), [#7167](FreshRSS/FreshRSS#7167), [#7279](FreshRSS/FreshRSS#7279), [#7280](FreshRSS/FreshRSS#7280), [#7283](FreshRSS/FreshRSS#7283), [#7284](FreshRSS/FreshRSS#7284), [#7285](FreshRSS/FreshRSS#7285), [#7347](FreshRSS/FreshRSS#7347) - Update GitHub Actions to Ubuntu 24.04 [#7207](FreshRSS/FreshRSS#7207) ### [`v1.25.0`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2024-12-23-FreshRSS-1250) [Compare Source](FreshRSS/FreshRSS@1.24.3...1.25.0) - Features - Add support for [regex search (regular expressions)](https://freshrss.github.io/FreshRSS/en/users/10\_filter.html#regex) [#6706](FreshRSS/FreshRSS#6706), [#6926](FreshRSS/FreshRSS#6926) - ⚠️ Advanced regex syntax for searches depends on the database used (SQLite, PostgreSQL, MariaDB, MySQL), but FreshRSS filter actions such as auto-mark-as-read and auto-favourite always use [PHP PCRE2 syntax](https://php.net/regexp.introduction). - Allow dynamic search operator in user queries, like `search:UserQueryA date:P1d` [#6851](FreshRSS/FreshRSS#6851) - New feed mode *HTML+XPath+JSON dot notation* (JSON in HTML) [#6888](FreshRSS/FreshRSS#6888) - Better HTTP compliance with support for HTTP response headers `Cache-Control: max-age` and `Expires` [#6812](FreshRSS/FreshRSS#6812), [FreshRSS/simplepie#26](FreshRSS/simplepie#26) - Support custom HTTP request headers per feed (e.g. for `Authorization`) [#6820](FreshRSS/FreshRSS#6820) - New unicity policies and heuristic for feeds with bad article IDs [#4487](FreshRSS/FreshRSS#4487), [#6900](FreshRSS/FreshRSS#6900) - Fallback to GUID if article link is empty [#7051](FreshRSS/FreshRSS#7051) - New option to automatically mark new articles as read if an identical title already exists in the same category [#6922](FreshRSS/FreshRSS#6922) - New reading view option to display unread articles + favourites [#7088](FreshRSS/FreshRSS#7088) - And corresponding new filter state `&state=96` (no UI button yet) - Add ability to remove content from articles with CSS selectors, also when not using full content [#6786](FreshRSS/FreshRSS#6786), [#6807](FreshRSS/FreshRSS#6807) - Update `phpgt/cssxpath` library with improved CSS selectors [#6618](FreshRSS/FreshRSS#6618) - Support for `:last-child`, `:first-of-type`, `:last-of-type`, `^=`, `|=` - New condition option to selectively retrieve full content of articles [#33fd07f6f26310d4806077cc87bcdf9b8b940e35](FreshRSS/FreshRSS@33fd07f), [#7082](FreshRSS/FreshRSS#7082) - Allow parentheses in quoted search [#7055](FreshRSS/FreshRSS#7055) - New UI feature to download a user’ SQLite database or a database SQLite export (to be produced by CLI) [#6931](FreshRSS/FreshRSS#6931) - New button to delete errored feeds from a category [#7030](FreshRSS/FreshRSS#7030) - Better import of Inoreader user labels [#6791](FreshRSS/FreshRSS#6791) - Rebuild feed favicon on cache clear [#6961](FreshRSS/FreshRSS#6961) - New sharing with Bluesky [#7116](FreshRSS/FreshRSS#7116) - New sharing with Telegram [#6838](FreshRSS/FreshRSS#6838) - Bug fixing - Fix searches with a parenthesis before an operator like `("a b")` or `(!c)` [#6818](FreshRSS/FreshRSS#6818) - Fix auto-read tags [#6790](FreshRSS/FreshRSS#6790) - Fix CSS selector for removing elements [#7037](FreshRSS/FreshRSS#7037), [#7073](FreshRSS/FreshRSS#7073), [#7081](FreshRSS/FreshRSS#7081), [#7091](FreshRSS/FreshRSS#7091), [#7083](FreshRSS/FreshRSS#7083) - Fix redirection error after creating a new user [#6995](FreshRSS/FreshRSS#6995) - Fix favicon error in case of wrong URL [#6899](FreshRSS/FreshRSS#6899) - Use cURL to fetch extensions list (allows e.g. IPv6) [#6767](FreshRSS/FreshRSS#6767) - Fix XML encoding in cURL options [#6821](FreshRSS/FreshRSS#6821) - Fix initial UI scroll for some browsers [#7059](FreshRSS/FreshRSS#7059) - Fix menu for article tags in some cases [#6990](FreshRSS/FreshRSS#6990) - Fix share menu shortcut [#6825](FreshRSS/FreshRSS#6825) - Fix HTML regex pattern during install for compatibility with `v` mode [#7009](FreshRSS/FreshRSS#7009) - More robust creation of user data folder [#7000](FreshRSS/FreshRSS#7000) - API - Fix API for categories and labels containing a `+` [#7033](FreshRSS/FreshRSS#7033) - Compatibility with FocusReader - Supported by [Capy Reader](https://github.com/jocmp/capyreader) (Android, open source) [capyreader#492](jocmp/capyreader#492) - Improved UI for API [#7048](FreshRSS/FreshRSS#7048) - Allow adding multiple feeds to a category via API [#7017](FreshRSS/FreshRSS#7017) - API support edit multiple tags [#7060](FreshRSS/FreshRSS#7060) - API return all categories also those without any feed [#7020](FreshRSS/FreshRSS#7020) - Compatibility - Require PHP 8.1+ (drop PHP 7.4) [#6711](FreshRSS/FreshRSS#6711) - Improved support of PHP 8.4+ [#6618](FreshRSS/FreshRSS#6618), [phpgt/CssXPath#227](phpgt/CssXPath#227), [#6781](FreshRSS/FreshRSS#6781), [#4374](FreshRSS/FreshRSS#4374) - Require PostgreSQL 10+ (drop PostgreSQL 9.5) [#6705](FreshRSS/FreshRSS#6705) - Require MariaDB 10.0.5+ (drop MariaDB 5.5) [#6706](FreshRSS/FreshRSS#6706) - Require MySQL 8+ (drop MySQL 5.5.3) [#6706](FreshRSS/FreshRSS#6706) - Deployment - Docker: dev image `freshrss/freshrss:oldest` updated to Alpine 3.16 with PHP 8.1.22 and Apache 2.4.59 [#6711](FreshRSS/FreshRSS#6711) - Docker alternative image updated to Alpine 3.21 with PHP 8.3.14 and Apache 2.4.62 [#5383](FreshRSS/FreshRSS#5383) - Update Dockerfiles to newer key-value format [#6819](FreshRSS/FreshRSS#6819) - Docker minor improvement of entrypoint [#6827](FreshRSS/FreshRSS#6827) - SimplePie - Refactor [our embedding](lib/README.md) of SimplePie [#4374](FreshRSS/FreshRSS#4374) - Our fork is maintained in its [own repository](https://github.com/FreshRSS/simplepie/tree/freshrss). - Remove HTTP `Referer` [#6822](FreshRSS/FreshRSS#6822), [FreshRSS/simplepie#27](FreshRSS/simplepie#27) - If some sites require it, add `Referer: https://example.net/` to the custom HTTP headers of the feed [#6820](FreshRSS/FreshRSS#6820) - Upstream fixes [simplepie#878](simplepie/simplepie#878), [simplepie#883](simplepie/simplepie#883) - Sync upstream [#6840](FreshRSS/FreshRSS#6840), [#7067](FreshRSS/FreshRSS#7067) - Security - Apache protect more non-public folders and files [#6881](FreshRSS/FreshRSS#6881), [#6893](FreshRSS/FreshRSS#6893), [#7008](FreshRSS/FreshRSS#7008) - Add privacy settings on extension list retrieval [#4603](FreshRSS/FreshRSS#4603), [#7132](FreshRSS/FreshRSS#7132) - Fix login in unsafe mode when using a password with special XML characters [#6797](FreshRSS/FreshRSS#6797) - Fix login in e.g. Brave browser by avoiding synchronous XHR [#7023](FreshRSS/FreshRSS#7023) - Fix invalid login message [#7066](FreshRSS/FreshRSS#7066) - Modernise `windows.open noopener` (to avoid flash of white page in dark mode) [#7077](FreshRSS/FreshRSS#7077), [#7089](FreshRSS/FreshRSS#7089) - UI - Searchable *My Labels* field [#6753](FreshRSS/FreshRSS#6753) - Add subscription management button to reading view [#6946](FreshRSS/FreshRSS#6946) - New option for showing label menu in article row [#6984](FreshRSS/FreshRSS#6984) - Move to next unread label on mark as read [#6886](FreshRSS/FreshRSS#6886) - Improved article footer for small / mobile screens [#7031](FreshRSS/FreshRSS#7031) - Improve Web accessibility: fix `aria-hidden` bug, and use HTML5 `hidden` [#6910](FreshRSS/FreshRSS#6910) - Default styles for `<pre>` and `<code>` [#6770](FreshRSS/FreshRSS#6770) - Refactor the sharing menu to use a `<template>` instead of duplicated HTML code [#6751](FreshRSS/FreshRSS#6751), [#7113](FreshRSS/FreshRSS#7113) - Refactor the label menu to use a `<template>` [#6864](FreshRSS/FreshRSS#6864) - Rework UI for authors [#7054](FreshRSS/FreshRSS#7054) - Avoid Unicode escape of authors in HTML UI [#7056](FreshRSS/FreshRSS#7056) - Improved subscription management page [#6816](FreshRSS/FreshRSS#6816) - Improve user query management page [#7062](FreshRSS/FreshRSS#7062) - Restore JavaScript form validation compatibility with Web browsers using older engines (SeaMonkey) [#6777](FreshRSS/FreshRSS#6777) - Reorganise some options [#6920](FreshRSS/FreshRSS#6920) - New shortcut `?` to show shortcut page and help [#6981](FreshRSS/FreshRSS#6981) - Use of consistent colours in statistics [#7090](FreshRSS/FreshRSS#7090) - Various UI and style improvements [#6959](FreshRSS/FreshRSS#6959) - Extensions - New extension hook `simplepie_after_init` [#7007](FreshRSS/FreshRSS#7007) - I18n - Add Finnish [#6954](FreshRSS/FreshRSS#6954) - Improve English [#7049](FreshRSS/FreshRSS#7049), [#7053](FreshRSS/FreshRSS#7053) - Improve German [#6847](FreshRSS/FreshRSS#6847), [#7068](FreshRSS/FreshRSS#7068), [#7128](FreshRSS/FreshRSS#7128) - Improve Italian [#6872](FreshRSS/FreshRSS#6872), [#7069](FreshRSS/FreshRSS#7069), [#7086](FreshRSS/FreshRSS#7086) - Improve Spanish [#6894](FreshRSS/FreshRSS#6894), [#6908](FreshRSS/FreshRSS#6908) - Improve Turkish [#6960](FreshRSS/FreshRSS#6960) - Misc. - Better cache name for JSON feeds [#6768](FreshRSS/FreshRSS#6768) - Fix inversed encoding logic in `Minz_Request::paramArray()` [#6800](FreshRSS/FreshRSS#6800) - Pass PHPStan `booleansInConditions` [#6793](FreshRSS/FreshRSS#6793) - Rename PHPStan configuration file to `phpstan.dist.neon` to allow custom configuration in `phpstan.neon` [#6892](FreshRSS/FreshRSS#6892) - Code improvements [#6800](FreshRSS/FreshRSS#6800), [#6809](FreshRSS/FreshRSS#6809), [#6983](FreshRSS/FreshRSS#6983) - Makefile improvements [#6913](FreshRSS/FreshRSS#6913) - Fix PHPCS `ControlSignature` [#6896](FreshRSS/FreshRSS#6896) - Update *PHPMailer* [#6968](FreshRSS/FreshRSS#6968), [#7046](FreshRSS/FreshRSS#7046) - Code updates to PHP 8.1 syntax [#6748](FreshRSS/FreshRSS#6748) - Update dev dependencies [#6780](FreshRSS/FreshRSS#6780), [#6964](FreshRSS/FreshRSS#6964), , [#6965](FreshRSS/FreshRSS#6965), [#6966](FreshRSS/FreshRSS#6966), [#6967](FreshRSS/FreshRSS#6967), [#6970](FreshRSS/FreshRSS#6970), [#7042](FreshRSS/FreshRSS#7042), [#7043](FreshRSS/FreshRSS#7043), [#7044](FreshRSS/FreshRSS#7044), [#7045](FreshRSS/FreshRSS#7045), [#7047](FreshRSS/FreshRSS#7047), [#7052](FreshRSS/FreshRSS#7052) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.sh4ke.rocks/lickler/freshrss/pulls/29 Co-authored-by: Michael Wittig <michael.wittig@posteo.de> Co-committed-by: Michael Wittig <michael.wittig@posteo.de>

Regression from FreshRSS#4374 fix: FreshRSS#7514 FreshRSS/simplepie#35 Upstream PR: simplepie/simplepie#914

Regression from #4374 fix: #7514 FreshRSS/simplepie#35 Upstream PR: simplepie/simplepie#914

Art4 added 17 commits May 16, 2022 09:44

rename lib/SimplePie to lib/CustomSimplePie

6efbf1b

add test for autoloading SimplePie with PSR-0

bf70aba

install SimplePie 1.6.0

627a395

Add SimplePie CHANGELOG.md, ignore irrelevant files

97fa8ac

remove unmodified custom classes

0578232

rename all customized SimplePie classes

e696394

Merge branch 'edge' into allow-simplepie-updates-with-composer

6e208a1

Add autoloading for SimplePie PSR-0 and CustomSimplePie classes

bff78b9

let CustomSimplePie extends SimplePie, remove unchanged code

ad32246

let CustomSimplePieMisc extends SimplePie\Misc, remove unchanged code

bd23a79

Add tests for autoloading

5d9f9d6

let CustomSimplePieContentTypeSniffer extends Sniffer, remove unchang…

4c75d0a

…ed code

remove unchanged CustomSimplePieEnclosure class

7568199

The fixed typos are commited to SimplePie See simplepie/simplepie@133eac1

let CustomSimplePieFile extends SimplePie\File, remove unchanged code

c1840a8

let CustomSimplePieParser extends SimplePie\Parser, remove unchanged …

a7e4517

…code

let CustomSimplePieSanitize extends SimplePie\Sanitize, remove unchan…

1f181f3

…ged code

let CustomSimplePieHttpParser extends SimplePie\HTTP\Parser, remove u…

7e380d1

…nchanged code

Alkarex added the SimplePie 🍰 label May 17, 2022

Art4 added 3 commits May 18, 2022 07:40

Merge branch 'edge' into allow-simplepie-updates-with-composer

57d5281

Merge branch 'edge' into allow-simplepie-updates-with-composer

64e2c58

Merge branch 'edge' into allow-simplepie-updates-with-composer

14a71fd

Merge branch 'edge' into allow-simplepie-updates-with-composer

ff9f23f

Merge branch 'edge' into allow-simplepie-updates-with-composer

ea71a6a

Alkarex mentioned this pull request Sep 11, 2024

Better update cache metadata FreshRSS/simplepie#20

Merged

Bump SimplePie commit

e912d12

Merge branch 'edge' into allow-simplepie-updates-with-composer

e120491

Alkarex added 2 commits September 12, 2024 14:13

Merge branch 'edge' into allow-simplepie-updates-with-composer

5fbf455

Merge branch 'edge' into allow-simplepie-updates-with-composer

e9e7d6e

Alkarex mentioned this pull request Sep 14, 2024

Get_hash FreshRSS/simplepie#21

Merged

Reworked approach to work with SimplePie cache

1708777

Simpler FreshRSS patches

Alkarex added a commit to FreshRSS/simplepie that referenced this pull request Sep 14, 2024

Introduce a cache version

9f8ab5a

To avoid destroying the cache at every minor update of the SimplePie file, which is an unnacceptable waste of resources FreshRSS/FreshRSS#4374

Alkarex mentioned this pull request Sep 14, 2024

Cache_version FreshRSS/simplepie#22

Merged

Alkarex added 4 commits September 14, 2024 15:17

Bump SimplePie commit

2c25cbc

FreshRSS/simplepie#22

Simplepie846

1a78f9a

FreshRSS/simplepie#23 And additional fixes

Remove log

1133d0b

Cherry pick relevant unmerged SimplePie PRs

4f0569c

Alkarex merged commit 882deab into FreshRSS:edge Sep 14, 2024

This was referenced Sep 14, 2024

Remove Referer header from SimplePie feed request #6523

Closed

Incorrect url for articles in feed #5324

Closed

Alkarex added the Important 🔥 label Sep 14, 2024

Alkarex mentioned this pull request Nov 6, 2024

[Bug] [edge] RSS <title> elements with Unicode not translated to human-readable. #6979

Closed

This was referenced Apr 17, 2025

[Feed problem] various RSS 0.91 feeds throwing XML_ERR_NAME_REQUIRED #7514

Closed

Fix support for feeds with XML preample + DTD simplepie/simplepie#914

Closed

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Apr 18, 2025

SimplePie: Fix support for feeds with XML preample + DTD

d886a26

Regression from FreshRSS#4374 fix: FreshRSS#7514 FreshRSS/simplepie#35 Upstream PR: simplepie/simplepie#914

Alkarex mentioned this pull request Apr 18, 2025

SimplePie: Fix support for feeds with XML preample + DTD #7515

Merged

Alkarex added a commit that referenced this pull request Apr 18, 2025

SimplePie: Fix support for feeds with XML preample + DTD (#7515)

d1f9b6c

Regression from #4374 fix: #7514 FreshRSS/simplepie#35 Upstream PR: simplepie/simplepie#914

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow SimplePie updates with composer#4374

Allow SimplePie updates with composer#4374
Alkarex merged 67 commits intoFreshRSS:edgefrom
Art4:allow-simplepie-updates-with-composer

Art4 commented May 17, 2022 •

edited

Loading

Uh oh!

Alkarex commented May 17, 2022 •

edited

Loading

Uh oh!

Art4 commented May 17, 2022

Uh oh!

Art4 commented May 25, 2022

Uh oh!

Alkarex commented May 30, 2022 •

edited

Loading

Uh oh!

Art4 commented Jun 1, 2022 •

edited

Loading

Uh oh!

Frenzie commented Jun 1, 2022 •

edited

Loading

Uh oh!

Alkarex commented Jun 1, 2022

Uh oh!

Alkarex commented Sep 10, 2024 •

edited

Loading

Uh oh!

Alkarex commented Sep 11, 2024

Uh oh!

Alkarex commented Sep 12, 2024

Uh oh!

Alkarex commented Sep 14, 2024

Uh oh!

Alkarex commented Sep 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Art4 commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alkarex commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Art4 commented May 17, 2022

Uh oh!

Art4 commented May 25, 2022

Uh oh!

Alkarex commented May 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Art4 commented Jun 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frenzie commented Jun 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alkarex commented Jun 1, 2022

Uh oh!

Alkarex commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alkarex commented Sep 11, 2024

Uh oh!

Alkarex commented Sep 12, 2024

Uh oh!

Alkarex commented Sep 14, 2024

Uh oh!

Alkarex commented Sep 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Art4 commented May 17, 2022 •

edited

Loading

Alkarex commented May 17, 2022 •

edited

Loading

Alkarex commented May 30, 2022 •

edited

Loading

Art4 commented Jun 1, 2022 •

edited

Loading

Frenzie commented Jun 1, 2022 •

edited

Loading

Alkarex commented Sep 10, 2024 •

edited

Loading