Add move to next unread Label on mark as read. by mtalexan · Pull Request #6886 · FreshRSS/FreshRSS

mtalexan · 2024-10-11T23:37:02Z

The Labels, unlike the Feeds and Categories, don't move to the next unread when "move to next unread on mark all as read" user feature is enabled.
Labels are more complex than Feeds and Categories because Entries can be in more than Label at a time. So when marking all Entries in the Label as read, it can cause other Labels to end up with all their Entries marked as read as well. The calculation of what the next Label/Feed/Category is to jump to normally happens when generating the link for the "Mark as Read" buttons, but it can't for Labels.

To address the problem for Labels, use a placeholder value during the pre-calculation of the "Mark as Read" button link. When that placeholder value is encountered during the "Mark as Read" action, the next Label with unread Entries will be calculated immediately after the mark as read action has been processed.

Fix all the translations of the 'jump_next' text to remove the '(feed or categories' part that no longer applies.
Attempt to fix the inconsistent Russian, Italian, and Polish translations of 'jump_next' text, which phrased the '(feed or categories)' part differently.

Open questions:

Should all the translations of jump_next be changed to the equivalent of "jump to next" instead of "jump to next sibling"?
Are the Italian, Polish, and Russian translation changes of jump_next correct?
Is using the default undefined nextGet=a acceptable or should some other value be used?
When there are no other labels unread should it return to the Main Feed (currently implemented) or should it stay on the current label with everything already read, or something else?
Is there a better approach for this? It's questionable MVC design to put this logic in the Controller, but the Model currently has no way to know and supply the answer until after the Controller has performed its actions.
Are there unit tests that can/should be written?

Closes #6867

Changes proposed in this pull request:

When "move to next unread on mark as read" is enabled, marking a Label as read will move to the next unread label after the current one
If there are no other Labels, it returns to the Main Feed
Supports later labels indirectly being marked as read and skipped during the "next unread"
Move to tags after the current as the first preference, but wrap back to the start of the list if necessary.
Remove the '(feed or category)' part of the jump_next string from all translations
(?) Correct inconsistent Italian jump_next translation (I don't speak this language)
(?) Correct inconsistent Polish jump_next translation (I dont speak this language)
(?) Correct inconsistent Russian jump_next translation (I don't speak this language)

Technical:

When calculating the nextGet value for the 'mark as read' links of Labels, use the "unknown" value (nextGet=a) to indicate it should be calculated after the markAsRead action.
Find the next unread "tag" (label) after performing the markAsRead on tags if nextGet=a
The Italian, Polish, and Russian translations of the jump_next didn't use the (feed or category) text at the end that could be easily identified and removed, but instead said "jump to next feed or category".
- Italian and Polish I used Google Translate to try and change these to "jump to next sibling" but this needs to be checked
- Russian apparently doesn't have a generic word for "sibling" (according to Google Translate), so I just left it as "jump to next"

How to test the feature manually:

Do not enable the "move to next unread on mark as read" user feature
Select a label with unread entries in it
Verify the URL for the "mark as read" button and link at the end of the list both have nextGet=t_... (pointing back to the current tag/label ID)
Click the button
Verify it returns to the current tag/label with nothing unread left

Case: Current behavior for disabled "move to next unread on mark as read" preserved

Enable the "move to next unread on mark as read" user feature
Select a label with unread entries in it
Verify the URL for the "mark as read" button and link at the end of the list both have 'nextGet=a`
Click the button
Verify it moves to the next tag/label with unread entries

Case: Simple move to next unread label after current

Select the only label with any unread entries in it
Click the Mark as Read button
Verify it returns to the Main Feed

Case: Nothing else unread

Select a label where the only unread entry is also the only unread entry in the label immediately after it
Click the Mark as Read button
Verify it moves to the next label that still has something unread in it

Case: Multiple labels change unread state at the same time

Select a label with no unread labels after it, but unread labels before it
Click the Mark as Read button
Verify it moves to the first unread label in the overall list (wraps)

Case: Wrap the mark as read check

Pull request checklist:

clear commit messages
code manually tested
(N/A) unit tests written (optional if too hard)
(N/A) documentation updated

Additional information can be found in the documentation.

The Labels, unlike the Feeds and Categories, don't move to the next unread when "move to next unread on mark all as read" user feature is enabled. Labels are more complex than Feeds and Categories because Entries can be in more than Label at a time. So when marking all Entries in the Label as read, it can cause other Labels to end up with all their Entries marked as read as well. The calculation of what the next Label/Feed/Category is to jump to normally happens when generating the link for the "Mark as Read" buttons, but it can't for Labels. To address the problem for Labels, use a placeholder value during the pre-calculation of the "Mark as Read" button link. When that placeholder value is encountered during the "Mark as Read" action, the next Label with unread Entries will be calculated immediately after the mark as read action has been processed. Fix all the translations of the 'jump_next' text to remove the '(feed or categories' part that no longer applies. Attempt to fix the inconsistent Russian, Italian, and Polish translations of 'jump_next' text, which phrased the '(feed or categories)' part differently.

Alkarex · 2024-10-12T07:58:53Z

Looks like a good start 👍🏻
Let us know if you need any help to finalise the PR.
Try:

make fix-all
make test-all

mtalexan · 2024-10-12T14:43:32Z

@Alkarex It sounds like you're OK with the way things are in terms of these questions I had, correct?

Is using the default undefined nextGet=a acceptable or should some other value be used?

When there are no other labels unread should it return to the Main Feed (currently implemented) or should it stay on the current label with everything already read, or something else?

Is there a better approach for this? It's questionable MVC design to put this logic in the Controller, but the Model currently has no way to know and supply the answer until after the Controller has performed its actions.

app/Controllers/entryController.php

Alkarex · 2024-10-14T07:54:14Z

Is using the default undefined nextGet=a acceptable or should some other value be used?

I need to set me into this part of the code a bit more to answer. Let's come back to details optimisations a bit later.

When there are no other labels unread should it return to the Main Feed (currently implemented) or should it stay on the current label with everything already read, or something else?

I do not have a strong feeling about it, but maybe showing the view with all labels could be one option.

Is there a better approach for this? It's questionable MVC design to put this logic in the Controller, but the Model currently has no way to know and supply the answer until after the Controller has performed its actions.

In particular, I would like to avoid the (double) additional SQL query if possible (at least keep the results in a variable), so let's look at the options. Ideas welcome. I cannot dig into it right now.

mtalexan · 2024-10-14T11:42:35Z

Is using the default undefined nextGet=a acceptable or should some other value be used?

I need to set me into this part of the code a bit more to answer. Let's come back to details optimisations a bit later.

The basic mechanic is for each mark as read button on the screen to query for what it's nextGet should be when it's generating the link URL in the JavaScript. That nextGet is usually where we detect if we're on a feed or category and determine what the next should be if we mark the current as read. It's largely implementing focus movement logic so it makes sense there. Labels however can have multiple simultaneously marked as read if the only unread entries are also the only unread in another Label. So we can't really precalculate the next unread label without duplicating the markAsRead database action. I opted instead to have it defer the determination until after the button was pressed and the current entries had actually been marked as read.

Only get the tag list once, and actually error check that it returned successfully. Fix a typo in a comment as well.

mtalexan · 2024-10-16T02:23:45Z

Changed the fallback case if there's no Labels with unread entries so it falls back to the overall Label list (nextGet=T).
Only query the tagDAO->listTags() once and use it in each foreach-loop.
Fixed the very broken Makefile fix* and test* targets
- Dependencies were pretty messed up for the vendor/bin/php*. Commands and were symlinking a non-existent ../vendor/bin/php* to bin/php* as part of a vendor/bin/php* target (!?)
- The "vendor/bin/php*" targets were all separately calling the bin/composer install ... even though a single call generated them all.
- vendor/bin/php* commands were being used instead of the bin/php* that were symlinked.
- The bin/composer dependency was missing from some targets

Also verified the make fix-all and make test-all pass now.

mtalexan · 2024-10-16T02:34:20Z

Oops forgot to check whether we're still in the fallback case before setting nextGet=T

Alkarex · 2024-10-16T07:46:24Z

Would you mind moving the Makefile changes to another PR?

Fix the missing check for whether we're in the fallback case or not.

mtalexan · 2024-10-17T03:47:13Z

Moved makefile changes to #6913.
I rebased out the Makefile change commit into the other MR, and rebased to drop it here. I don't know of a good way to do the same in a merge.

app/i18n/ru/conf.php

app/Controllers/entryController.php

Alkarex · 2024-10-17T08:39:12Z

Thanks 👍🏻
Please add a line for you https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [freshrss](https://github.com/FreshRSS/FreshRSS) | minor | `1.24.3` -> `1.26.0` | --- ### Release Notes <details> <summary>FreshRSS/FreshRSS (freshrss)</summary> ### [`v1.26.0`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2025-02-23-FreshRSS-1260) [Compare Source](FreshRSS/FreshRSS@1.25.0...1.26.0) - Features - Add order-by options to sort articles by received date (existing, default), publication date, title, link, random [#7149](FreshRSS/FreshRSS#7149) - Allow searching in all feeds, also feeds only visible at category level with `&get=A`, and also those archived with `&get=Z` [#7144](FreshRSS/FreshRSS#7144) - UI accessible from user-query view - Add search operator `intext:` [#7228](FreshRSS/FreshRSS#7228) - New shortcuts for adding user labels to articles [#7274](FreshRSS/FreshRSS#7274) - New *About* page with system information [#7161](FreshRSS/FreshRSS#7161) - Bug fixing - Fix regression denying access to app manifest [#7158](FreshRSS/FreshRSS#7158) - Fix unwanted feed description updates [#7269](FreshRSS/FreshRSS#7269) - Ensure no PHP buffer for SQLite download (some setups would first put the file in memory) [#7230](FreshRSS/FreshRSS#7230) - Fix XML encoding regression in HTML+XPath mode [#7345](FreshRSS/FreshRSS#7345) - Improve cURL proxy options and fix some constants [#7231](FreshRSS/FreshRSS#7231) - Fix UI of global view unread articles counter [#7247](FreshRSS/FreshRSS#7247) - Hide base theme in carrousel [#7234](FreshRSS/FreshRSS#7234) - Deployment - Reduce superfluous Docker builds [#7137](FreshRSS/FreshRSS#7137) - Docker default image (Debian 12 Bookworm) updated to PHP 8.2.26 and Apache 2.4.62 - Docker alternative image (Alpine 3.21) updated to PHP 8.3.16 - UI - Add footer icons to reader view [#7133](FreshRSS/FreshRSS#7133) - Remove local reference to font *Open Sans* to avoid bugs with some local versions [#7215](FreshRSS/FreshRSS#7215) - Improve stats page layout [#7243](FreshRSS/FreshRSS#7243) - Smaller *mark as read* button in mobile view [#5220](FreshRSS/FreshRSS#5220) - Add CSS class to various types of notifications to allow custom styling [#7287](FreshRSS/FreshRSS#7287) - Various UI and style improvements: [#7162](FreshRSS/FreshRSS#7162), [#7268](FreshRSS/FreshRSS#7268) Security - Better authorization label for OIDC in the UI [#7264](FreshRSS/FreshRSS#7264) - Allow comments in `force-https.txt` [#7259](FreshRSS/FreshRSS#7259) - I18n: - Improve German [#7177](FreshRSS/FreshRSS#7177), [#7275](FreshRSS/FreshRSS#7275), [#7278](FreshRSS/FreshRSS#7278) - Improve Japanese [#7187](FreshRSS/FreshRSS#7187), [#7195](FreshRSS/FreshRSS#7195), [#7332](FreshRSS/FreshRSS#7332) - Misc. - Improve PHP code [#7191](FreshRSS/FreshRSS#7191), [#7204](FreshRSS/FreshRSS#7204) - Upgrade to PHPStan 2 [#7131](FreshRSS/FreshRSS#7131), [#7164](FreshRSS/FreshRSS#7164), [#7224](FreshRSS/FreshRSS#7224), [#7270](FreshRSS/FreshRSS#7270), [#7281](FreshRSS/FreshRSS#7281), [#7282](FreshRSS/FreshRSS#7282) - Update to CssXPath 1.3.0 (no change) [#7211](FreshRSS/FreshRSS#7211) - Update dev dependencies [#7165](FreshRSS/FreshRSS#7165), [#7166](FreshRSS/FreshRSS#7166), [#7167](FreshRSS/FreshRSS#7167), [#7279](FreshRSS/FreshRSS#7279), [#7280](FreshRSS/FreshRSS#7280), [#7283](FreshRSS/FreshRSS#7283), [#7284](FreshRSS/FreshRSS#7284), [#7285](FreshRSS/FreshRSS#7285), [#7347](FreshRSS/FreshRSS#7347) - Update GitHub Actions to Ubuntu 24.04 [#7207](FreshRSS/FreshRSS#7207) ### [`v1.25.0`](https://github.com/FreshRSS/FreshRSS/blob/HEAD/CHANGELOG.md#2024-12-23-FreshRSS-1250) [Compare Source](FreshRSS/FreshRSS@1.24.3...1.25.0) - Features - Add support for [regex search (regular expressions)](https://freshrss.github.io/FreshRSS/en/users/10\_filter.html#regex) [#6706](FreshRSS/FreshRSS#6706), [#6926](FreshRSS/FreshRSS#6926) - ⚠️ Advanced regex syntax for searches depends on the database used (SQLite, PostgreSQL, MariaDB, MySQL), but FreshRSS filter actions such as auto-mark-as-read and auto-favourite always use [PHP PCRE2 syntax](https://php.net/regexp.introduction). - Allow dynamic search operator in user queries, like `search:UserQueryA date:P1d` [#6851](FreshRSS/FreshRSS#6851) - New feed mode *HTML+XPath+JSON dot notation* (JSON in HTML) [#6888](FreshRSS/FreshRSS#6888) - Better HTTP compliance with support for HTTP response headers `Cache-Control: max-age` and `Expires` [#6812](FreshRSS/FreshRSS#6812), [FreshRSS/simplepie#26](FreshRSS/simplepie#26) - Support custom HTTP request headers per feed (e.g. for `Authorization`) [#6820](FreshRSS/FreshRSS#6820) - New unicity policies and heuristic for feeds with bad article IDs [#4487](FreshRSS/FreshRSS#4487), [#6900](FreshRSS/FreshRSS#6900) - Fallback to GUID if article link is empty [#7051](FreshRSS/FreshRSS#7051) - New option to automatically mark new articles as read if an identical title already exists in the same category [#6922](FreshRSS/FreshRSS#6922) - New reading view option to display unread articles + favourites [#7088](FreshRSS/FreshRSS#7088) - And corresponding new filter state `&state=96` (no UI button yet) - Add ability to remove content from articles with CSS selectors, also when not using full content [#6786](FreshRSS/FreshRSS#6786), [#6807](FreshRSS/FreshRSS#6807) - Update `phpgt/cssxpath` library with improved CSS selectors [#6618](FreshRSS/FreshRSS#6618) - Support for `:last-child`, `:first-of-type`, `:last-of-type`, `^=`, `|=` - New condition option to selectively retrieve full content of articles [#33fd07f6f26310d4806077cc87bcdf9b8b940e35](FreshRSS/FreshRSS@33fd07f), [#7082](FreshRSS/FreshRSS#7082) - Allow parentheses in quoted search [#7055](FreshRSS/FreshRSS#7055) - New UI feature to download a user’ SQLite database or a database SQLite export (to be produced by CLI) [#6931](FreshRSS/FreshRSS#6931) - New button to delete errored feeds from a category [#7030](FreshRSS/FreshRSS#7030) - Better import of Inoreader user labels [#6791](FreshRSS/FreshRSS#6791) - Rebuild feed favicon on cache clear [#6961](FreshRSS/FreshRSS#6961) - New sharing with Bluesky [#7116](FreshRSS/FreshRSS#7116) - New sharing with Telegram [#6838](FreshRSS/FreshRSS#6838) - Bug fixing - Fix searches with a parenthesis before an operator like `("a b")` or `(!c)` [#6818](FreshRSS/FreshRSS#6818) - Fix auto-read tags [#6790](FreshRSS/FreshRSS#6790) - Fix CSS selector for removing elements [#7037](FreshRSS/FreshRSS#7037), [#7073](FreshRSS/FreshRSS#7073), [#7081](FreshRSS/FreshRSS#7081), [#7091](FreshRSS/FreshRSS#7091), [#7083](FreshRSS/FreshRSS#7083) - Fix redirection error after creating a new user [#6995](FreshRSS/FreshRSS#6995) - Fix favicon error in case of wrong URL [#6899](FreshRSS/FreshRSS#6899) - Use cURL to fetch extensions list (allows e.g. IPv6) [#6767](FreshRSS/FreshRSS#6767) - Fix XML encoding in cURL options [#6821](FreshRSS/FreshRSS#6821) - Fix initial UI scroll for some browsers [#7059](FreshRSS/FreshRSS#7059) - Fix menu for article tags in some cases [#6990](FreshRSS/FreshRSS#6990) - Fix share menu shortcut [#6825](FreshRSS/FreshRSS#6825) - Fix HTML regex pattern during install for compatibility with `v` mode [#7009](FreshRSS/FreshRSS#7009) - More robust creation of user data folder [#7000](FreshRSS/FreshRSS#7000) - API - Fix API for categories and labels containing a `+` [#7033](FreshRSS/FreshRSS#7033) - Compatibility with FocusReader - Supported by [Capy Reader](https://github.com/jocmp/capyreader) (Android, open source) [capyreader#492](jocmp/capyreader#492) - Improved UI for API [#7048](FreshRSS/FreshRSS#7048) - Allow adding multiple feeds to a category via API [#7017](FreshRSS/FreshRSS#7017) - API support edit multiple tags [#7060](FreshRSS/FreshRSS#7060) - API return all categories also those without any feed [#7020](FreshRSS/FreshRSS#7020) - Compatibility - Require PHP 8.1+ (drop PHP 7.4) [#6711](FreshRSS/FreshRSS#6711) - Improved support of PHP 8.4+ [#6618](FreshRSS/FreshRSS#6618), [phpgt/CssXPath#227](phpgt/CssXPath#227), [#6781](FreshRSS/FreshRSS#6781), [#4374](FreshRSS/FreshRSS#4374) - Require PostgreSQL 10+ (drop PostgreSQL 9.5) [#6705](FreshRSS/FreshRSS#6705) - Require MariaDB 10.0.5+ (drop MariaDB 5.5) [#6706](FreshRSS/FreshRSS#6706) - Require MySQL 8+ (drop MySQL 5.5.3) [#6706](FreshRSS/FreshRSS#6706) - Deployment - Docker: dev image `freshrss/freshrss:oldest` updated to Alpine 3.16 with PHP 8.1.22 and Apache 2.4.59 [#6711](FreshRSS/FreshRSS#6711) - Docker alternative image updated to Alpine 3.21 with PHP 8.3.14 and Apache 2.4.62 [#5383](FreshRSS/FreshRSS#5383) - Update Dockerfiles to newer key-value format [#6819](FreshRSS/FreshRSS#6819) - Docker minor improvement of entrypoint [#6827](FreshRSS/FreshRSS#6827) - SimplePie - Refactor [our embedding](lib/README.md) of SimplePie [#4374](FreshRSS/FreshRSS#4374) - Our fork is maintained in its [own repository](https://github.com/FreshRSS/simplepie/tree/freshrss). - Remove HTTP `Referer` [#6822](FreshRSS/FreshRSS#6822), [FreshRSS/simplepie#27](FreshRSS/simplepie#27) - If some sites require it, add `Referer: https://example.net/` to the custom HTTP headers of the feed [#6820](FreshRSS/FreshRSS#6820) - Upstream fixes [simplepie#878](simplepie/simplepie#878), [simplepie#883](simplepie/simplepie#883) - Sync upstream [#6840](FreshRSS/FreshRSS#6840), [#7067](FreshRSS/FreshRSS#7067) - Security - Apache protect more non-public folders and files [#6881](FreshRSS/FreshRSS#6881), [#6893](FreshRSS/FreshRSS#6893), [#7008](FreshRSS/FreshRSS#7008) - Add privacy settings on extension list retrieval [#4603](FreshRSS/FreshRSS#4603), [#7132](FreshRSS/FreshRSS#7132) - Fix login in unsafe mode when using a password with special XML characters [#6797](FreshRSS/FreshRSS#6797) - Fix login in e.g. Brave browser by avoiding synchronous XHR [#7023](FreshRSS/FreshRSS#7023) - Fix invalid login message [#7066](FreshRSS/FreshRSS#7066) - Modernise `windows.open noopener` (to avoid flash of white page in dark mode) [#7077](FreshRSS/FreshRSS#7077), [#7089](FreshRSS/FreshRSS#7089) - UI - Searchable *My Labels* field [#6753](FreshRSS/FreshRSS#6753) - Add subscription management button to reading view [#6946](FreshRSS/FreshRSS#6946) - New option for showing label menu in article row [#6984](FreshRSS/FreshRSS#6984) - Move to next unread label on mark as read [#6886](FreshRSS/FreshRSS#6886) - Improved article footer for small / mobile screens [#7031](FreshRSS/FreshRSS#7031) - Improve Web accessibility: fix `aria-hidden` bug, and use HTML5 `hidden` [#6910](FreshRSS/FreshRSS#6910) - Default styles for `<pre>` and `<code>` [#6770](FreshRSS/FreshRSS#6770) - Refactor the sharing menu to use a `<template>` instead of duplicated HTML code [#6751](FreshRSS/FreshRSS#6751), [#7113](FreshRSS/FreshRSS#7113) - Refactor the label menu to use a `<template>` [#6864](FreshRSS/FreshRSS#6864) - Rework UI for authors [#7054](FreshRSS/FreshRSS#7054) - Avoid Unicode escape of authors in HTML UI [#7056](FreshRSS/FreshRSS#7056) - Improved subscription management page [#6816](FreshRSS/FreshRSS#6816) - Improve user query management page [#7062](FreshRSS/FreshRSS#7062) - Restore JavaScript form validation compatibility with Web browsers using older engines (SeaMonkey) [#6777](FreshRSS/FreshRSS#6777) - Reorganise some options [#6920](FreshRSS/FreshRSS#6920) - New shortcut `?` to show shortcut page and help [#6981](FreshRSS/FreshRSS#6981) - Use of consistent colours in statistics [#7090](FreshRSS/FreshRSS#7090) - Various UI and style improvements [#6959](FreshRSS/FreshRSS#6959) - Extensions - New extension hook `simplepie_after_init` [#7007](FreshRSS/FreshRSS#7007) - I18n - Add Finnish [#6954](FreshRSS/FreshRSS#6954) - Improve English [#7049](FreshRSS/FreshRSS#7049), [#7053](FreshRSS/FreshRSS#7053) - Improve German [#6847](FreshRSS/FreshRSS#6847), [#7068](FreshRSS/FreshRSS#7068), [#7128](FreshRSS/FreshRSS#7128) - Improve Italian [#6872](FreshRSS/FreshRSS#6872), [#7069](FreshRSS/FreshRSS#7069), [#7086](FreshRSS/FreshRSS#7086) - Improve Spanish [#6894](FreshRSS/FreshRSS#6894), [#6908](FreshRSS/FreshRSS#6908) - Improve Turkish [#6960](FreshRSS/FreshRSS#6960) - Misc. - Better cache name for JSON feeds [#6768](FreshRSS/FreshRSS#6768) - Fix inversed encoding logic in `Minz_Request::paramArray()` [#6800](FreshRSS/FreshRSS#6800) - Pass PHPStan `booleansInConditions` [#6793](FreshRSS/FreshRSS#6793) - Rename PHPStan configuration file to `phpstan.dist.neon` to allow custom configuration in `phpstan.neon` [#6892](FreshRSS/FreshRSS#6892) - Code improvements [#6800](FreshRSS/FreshRSS#6800), [#6809](FreshRSS/FreshRSS#6809), [#6983](FreshRSS/FreshRSS#6983) - Makefile improvements [#6913](FreshRSS/FreshRSS#6913) - Fix PHPCS `ControlSignature` [#6896](FreshRSS/FreshRSS#6896) - Update *PHPMailer* [#6968](FreshRSS/FreshRSS#6968), [#7046](FreshRSS/FreshRSS#7046) - Code updates to PHP 8.1 syntax [#6748](FreshRSS/FreshRSS#6748) - Update dev dependencies [#6780](FreshRSS/FreshRSS#6780), [#6964](FreshRSS/FreshRSS#6964), , [#6965](FreshRSS/FreshRSS#6965), [#6966](FreshRSS/FreshRSS#6966), [#6967](FreshRSS/FreshRSS#6967), [#6970](FreshRSS/FreshRSS#6970), [#7042](FreshRSS/FreshRSS#7042), [#7043](FreshRSS/FreshRSS#7043), [#7044](FreshRSS/FreshRSS#7044), [#7045](FreshRSS/FreshRSS#7045), [#7047](FreshRSS/FreshRSS#7047), [#7052](FreshRSS/FreshRSS#7052) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.sh4ke.rocks/lickler/freshrss/pulls/29 Co-authored-by: Michael Wittig <michael.wittig@posteo.de> Co-committed-by: Michael Wittig <michael.wittig@posteo.de>

Alkarex added this to the 1.25.0 milestone Oct 12, 2024

Alkarex added the UI 🎨 User Interfaces label Oct 12, 2024

Alkarex added 3 commits October 14, 2024 09:37

Merge branch 'edge' into mark-as-read-to-next-unread-tag

c1af1cc

Minor code formattting

9911dfe

Fixes

2091fc9

Alkarex reviewed Oct 14, 2024

View reviewed changes

app/Controllers/entryController.php Outdated Show resolved Hide resolved

Merge branch 'edge' into mark-as-read-to-next-unread-tag

fd030d3

Merge branch 'edge' into mark-as-read-to-next-unread-tag

ab66a79

Alkarex mentioned this pull request Oct 15, 2024

Fix PHPCS ControlSignature #6896

Merged

Optimize next label lookup.

2c50124

Only get the tag list once, and actually error check that it returned successfully. Fix a typo in a comment as well.

Fix fallback when all Labels are read.

0d7da65

Fix the missing check for whether we're in the fallback case or not.

mtalexan force-pushed the mark-as-read-to-next-unread-tag branch from a879717 to 0d7da65 Compare October 17, 2024 03:44

mtalexan marked this pull request as ready for review October 17, 2024 03:48

Merge branch 'edge' into mark-as-read-to-next-unread-tag

4e40f9d

mtalexan mentioned this pull request Oct 17, 2024

[Bug] make fix-all and make test-all are broken #6912

Closed

Merge branch 'edge' into mark-as-read-to-next-unread-tag

4e62414

Alkarex reviewed Oct 17, 2024

View reviewed changes

app/i18n/ru/conf.php Outdated Show resolved Hide resolved

Update app/i18n/ru/conf.php

a1e06ca

Alkarex reviewed Oct 17, 2024

View reviewed changes

app/Controllers/entryController.php Outdated Show resolved Hide resolved

Alkarex added 2 commits October 17, 2024 10:20

Update app/Controllers/entryController.php

62362c8

Minor changes

3ff279a

One more minor

7dbe278

Alkarex merged commit 24a4fcb into FreshRSS:edge Oct 17, 2024

mtalexan mentioned this pull request Oct 27, 2024

[Bug] Some User Query searches in mark-as-read not being marked as read #6949

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add move to next unread Label on mark as read.#6886

Add move to next unread Label on mark as read.#6886
Alkarex merged 14 commits intoFreshRSS:edgefrom
mtalexan:mark-as-read-to-next-unread-tag

mtalexan commented Oct 11, 2024 •

edited

Loading

Uh oh!

Alkarex commented Oct 12, 2024

Uh oh!

mtalexan commented Oct 12, 2024

Uh oh!

Uh oh!

Alkarex commented Oct 14, 2024 •

edited

Loading

Uh oh!

mtalexan commented Oct 14, 2024

Uh oh!

mtalexan commented Oct 16, 2024 •

edited

Loading

Uh oh!

mtalexan commented Oct 16, 2024

Uh oh!

Alkarex commented Oct 16, 2024

Uh oh!

mtalexan commented Oct 17, 2024

Uh oh!

Uh oh!

Uh oh!

Alkarex commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mtalexan commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alkarex commented Oct 12, 2024

Uh oh!

mtalexan commented Oct 12, 2024

Uh oh!

Uh oh!

Alkarex commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtalexan commented Oct 14, 2024

Uh oh!

mtalexan commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtalexan commented Oct 16, 2024

Uh oh!

Alkarex commented Oct 16, 2024

Uh oh!

mtalexan commented Oct 17, 2024

Uh oh!

Uh oh!

Uh oh!

Alkarex commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mtalexan commented Oct 11, 2024 •

edited

Loading

Alkarex commented Oct 14, 2024 •

edited

Loading

mtalexan commented Oct 16, 2024 •

edited

Loading