Remove HTTP credentials in HTTP Referer#681
Merged
mblaney merged 1 commit intosimplepie:masterfrom Apr 23, 2021
Merged
Conversation
The HTTP Referer might appear in various logs and should not contain HTTP credentials `https://user:password@example.net/` New function `SimplePie_Misc::url_remove_credentials($url)` to strip credentials from a URL, before such a use. Piece of this downstream PR: FreshRSS/FreshRSS#815 (I use this function in several other circumpstances, which will be the topic of distinct PRs)
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
May 7, 2021
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP Referer might appear in various logs and should not contain HTTP credentials
https://user:password@example.net/New function
SimplePie_Misc::url_remove_credentials($url)to strip credentials from a URL, before such a use.Piece of this downstream PR: FreshRSS/FreshRSS#815
(I use this function in several other circumstances, which will be the topic of distinct PRs)