Test coverage #11
Merged
Test coverage #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundinc2
approved these changes
Sep 22, 2020
lundinc2
pushed a commit
that referenced
this pull request
Sep 23, 2020
* C_Verify - max coverage excluding unreachable lines(single-threaded) * C_VerifyInit - 100% Line Coverage * C_DigestInit - 100% Line coverage
lundinc2
added a commit
to lundinc2/corePKCS11
that referenced
this pull request
Sep 24, 2020
lundinc2
added a commit
to lundinc2/corePKCS11
that referenced
this pull request
Sep 24, 2020
lundinc2
added a commit
to lundinc2/corePKCS11
that referenced
this pull request
Dec 10, 2020
…low in core_pkcs11.c and a unfreed mutex in core_pkcs11_mbedtls.c
lundinc2
added a commit
to lundinc2/corePKCS11
that referenced
this pull request
Dec 10, 2020
…low in core_pkcs11.c and a unfreed mutex in core_pkcs11_mbedtls.c
lundinc2
added a commit
that referenced
this pull request
Dec 10, 2020
* Clean up PKCS #11 proofs. Fix a possible multiplication overflow in core_pkcs11.c and a unfreed mutex in core_pkcs11_mbedtls.c
aggarw13
pushed a commit
that referenced
this pull request
Jul 30, 2021
This PR makes fixes to doxygen documentation to make a clear distinction between corePKCS11 library and the PKCS #11 standard as well as add mechanism for keeping the configuration-macros up-to-date.
aggarw13
pushed a commit
that referenced
this pull request
Aug 2, 2021
A lot of code between posix/core_pkcs11_pal.c and windows/core_pkcs11_pal.c is duplicated which carries maintenance cost of copying the same code between files when adding features to the corePKCS11 library. Also, there is no mechanism of validating updates to the WinSim FreeRTOS PAL (as GitHub CI checks only validate POSIX builds). To avoid this inefficiency, this PR commonizes the utility logic of mapping PKCS #11 Labels and Handle objects to storage filenames in new core_pkcs11_pal_utils.[hc] files. This PR also makes hygiene re-arrangement to the source/portable directory for better understandability of the relevance of files.
archigup
added a commit
that referenced
this pull request
Aug 11, 2021
Misc improvements and library version number bump. Fixes file license headers. Adds CMake variables for PAL files. Fixes instructions in README.md. Adds mbedtls_utils.h. Lowers log level of logs that were incorrectly error level. Changes the filenames of stored PKCS #11 objects. Corrects changelog markdown formatting. Bumps version numbers for release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up line coverage.
100%:
C_VerifyInit,C_DigestInitMissing single line for
C_Verify, specifically iot_pkcs11_mbedtls.c#L4257 which can't be reached unless the mechanism changes during the function call, by some other means. Theoretically unreachable in single-threaded app.