Hygiene: Commonize PAL logic of mapping to storage filenames #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archigup
approved these changes
Jul 31, 2021
archigup
previously approved these changes
Jul 31, 2021
archigup
approved these changes
Jul 31, 2021
paulbartell
approved these changes
Aug 2, 2021
aggarg
added a commit
to aggarg/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 4, 2021
This commit updates the corePKCS11 submodule pointer to the latest and updates the CMake paths as per the changes in this PR: FreeRTOS/corePKCS11#123 Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
aggarg
added a commit
to aws/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 4, 2021
* Update CMake paths for the latest corePKCS11 This commit updates the corePKCS11 submodule pointer to the latest and updates the CMake paths as per the changes in this PR: FreeRTOS/corePKCS11#123 Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of code between posix/core_pkcs11_pal.c and windows/core_pkcs11_pal.c is duplicated which carries maintenance cost of copying the same code between files when adding features to the corePKCS11 library. Also, there is no mechanism of validating updates to the WinSim FreeRTOS PAL (as GitHub CI checks only validate POSIX builds).
To avoid this inefficiency, this PR commonizes the utility logic of mapping PKCS #11 Labels and Handle objects to storage filenames in new core_pkcs11_pal_utils.[hc] files. This PR also makes hygiene re-arrangement to the
source/portabledirectory for better understandability of the relevance of files.