Hygiene fixes in doxygen documentation #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbartell
reviewed
Jul 29, 2021
paulbartell
reviewed
Jul 29, 2021
paulbartell
reviewed
Jul 29, 2021
archigup
reviewed
Jul 29, 2021
archigup
reviewed
Jul 29, 2021
archigup
reviewed
Jul 29, 2021
archigup
reviewed
Jul 29, 2021
archigup
reviewed
Jul 29, 2021
Co-authored-by: Archit Gupta <71798289+archigup@users.noreply.github.com>
archigup
previously approved these changes
Jul 29, 2021
…compatibility of macros
archigup
previously approved these changes
Jul 29, 2021
aggarw13
commented
Jul 29, 2021
| # Change Log for corePKCS11 Library | ||
|
|
||
| ## v3.2.0 (August 2021) | ||
| - [#122] Add `core_pkcs11_config_defaults.h` file for default definition of configuration macros. and make doxygen documentation fixes. |
Author
There was a problem hiding this comment.
The minor version is bumped for the changes that are slated in #121
aggarg
reviewed
Jul 30, 2021
Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com>
archigup
reviewed
Jul 30, 2021
|
|
||
| #ifndef LIBRARY_LOG_LEVEL | ||
| #define LIBRARY_LOG_LEVEL LOG_DEBUG | ||
| #define LIBRARY_LOG_LEVEL LOG_NONE |
Member
There was a problem hiding this comment.
Is logging being turned off for tests?
Author
There was a problem hiding this comment.
It is enabled in CI through compile parameter though: https://github.com/FreeRTOS/corePKCS11/blob/main/.github/workflows/ci.yml#L23
aggarg
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes fixes to doxygen documentation to make a clear distinction between corePKCS11 library and the PKCS #11 standard as well as add mechanism for keeping the configuration-macros up-to-date.